| Conditions | 17 |
| Total Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like list_files() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | # -*- coding: utf-8 -*- |
||
| 28 | def list_files(dirname='.', digest=True): |
||
| 29 | """Yield (digest, fname) tuples for all interesting files |
||
| 30 | in `dirname`. |
||
| 31 | """ |
||
| 32 | skipdirs = ['__pycache__', '.git', '.svn', 'htmlcov', 'dist', 'build', |
||
| 33 | '.idea', 'tasks', 'static', 'media', 'data', 'migrations', |
||
| 34 | '.doctrees', '_static', 'node_modules', 'external', |
||
| 35 | 'jobs', 'tryout', 'tmp', '_coverage', |
||
| 36 | ] |
||
| 37 | skipexts = ['.pyc', '~', '.svg', '.txt', '.TTF', '.tmp', '.errmail', |
||
| 38 | '.email', '.bat', '.dll', '.exe', '.Dll', '.jpg', '.gif', |
||
| 39 | '.png', '.ico', '.db', '.md5'] |
||
| 40 | dirname = str(dirname) |
||
| 41 | skipfiles = read_skipfile(dirname) |
||
| 42 | |||
| 43 | def clean_dirs(directories): |
||
| 44 | """Remove directories that should be skipped. |
||
| 45 | """ |
||
| 46 | for d in directories: |
||
| 47 | if d.endswith('.egg-info'): |
||
| 48 | directories.remove(d) |
||
| 49 | for d in skipdirs: |
||
| 50 | if d in directories: |
||
| 51 | directories.remove(d) |
||
| 52 | |||
| 53 | def keep_file(filename, filepath): |
||
| 54 | """Returns False if the file should be skipped. |
||
| 55 | """ |
||
| 56 | if filename.startswith('.'): |
||
| 57 | return False |
||
| 58 | if filepath in skipfiles: |
||
| 59 | return False |
||
| 60 | for ext in skipexts: |
||
| 61 | if filename.endswith(ext): |
||
| 62 | return False |
||
| 63 | return True |
||
| 64 | |||
| 65 | for root, dirs, files in os.walk(os.path.abspath(dirname)): |
||
| 66 | clean_dirs(dirs) |
||
| 67 | for fname in files: |
||
| 68 | relpth = os.path.relpath( |
||
| 69 | os.path.join(root, fname), |
||
| 70 | dirname |
||
| 71 | ).replace('\\', '/') |
||
| 72 | |||
| 73 | parts = Path(relpth).parts() |
||
| 74 | if not keep_file(fname, relpth) or \ |
||
| 75 | any(p.startswith('.') for p in parts): |
||
| 76 | continue |
||
| 77 | |||
| 78 | pth = os.path.join(dirname, relpth) |
||
| 79 | if digest: |
||
| 80 | yield md5(open(pth, 'rb').read()).hexdigest(), relpth |
||
| 81 | else: |
||
| 82 | yield relpth |
||
| 83 | |||
| 111 |