ItemCollection - Code Metrics - Inspection of "Add number_format function to all prices" - darryldecode/laravelshoppingcart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#72)

unknown

created 2016-10-28 06:46 UTC

ItemCollection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	16
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	119
rs	10

6 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	getPriceSum()	4	1
A	hasConditions()	12	4
C	getPriceWithConditions()	32	7
A	getPriceSumWithConditions()	4	1
A	__get()	5	2

<?php namespace Darryldecode\Cart;

/**
 * Created by PhpStorm.
 * User: darryl
 * Date: 1/17/2015
 * Time: 11:03 AM
 */

use Illuminate\Support\Collection;

class ItemCollection extends Collection {

    /**
     * Sets the number of decimal points.
     *
     * @var
     */
    protected $decimals;

    /**
     * Definces the decimal point delimiter type
     *
     * @var
     */
    protected $dec_point;

    /**
     * Defines the thousands point delimiter type
     *
     * @var
     */
    protected $thousands_sep;

    /**
     * ItemCollection constructor.
     * @param array|mixed $items
     * @param $config
     */
    public function __construct($items, $config)
    {
        parent::__construct($items);

        $this->decimals = $config['decimals'];
        $this->dec_point = $config['dec_point'];
        $this->thousands_sep = $config['thousands_sep'];
    }

    /**
     * get the sum of price
     *
     * @return mixed|null
     */
    public function getPriceSum()
    {
        return $this->price * $this->quantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function __get($name)
    {
        if( $this->has($name) ) return $this->get($name);
        return null;
    }

    /**
     * check if item has conditions
     *
     * @return bool
     */
    public function hasConditions()
    {
        if( ! isset($this['conditions']) ) return false;
        if( is_array($this['conditions']) )
        {
            return count($this['conditions']) > 0;
        }
        $conditionInstance = "Darryldecode\\Cart\\CartCondition";
        if( $this['conditions'] instanceof $conditionInstance ) return true;

        return false;
    }

    /**
     * get the single price in which conditions are already applied
     *
     * @return mixed|null
     */
    public function getPriceWithConditions() 
    {
        $originalPrice = $this->price;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $newPrice = 0.00;
        $processed = 0;

        if( $this->hasConditions() )
        {
            if( is_array($this->conditions) )
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            {
                foreach($this->conditions as $condition)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                {
                    if( $condition->getTarget() === 'item' )
                    {
                        ( $processed > 0 ) ? $toBeCalculated = $newPrice : $toBeCalculated = $originalPrice;
                        $newPrice = $condition->applyCondition($toBeCalculated);
                        $processed++;
                    }
                }
            }
            else
            {
                if( $this['conditions']->getTarget() === 'item' )
                {
                    $newPrice = $this['conditions']->applyCondition($originalPrice);
                }
            }

            return number_format($newPrice, $this->decimals, $this->dec_point, $this->thousands_sep);
        }
        return number_format($originalPrice, $this->decimals, $this->dec_point, $this->thousands_sep);
    }

    /**
     * get the sum of price in which conditions are already applied
     *
     * @return mixed|null
     */
    public function getPriceSumWithConditions()
    {
        return number_format($this->getPriceWithConditions() * $this->quantity, $this->decimals, $this->dec_point, $this->thousands_sep);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php namespace Darryldecode\Cart;
2
3			/**
4			* Created by PhpStorm.
5			* User: darryl
6			* Date: 1/17/2015
7			* Time: 11:03 AM
8			*/
9
10			use Illuminate\Support\Collection;
11
12			class ItemCollection extends Collection {
13
14			/**
15			* Sets the number of decimal points.
16			*
17			* @var
18			*/
19			protected $decimals;
20
21			/**
22			* Definces the decimal point delimiter type
23			*
24			* @var
25			*/
26			protected $dec_point;
27
28			/**
29			* Defines the thousands point delimiter type
30			*
31			* @var
32			*/
33			protected $thousands_sep;
34
35			/**
36			* ItemCollection constructor.
37			* @param array\|mixed $items
38			* @param $config
39			*/
40			public function __construct($items, $config)
41			{
42			parent::__construct($items);
43
44			$this->decimals = $config['decimals'];
45			$this->dec_point = $config['dec_point'];
46			$this->thousands_sep = $config['thousands_sep'];
47			}
48
49			/**
50			* get the sum of price
51			*
52			* @return mixed\|null
53			*/
54			public function getPriceSum()
55			{
56			return $this->price * $this->quantity;
			0 ignored issues – show Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `price` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57			}
58
59			public function __get($name)
60			{
61			if( $this->has($name) ) return $this->get($name);
62			return null;
63			}
64
65			/**
66			* check if item has conditions
67			*
68			* @return bool
69			*/
70			public function hasConditions()
71			{
72			if( ! isset($this['conditions']) ) return false;
73			if( is_array($this['conditions']) )
74			{
75			return count($this['conditions']) > 0;
76			}
77			$conditionInstance = "Darryldecode\\Cart\\CartCondition";
78			if( $this['conditions'] instanceof $conditionInstance ) return true;
79
80			return false;
81			}
82
83			/**
84			* get the single price in which conditions are already applied
85			*
86			* @return mixed\|null
87			*/
88			public function getPriceWithConditions()
89			{
90			$originalPrice = $this->price;
			0 ignored issues – show Bug introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `price` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
91			$newPrice = 0.00;
92			$processed = 0;
93
94			if( $this->hasConditions() )
95			{
96			if( is_array($this->conditions) )
			0 ignored issues – show Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `conditions` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
97			{
98			foreach($this->conditions as $condition)
			0 ignored issues – show Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `conditions` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
99			{
100			if( $condition->getTarget() === 'item' )
101			{
102			( $processed > 0 ) ? $toBeCalculated = $newPrice : $toBeCalculated = $originalPrice;
103			$newPrice = $condition->applyCondition($toBeCalculated);
104			$processed++;
105			}
106			}
107			}
108			else
109			{
110			if( $this['conditions']->getTarget() === 'item' )
111			{
112			$newPrice = $this['conditions']->applyCondition($originalPrice);
113			}
114			}
115
116			return number_format($newPrice, $this->decimals, $this->dec_point, $this->thousands_sep);
117			}
118			return number_format($originalPrice, $this->decimals, $this->dec_point, $this->thousands_sep);
119			}
120
121			/**
122			* get the sum of price in which conditions are already applied
123			*
124			* @return mixed\|null
125			*/
126			public function getPriceSumWithConditions()
127			{
128			return number_format($this->getPriceWithConditions() * $this->quantity, $this->decimals, $this->dec_point, $this->thousands_sep);
			0 ignored issues – show Documentation introduced 2016-10-25 17:51 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
129			}
130			}
131

darryldecode / laravelshoppingcart

Pull Request — master (#72)

ItemCollection A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like