ItemCollection::getPriceSumWithConditions() - Code Metrics - Inspection of "New needed methods" - darryldecode/laravelshoppingcart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#83)

unknown

created 2017-02-07 13:09 UTC

ItemCollection::getPriceSumWithConditions() A

↳ Parent: ItemCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php namespace Darryldecode\Cart;

/**
 * Created by PhpStorm.
 * User: darryl
 * Date: 1/17/2015
 * Time: 11:03 AM
 */

use Darryldecode\Cart\Helpers\Helpers;
use Illuminate\Support\Collection;

class ItemCollection extends Collection {

    /**
     * Sets the config parameters.
     *
     * @var
     */
    protected $config;

    /**
     * ItemCollection constructor.
     * @param array|mixed $items
     * @param $config
     */
    public function __construct($items, $config)
    {
        parent::__construct($items);

        $this->config = $config;
    }

    /**
     * get the sum of price
     *
     * @return mixed|null
     */
    public function getPriceSum()
    {
        return Helpers::formatValue($this->price * $this->quantity, $this->config['format_numbers'], $this->config);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

    }

    public function __get($name)
    {
        if( $this->has($name) ) return $this->get($name);
        return null;
    }

    /**
     * check if item has conditions
     *
     * @return bool
     */
    public function hasConditions()
    {
        if( ! isset($this['conditions']) ) return false;
        if( is_array($this['conditions']) )
        {
            return count($this['conditions']) > 0;
        }
        $conditionInstance = "Darryldecode\\Cart\\CartCondition";
        if( $this['conditions'] instanceof $conditionInstance ) return true;

        return false;
    }

    /**
     * check if item has conditions
     *
     * @return mixed|null
     */
    public function getConditions()
    {
        if(! $this->hasConditions() ) return [];
        return $this['conditions'];
    }

    /**
     * get the single price in which conditions are already applied
     * @param bool $formatted
     * @return mixed|null
     */
    public function getPriceWithConditions($formatted = true)
    {
        $originalPrice = $this->price;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $newPrice = 0.00;
        $processed = 0;

        if( $this->hasConditions() )
        {
            if( is_array($this->conditions) )
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            {
                foreach($this->conditions as $condition)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                {
                    if( $condition->getTarget() === 'item' )
                    {
                        ( $processed > 0 ) ? $toBeCalculated = $newPrice : $toBeCalculated = $originalPrice;
                        $newPrice = $condition->applyCondition($toBeCalculated);
                        $processed++;
                    }
                }
            }
            else
            {
                if( $this['conditions']->getTarget() === 'item' )
                {
                    $newPrice = $this['conditions']->applyCondition($originalPrice);
                }
            }

            return Helpers::formatValue($newPrice, $formatted, $this->config);
        }
        return Helpers::formatValue($originalPrice, $formatted, $this->config);
    }

    /**
     * get the sum of price in which conditions are already applied
     * @param bool $formatted
     * @return mixed|null
     */
    public function getPriceSumWithConditions($formatted = true)
    {
        return Helpers::formatValue($this->getPriceWithConditions(false) * $this->quantity, $formatted, $this->config);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php namespace Darryldecode\Cart;
2
3			/**
4			* Created by PhpStorm.
5			* User: darryl
6			* Date: 1/17/2015
7			* Time: 11:03 AM
8			*/
9
10			use Darryldecode\Cart\Helpers\Helpers;
11			use Illuminate\Support\Collection;
12
13			class ItemCollection extends Collection {
14
15			/**
16			* Sets the config parameters.
17			*
18			* @var
19			*/
20			protected $config;
21
22			/**
23			* ItemCollection constructor.
24			* @param array\|mixed $items
25			* @param $config
26			*/
27			public function __construct($items, $config)
28			{
29			parent::__construct($items);
30
31			$this->config = $config;
32			}
33
34			/**
35			* get the sum of price
36			*
37			* @return mixed\|null
38			*/
39			public function getPriceSum()
40			{
41			return Helpers::formatValue($this->price * $this->quantity, $this->config['format_numbers'], $this->config);
			0 ignored issues – show Documentation introduced 2016-11-09 16:33 UTC by Report Bug Copy Issue Report The property `price` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-11-09 16:33 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42
43			}
44
45			public function __get($name)
46			{
47			if( $this->has($name) ) return $this->get($name);
48			return null;
49			}
50
51			/**
52			* check if item has conditions
53			*
54			* @return bool
55			*/
56			public function hasConditions()
57			{
58			if( ! isset($this['conditions']) ) return false;
59			if( is_array($this['conditions']) )
60			{
61			return count($this['conditions']) > 0;
62			}
63			$conditionInstance = "Darryldecode\\Cart\\CartCondition";
64			if( $this['conditions'] instanceof $conditionInstance ) return true;
65
66			return false;
67			}
68
69			/**
70			* check if item has conditions
71			*
72			* @return mixed\|null
73			*/
74			public function getConditions()
75			{
76			if(! $this->hasConditions() ) return [];
77			return $this['conditions'];
78			}
79
80			/**
81			* get the single price in which conditions are already applied
82			* @param bool $formatted
83			* @return mixed\|null
84			*/
85			public function getPriceWithConditions($formatted = true)
86			{
87			$originalPrice = $this->price;
			0 ignored issues – show Bug introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `price` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
88			$newPrice = 0.00;
89			$processed = 0;
90
91			if( $this->hasConditions() )
92			{
93			if( is_array($this->conditions) )
			0 ignored issues – show Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `conditions` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
94			{
95			foreach($this->conditions as $condition)
			0 ignored issues – show Documentation introduced 2015-12-02 01:08 UTC by Report Bug Copy Issue Report The property `conditions` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
96			{
97			if( $condition->getTarget() === 'item' )
98			{
99			( $processed > 0 ) ? $toBeCalculated = $newPrice : $toBeCalculated = $originalPrice;
100			$newPrice = $condition->applyCondition($toBeCalculated);
101			$processed++;
102			}
103			}
104			}
105			else
106			{
107			if( $this['conditions']->getTarget() === 'item' )
108			{
109			$newPrice = $this['conditions']->applyCondition($originalPrice);
110			}
111			}
112
113			return Helpers::formatValue($newPrice, $formatted, $this->config);
114			}
115			return Helpers::formatValue($originalPrice, $formatted, $this->config);
116			}
117
118			/**
119			* get the sum of price in which conditions are already applied
120			* @param bool $formatted
121			* @return mixed\|null
122			*/
123			public function getPriceSumWithConditions($formatted = true)
124			{
125			return Helpers::formatValue($this->getPriceWithConditions(false) * $this->quantity, $formatted, $this->config);
			0 ignored issues – show Documentation introduced 2016-11-09 16:33 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<Darryldecode\Cart\ItemCollection>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
126			}
127			}
128

darryldecode / laravelshoppingcart

Pull Request — master (#83)

ItemCollection::getPriceSumWithConditions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like