CartItemCollectionTest::testCollection() - Code Metrics - Inspection of "change in php requirement" - darkorsa/shop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (168fd2)

by Dariusz

created 2019-04-22 10:45 UTC

CartItemCollectionTest::testCollection() A

↳ Parent: CartItemCollectionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Plane\Shop\Tests;

use Plane\Shop\CartItem;
use Plane\Shop\CartItemCollection;

class CartItemCollectionTest extends \PHPUnit\Framework\TestCase
{
    public function testCollection()
    {
        $firstCartItem  = $this->createMock(CartItem::class);
        $secondCartItem = $this->createMock(CartItem::class);

        $cartItemCollection = new CartItemCollection;
        $cartItemCollection->addItem($firstCartItem);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $cartItemCollection->addItem($secondCartItem);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertTrue($cartItemCollection->length() == 2);
        $this->assertSame([
            0 => $firstCartItem,
            1 => $secondCartItem
        ], $cartItemCollection->getItems());
    }
}


1			<?php
2
3			namespace Plane\Shop\Tests;
4
5			use Plane\Shop\CartItem;
6			use Plane\Shop\CartItemCollection;
7
8			class CartItemCollectionTest extends \PHPUnit\Framework\TestCase
9			{
10			public function testCollection()
11			{
12			$firstCartItem = $this->createMock(CartItem::class);
13			$secondCartItem = $this->createMock(CartItem::class);
14
15			$cartItemCollection = new CartItemCollection;
16			$cartItemCollection->addItem($firstCartItem);
			0 ignored issues – show Documentation introduced 2019-04-22 10:52 UTC by Report Bug Copy Issue Report `$firstCartItem` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Plane\Shop\CartItemInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17			$cartItemCollection->addItem($secondCartItem);
			0 ignored issues – show Documentation introduced 2019-04-22 10:52 UTC by Report Bug Copy Issue Report `$secondCartItem` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Plane\Shop\CartItemInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18
19			$this->assertTrue($cartItemCollection->length() == 2);
20			$this->assertSame([
21			0 => $firstCartItem,
22			1 => $secondCartItem
23			], $cartItemCollection->getItems());
24			}
25			}
26

darkorsa / shop

Branch — master (168fd2)

CartItemCollectionTest::testCollection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like