TotalPriceThresholdDiscount::applyDiscount() - Code Metrics - Inspection of "change in php requirement" - darkorsa/shop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (168fd2)

by Dariusz

created 2019-04-22 10:45 UTC

TotalPriceThresholdDiscount::applyDiscount() A

↳ Parent: TotalPriceThresholdDiscount

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php declare(strict_types=1);

/*
 * This file is part of the Plane\Shop package.
 *
 * (c) Dariusz Korsak <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Plane\Shop\Discount;

use Money\Money;
use Money\Currency;
use Money\Currencies\ISOCurrencies;
use Money\Parser\DecimalMoneyParser;
use Plane\Shop\CartDiscountAbstract;

class TotalPriceThresholdDiscount extends CartDiscountAbstract
{
    protected $treshold;
    
    protected $discount;

    protected function applyDiscount(): void
    {
        $this->priceAfterDiscount = $this->price;
        
        if ($this->price->greaterThanOrEqual($this->getTreshold($this->currency))) {
            $this->priceAfterDiscount = $this->price->subtract($this->price->multiply($this->discount));
        }
    }

    private function getTreshold(string $currency): Money
    {
        $moneyParser = new DecimalMoneyParser(new ISOCurrencies());
        
        return $moneyParser->parse((string) $this->treshold, new Currency($currency));
    }
}


1		<?php declare(strict_types=1);
2
3		/*
4		* This file is part of the Plane\Shop package.
5		*
6		* (c) Dariusz Korsak <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Plane\Shop\Discount;
13
14		use Money\Money;
15		use Money\Currency;
16		use Money\Currencies\ISOCurrencies;
17		use Money\Parser\DecimalMoneyParser;
18		use Plane\Shop\CartDiscountAbstract;
19
20		class TotalPriceThresholdDiscount extends CartDiscountAbstract
21		{
22		protected $treshold;
23
24		protected $discount;
25
26	3	protected function applyDiscount(): void
27		{
28	3	$this->priceAfterDiscount = $this->price;
29
30	3	if ($this->price->greaterThanOrEqual($this->getTreshold($this->currency))) {
31	2	$this->priceAfterDiscount = $this->price->subtract($this->price->multiply($this->discount));
32		}
33	3	}
34
35	3	private function getTreshold(string $currency): Money
36		{
37	3	$moneyParser = new DecimalMoneyParser(new ISOCurrencies());
38
39	3	return $moneyParser->parse((string) $this->treshold, new Currency($currency));
40		}
41		}
42

darkorsa / shop

Branch — master (168fd2)

TotalPriceThresholdDiscount::applyDiscount() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like