Plane\Shop\Tests\PaymentTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	43.1 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreateObject()	9	9	1
A	testCreateIncompleteObject()	0	9	1
A	testCreateObjectWithInvalidFeeType()	0	6	1
A	testFixedFee()	8	8	1
A	testPercentageFee()	8	8	1

<?php

namespace Plane\Shop\Tests;

use Money\Money;
use Plane\Shop\Payment;
use InvalidArgumentException;

/**
 * Payment test suite
 *
 * @author Dariusz Korsak <dkorsak@gmail.com>
 * @package Plane\Shop
 */
class PaymentTest extends \PHPUnit\Framework\TestCase
{
    use MoneyTrait;

    const CURRENCY = 'USD';

    const PAYMENT_INPUT = [
       'id'             => 1,
       'name'           => 'PayPal',
       'description'    => 'Payment with Paypal',
       'fee'            => 4
    ];

    public function testCreateObject()

This method seems to be duplicated in your project.

    {
        $payment = new Payment(self::PAYMENT_INPUT);

        $this->assertSame(self::PAYMENT_INPUT['id'], $payment->getId());
        $this->assertSame(self::PAYMENT_INPUT['name'], $payment->getName());
        $this->assertSame(self::PAYMENT_INPUT['description'], $payment->getDescription());
        $this->assertInstanceOf(Money::class, $payment->getFee($this->getMoney(10), self::CURRENCY));
    }

    public function testCreateIncompleteObject()
    {
        $input = self::PAYMENT_INPUT;
        unset($input['fee']);

        $this->expectException(InvalidArgumentException::class);

        $payment = new Payment($input);

$payment is not used, you could remove the assignment.

    }

    public function testCreateObjectWithInvalidFeeType()
    {
        $this->expectException(InvalidArgumentException::class);

        $payment = new Payment(self::PAYMENT_INPUT, 'newfeetype');

$payment is not used, you could remove the assignment.

    }

    public function testFixedFee()

This method seems to be duplicated in your project.

    {
        $payment = new Payment(self::PAYMENT_INPUT, Payment::FEE_FIXED);
        
        $fee = $payment->getFee($this->getMoney(10), self::CURRENCY);
 
        $this->assertEquals(4.00, $this->getAmount($fee));
    }

    public function testPercentageFee()

This method seems to be duplicated in your project.

    {
        $payment = new Payment(self::PAYMENT_INPUT, Payment::FEE_PERCENTAGE);

        $fee = $payment->getFee($this->getMoney(10), self::CURRENCY);

        $this->assertEquals(0.40, $this->getAmount($fee));
    }
}