DansMaCulotte\PrestashopWebService\Commands\AbstractPrestashopProductsImportCommand

Complexity

Total Complexity

16

Size/Duplication

Total Lines	140
Duplicated Lines	16.43 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	handle()	0	51	9
A	getProducts()	23	23	5
A	getProduct()	0	9	1
	importProduct()	0	1	?

<?php

namespace DansMaCulotte\PrestashopWebService\Commands;

use DansMaCulotte\PrestashopWebService\Exceptions\PrestashopWebServiceException;
use DansMaCulotte\PrestashopWebService\PrestashopWebService;
use Illuminate\Console\Command;
use Illuminate\Support\Collection;

abstract class AbstractPrestashopProductsImportCommand extends Command
{
    const PRESTASHOP_RESOURCE_NAME = 'products';

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'prestashop:import-products {--id=* : The Prestashop ID of the product}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Import or sync products with Prestashop products database';

    /**
     * The prestashop singleton from the service provider
     * @var PrestashopWebService
     */
    protected $prestashop;

    /**
     * Create a new command instance.
     *
     * @param PrestashopWebService $prestashop
     */
    public function __construct(PrestashopWebService $prestashop)
    {
        parent::__construct();

        $this->prestashop = $prestashop;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $ids = $this->option('id');
        $debug = $this->getOutput()->isDebug();

        $this->info('Importing products');

        $products = count($ids) ? $ids : $this->getProducts();
        $bar = $this->output->createProgressBar(count($products));

        $skippedProducts = new Collection();

        foreach ($products as $productId) {

The expression $products of type array|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            try {
                $rawProduct = $this->getProduct($productId);
                $product = $this->importProduct($rawProduct);

                if (!$product) {
                    $skippedProducts->add(new Collection([
                        'id' => (string) $rawProduct->id,
                        'reference' => (string) $rawProduct->reference,
                    ]));

                    if ($debug) {
                        $this->info("\nPrestashop: Skipped product [{$rawProduct->id}] $rawProduct->reference");
                    }
                } else {
                    if ($debug) {
                        $this->info("\nPrestashop: Imported product [{$rawProduct->id}] {$rawProduct->reference}");
                    }
                }

                $bar->advance();
            } catch (\Exception $e) {
                if ($debug) {
                    $this->info($e->getMessage());
                }
                $this->error("\nPrestashop: Failed to request product " . (string) $productId);
            }
        }

        $bar->finish();

        $skippedProductsCount = count($skippedProducts);
        if ($skippedProductsCount) {
            $this->info("\nPrestashop: Skipped {$skippedProductsCount} products");
            $this->table(['id', 'reference'], $skippedProducts->toArray());
        }

        return true;
    }

    /**
     * @return array
     */
    public function getProducts()

This method seems to be duplicated in your project.

    {
        try {
            $xml = $this->prestashop->get([
                'resource' => self::PRESTASHOP_RESOURCE_NAME,
            ]);
        } catch (PrestashopWebServiceException $e) {
            $this->error('Prestashop: Failed to request products');
            return [];
        }

        $ids = [];

        foreach ($xml->products->children() as $product) {
            foreach ($product->attributes() as $key => $value) {
                if ($key === 'id') {
                    array_push($ids, (string)$value);
                }
            }
        }

        return $ids;
    }

    /**
     * @param string $id
     * @return \SimpleXMLElement
     * @throws \DansMaCulotte\PrestashopWebService\Exceptions\PrestashopWebServiceException
     */
    public function getProduct(string $id)
    {
        $xml = $this->prestashop->get([
            'resource' => self::PRESTASHOP_RESOURCE_NAME,
            'id' => $id,
        ]);

        return $xml->product;
    }

    /**
     * @param \SimpleXMLElement $product
     */
    abstract public function importProduct(\SimpleXMLElement $product);
}