Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class NewsletterFacadeTest extends TestCase |
||
| 11 | { |
||
| 12 | /** @test */ |
||
| 13 | public function should_instantiate_facade_with_null_driver() |
||
| 14 | { |
||
| 15 | $newsletter = $this->app[Newsletter::class]; |
||
| 16 | $this->assertInstanceOf(NullDriver::class, $newsletter); |
||
| 17 | } |
||
| 18 | |||
| 19 | /** @test */ |
||
| 20 | public function should_instantiate_facade_with_mailchimp_driver() |
||
| 21 | { |
||
| 22 | config()->set('newsletter.driver', 'mailchimp'); |
||
| 23 | config()->set('newsletter.mailchimp.apiKey', 'mailchimp-keytest'); |
||
| 24 | |||
| 25 | $newsletter = $this->app[Newsletter::class]; |
||
| 26 | $this->assertInstanceOf(Newsletter::class, $newsletter); |
||
| 27 | $this->assertInstanceOf(MailchimpDriver::class, $newsletter->driver); |
||
| 28 | } |
||
| 29 | |||
| 30 | /** @test */ |
||
| 31 | public function should_instantiate_facade_with_mailjet_driver() |
||
| 32 | { |
||
| 33 | config()->set('newsletter.driver', 'mailjet'); |
||
| 34 | config()->set('newsletter.mailjet.key', 'mailjet-keytest'); |
||
| 35 | config()->set('newsletter.mailjet.secret', 'mailjet-secrettest'); |
||
| 36 | |||
| 37 | $newsletter = $this->app[Newsletter::class]; |
||
| 38 | $this->assertInstanceOf(Newsletter::class, $newsletter); |
||
| 39 | $this->assertInstanceOf(MailjetDriver::class, $newsletter->driver); |
||
| 40 | } |
||
| 41 | |||
| 42 | } |
||
| 43 |