NotAFramework\App\Controllers\Controller

Complexity

Total Complexity

2

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setRequest()	0	4	1
A	setResponse()	0	4	1

<?php
/**
 * @file
 * Contains \NotAFramework\App\Controllers\Controller.
 */

namespace NotAFramework\App\Controllers;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

abstract class Controller
{
    /**
     * The HTTP request object.
     *
     * @var Request
     */
    protected $request;

    /**
     * The HTTP response object.
     *
     * @var Response
     */
    protected $response;

    /**
     * Set the request object.
     *
     * @param Request $request
     *   HTTP request object.
     */
    public function setRequest(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    /**
     * Set the response object.
     *
     * @param Response $response
     *   HTTP response object.
     */
    public function setResponse(Response $response)
    {
        $this->response = $response;
    }
}