Issues in featuredcourses_form.php (master) - Issues in master - danielneis/moodle-block_featuredcourses - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

featuredcourses_form.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.

/**
 * The list of featured courses form.
 *
 * @package    block_featuredcourses
 * @copyright  Daniel Neis <[email protected]>
 * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 */

defined('MOODLE_INTERNAL') || die;

require_once($CFG->libdir.'/formslib.php');

/**
 * The form for handling featured courses.
 */
class featuredcourses_form extends moodleform {
namespace YourVendor;

class YourClass { }

    /**
     * Form definition.
     */
    public function definition() {
        global $CFG;
function myFunction($a, $b) {
    // Do something
}

        $mform = $this->_form;
        $availablecourses  = $this->_customdata['availablecourses'];
        $featuredcourses  = $this->_customdata['featuredcourses'];
        $availablecourseslist = array();
        foreach ($availablecourses as $c) {
            $availablecourseslist[$c->id] = $c->shortname . ' : ' . $c->fullname;
        }

        // Forms to edit existing featured courses.
        foreach ($featuredcourses as $c) {
            $mform->addElement('header', 'featured',
                               get_string('featuredcourse', 'block_featuredcourses', $c->shortname . ' - '. $c->fullname));

            $mform->addElement('hidden', 'featured['.$c->id.'][id]', null);
            $mform->setType('featured['.$c->id.'][id]', PARAM_INT);
            $mform->setConstant('featured['.$c->id.'][id]', $c->id);

            $mform->addElement('text', 'featured['.$c->id.'][sortorder]', get_string('sortorder', 'block_featuredcourses'));
            $mform->addRule('featured['.$c->id.'][sortorder]',
                            get_string('missingsortorder', 'block_featuredcourses'), 'required', null, 'client');
            $mform->setType('featured['.$c->id.'][sortorder]', PARAM_INT);
            $mform->setDefault('featured['.$c->id.'][sortorder]', $c->sortorder);

            $mform->addElement('static', 'link',
                               get_string('deletelink', 'block_featuredcourses',
                                          $CFG->wwwroot.'/blocks/featuredcourses/delete_featuredcourse.php?courseid='.$c->id));

        }

        // Add a new featured course.
        $mform->addElement('header', 'add', get_string('addfeaturedcourse', 'block_featuredcourses'));

        $mform->addElement('checkbox', 'doadd', get_string('doadd', 'block_featuredcourses'));

        $mform->addElement('select', 'newfeatured[courseid]',
                           get_string('courseid', 'block_featuredcourses'), $availablecourseslist);
        $mform->addRule('newfeatured[courseid]', get_string('missingcourseid', 'block_featuredcourses'),
                        'required', null, 'client');
        $mform->disabledIf('newfeatured[courseid]', 'doadd', 'notchecked');

        $mform->addElement('text', 'newfeatured[sortorder]', get_string('sortorder', 'block_featuredcourses'));
        $mform->addRule('newfeatured[sortorder]', get_string('missingsortorder', 'block_featuredcourses'),
                        'required', null, 'client');
        $mform->setType('newfeatured[sortorder]', PARAM_INT);
        $mform->disabledIf('newfeatured[sortorder]', 'doadd', 'notchecked');

        $mform->addElement('submit', 'save', get_string('savechanges'));

        $mform->closeHeaderBefore('save');
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-21 21:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 32 and the first side effect is on line 25. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			// This file is part of Moodle - http://moodle.org/
3			//
4			// Moodle is free software: you can redistribute it and/or modify
5			// it under the terms of the GNU General Public License as published by
6			// the Free Software Foundation, either version 3 of the License, or
7			// (at your option) any later version.
8			//
9			// Moodle is distributed in the hope that it will be useful,
10			// but WITHOUT ANY WARRANTY; without even the implied warranty of
11			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			// GNU General Public License for more details.
13			//
14			// You should have received a copy of the GNU General Public License
15			// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
16
17			/**
18			* The list of featured courses form.
19			*
20			* @package block_featuredcourses
21			* @copyright Daniel Neis <[email protected]>
22			* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
23			*/
24
25			defined('MOODLE_INTERNAL') \|\| die;
26
27			require_once($CFG->libdir.'/formslib.php');
28
29			/**
30			* The form for handling featured courses.
31			*/
32			class featuredcourses_form extends moodleform {
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-03 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
33
34			/**
35			* Form definition.
36			*/
37			public function definition() {
38			global $CFG;
			0 ignored issues – show Compatibility Best Practice introduced 2015-12-03 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
39
40			$mform = $this->_form;
41			$availablecourses = $this->_customdata['availablecourses'];
42			$featuredcourses = $this->_customdata['featuredcourses'];
43			$availablecourseslist = array();
44			foreach ($availablecourses as $c) {
45			$availablecourseslist[$c->id] = $c->shortname . ' : ' . $c->fullname;
46			}
47
48			// Forms to edit existing featured courses.
49			foreach ($featuredcourses as $c) {
50			$mform->addElement('header', 'featured',
51			get_string('featuredcourse', 'block_featuredcourses', $c->shortname . ' - '. $c->fullname));
52
53			$mform->addElement('hidden', 'featured['.$c->id.'][id]', null);
54			$mform->setType('featured['.$c->id.'][id]', PARAM_INT);
55			$mform->setConstant('featured['.$c->id.'][id]', $c->id);
56
57			$mform->addElement('text', 'featured['.$c->id.'][sortorder]', get_string('sortorder', 'block_featuredcourses'));
58			$mform->addRule('featured['.$c->id.'][sortorder]',
59			get_string('missingsortorder', 'block_featuredcourses'), 'required', null, 'client');
60			$mform->setType('featured['.$c->id.'][sortorder]', PARAM_INT);
61			$mform->setDefault('featured['.$c->id.'][sortorder]', $c->sortorder);
62
63			$mform->addElement('static', 'link',
64			get_string('deletelink', 'block_featuredcourses',
65			$CFG->wwwroot.'/blocks/featuredcourses/delete_featuredcourse.php?courseid='.$c->id));
66
67			}
68
69			// Add a new featured course.
70			$mform->addElement('header', 'add', get_string('addfeaturedcourse', 'block_featuredcourses'));
71
72			$mform->addElement('checkbox', 'doadd', get_string('doadd', 'block_featuredcourses'));
73
74			$mform->addElement('select', 'newfeatured[courseid]',
75			get_string('courseid', 'block_featuredcourses'), $availablecourseslist);
76			$mform->addRule('newfeatured[courseid]', get_string('missingcourseid', 'block_featuredcourses'),
77			'required', null, 'client');
78			$mform->disabledIf('newfeatured[courseid]', 'doadd', 'notchecked');
79
80			$mform->addElement('text', 'newfeatured[sortorder]', get_string('sortorder', 'block_featuredcourses'));
81			$mform->addRule('newfeatured[sortorder]', get_string('missingsortorder', 'block_featuredcourses'),
82			'required', null, 'client');
83			$mform->setType('newfeatured[sortorder]', PARAM_INT);
84			$mform->disabledIf('newfeatured[sortorder]', 'doadd', 'notchecked');
85
86			$mform->addElement('submit', 'save', get_string('savechanges'));
87
88			$mform->closeHeaderBefore('save');
89			}
90			}
91

danielneis / moodle-block_featuredcourses

Issues (14)

Security Analysis no request data

featuredcourses_form.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like