frontend - Code Metrics - danielneis/moodle-availability_maxviews - Measure and Improve Code Quality continuously with Scrutinizer

frontend A
last analyzed 2018-02-06 17:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	7
c	2
b	1
f	0
lcom	0
cbo	0
dl	0
loc	37
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	allow_add()	0	11	6
A	get_javascript_strings()	0	3	1

<?php

// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.

/**
 * Front-end class.
 *
 * @package availability_maxviews
 * @copyright 2015 Daniel Neis Araujo
 * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 */

namespace availability_maxviews;

defined('MOODLE_INTERNAL') || die();

/**
 * Front-end class.
 *
 * @package availability_maxviews
 * @copyright 2015 Daniel Neis Araujo
 * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 */
class frontend extends \core_availability\frontend {

    /**
     * This plugin was tested with several core plugins and relies on events which has crud = "r".
     *
     * There are issues with the Wiki, Label and Book modules.
     * For details see: https://github.com/danielneis/moodle-availability_maxviews/issues/2
     *
     * @param \stdClass $course Course object
     * @param \cm_info $cm Course-module currently being edited (null if none)
     * @param \section_info $section Section currently being edited (null if none)
     */
    protected function allow_add($course, \cm_info $cm = null, \section_info $section = null) {

        global $add;
function myFunction($a, $b) {
    // Do something
}

        if ($cm) {
            return (($cm->modname != 'book') && ($cm->modname != 'wiki') && ($cm->modname != 'label'));
        } else {
            return (($add != 'book') && ($add != 'wiki') && ($add != 'label'));
        }

    }

    /**
     * Gets a list of string identifiers (in the plugin's language file) that
     * are required in JavaScript for this plugin. The default returns nothing.
     *
     * You do not need to include the 'title' string (which is used by core) as
     * this is automatically added.
     *
     * @return array Array of required string identifiers
     */
    protected function get_javascript_strings() {
        return array('ajaxerror', 'fieldlabel');
    }
}


frontend A
last analyzed 2018-02-06 17:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-14 20:29 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 36 and the first side effect is on line 27. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			// This file is part of Moodle - http://moodle.org/
3			//
4			// Moodle is free software: you can redistribute it and/or modify
5			// it under the terms of the GNU General Public License as published by
6			// the Free Software Foundation, either version 3 of the License, or
7			// (at your option) any later version.
8			//
9			// Moodle is distributed in the hope that it will be useful,
10			// but WITHOUT ANY WARRANTY; without even the implied warranty of
11			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			// GNU General Public License for more details.
13			//
14			// You should have received a copy of the GNU General Public License
15			// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
16
17			/**
18			* Front-end class.
19			*
20			* @package availability_maxviews
21			* @copyright 2015 Daniel Neis Araujo
22			* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
23			*/
24
25			namespace availability_maxviews;
26
27			defined('MOODLE_INTERNAL') \|\| die();
28
29			/**
30			* Front-end class.
31			*
32			* @package availability_maxviews
33			* @copyright 2015 Daniel Neis Araujo
34			* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
35			*/
36			class frontend extends \core_availability\frontend {
37
38			/**
39			* This plugin was tested with several core plugins and relies on events which has crud = "r".
40			*
41			* There are issues with the Wiki, Label and Book modules.
42			* For details see: https://github.com/danielneis/moodle-availability_maxviews/issues/2
43			*
44			* @param \stdClass $course Course object
45			* @param \cm_info $cm Course-module currently being edited (null if none)
46			* @param \section_info $section Section currently being edited (null if none)
47			*/
48			protected function allow_add($course, \cm_info $cm = null, \section_info $section = null) {
49
50			global $add;
			0 ignored issues – show Compatibility Best Practice introduced 2018-01-29 19:50 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
51
52			if ($cm) {
53			return (($cm->modname != 'book') && ($cm->modname != 'wiki') && ($cm->modname != 'label'));
54			} else {
55			return (($add != 'book') && ($add != 'wiki') && ($add != 'label'));
56			}
57
58			}
59
60			/**
61			* Gets a list of string identifiers (in the plugin's language file) that
62			* are required in JavaScript for this plugin. The default returns nothing.
63			*
64			* You do not need to include the 'title' string (which is used by core) as
65			* this is automatically added.
66			*
67			* @return array Array of required string identifiers
68			*/
69			protected function get_javascript_strings() {
70			return array('ajaxerror', 'fieldlabel');
71			}
72			}
73

danielneis / moodle-availability_maxviews

frontend A last analyzed 2018-02-06 17:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

frontend A
last analyzed 2018-02-06 17:36 UTC