InformatorServer::getServerDetailsFromPhp() - Code Metrics - Inspection of "few internal optimizations for a more balanced cod..." - danielgp/informator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 27cd9e...04f20b )

by Daniel

created 2016-01-02 02:50 UTC

InformatorServer::getServerDetailsFromPhp() A

↳ Parent: InformatorServer

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
rs	9.4286
cc	2
eloc	15
nc	2
nop	0

<?php

/*
 * The MIT License
 *
 * Copyright 2016 Daniel Popiniuc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

namespace danielgp\informator;

trait InformatorServer
{

    protected function getDoctrineCaheFolder()
    {
        $tmpFolder        = $this->getTemporaryFolder();
        $tmpDoctrineCache = null;
        clearstatcache();
        if (is_dir($tmpFolder) && is_writable($tmpFolder)) {
            $tmpDoctrineCache = $tmpFolder . DIRECTORY_SEPARATOR . 'DoctrineCache';
        }
        return $tmpDoctrineCache;
    }

    protected function getServerDetailsEvaluated($hostName)
    {
        $serverMachineType = 'unknown';
        $serverInfo        = [
            'name'    => 'undisclosed',
            'host'    => $hostName,
            'release' => 'undisclosed',
            'version' => 'undisclosed',
        ];
        if (function_exists('php_uname')) {
            $infServerFromPhp  = $this->getServerDetailsFromPhp();
            $serverMachineType = $infServerFromPhp['OS Architecture'];
            $serverInfo        = $infServerFromPhp['OS Name+Host+Release+Version'];
        }
        return [
            'serverMachineType' => $serverMachineType,
            'serverInfo'        => $serverInfo,
        ];
    }

    private function getServerDetailsFromPhp()
    {
        $aReturn                    = [];
        $aReturn['OS Architecture'] = php_uname('m');
        $knownValues                = [
            'AMD64' => 'x64 (64 bit)',
            'i386'  => 'x86 (32 bit)',
            'i586'  => 'x86 (32 bit)',
        ];
        if (array_key_exists(php_uname('m'), $knownValues)) {
            $aReturn['OS Architecture'] = $knownValues[php_uname('m')];
        }
        $aReturn['OS Name+Host+Release+Version'] = [
            'name'    => php_uname('s'),
            'host'    => php_uname('n'),
            'release' => php_uname('r'),
            'version' => php_uname('v'),
        ];
        return $aReturn;
    }

    protected function getServerSoftware()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return $_SERVER['SERVER_SOFTWARE'];
    }

    protected function getTemporaryFolder()
    {
        return sys_get_temp_dir() . DIRECTORY_SEPARATOR;
    }
}


1			<?php
2
3			/*
4			* The MIT License
5			*
6			* Copyright 2016 Daniel Popiniuc.
7			*
8			* Permission is hereby granted, free of charge, to any person obtaining a copy
9			* of this software and associated documentation files (the "Software"), to deal
10			* in the Software without restriction, including without limitation the rights
11			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
12			* copies of the Software, and to permit persons to whom the Software is
13			* furnished to do so, subject to the following conditions:
14			*
15			* The above copyright notice and this permission notice shall be included in
16			* all copies or substantial portions of the Software.
17			*
18			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
23			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
24			* THE SOFTWARE.
25			*/
26
27			namespace danielgp\informator;
28
29			trait InformatorServer
30			{
31
32			protected function getDoctrineCaheFolder()
33			{
34			$tmpFolder = $this->getTemporaryFolder();
35			$tmpDoctrineCache = null;
36			clearstatcache();
37			if (is_dir($tmpFolder) && is_writable($tmpFolder)) {
38			$tmpDoctrineCache = $tmpFolder . DIRECTORY_SEPARATOR . 'DoctrineCache';
39			}
40			return $tmpDoctrineCache;
41			}
42
43			protected function getServerDetailsEvaluated($hostName)
44			{
45			$serverMachineType = 'unknown';
46			$serverInfo = [
47			'name' => 'undisclosed',
48			'host' => $hostName,
49			'release' => 'undisclosed',
50			'version' => 'undisclosed',
51			];
52			if (function_exists('php_uname')) {
53			$infServerFromPhp = $this->getServerDetailsFromPhp();
54			$serverMachineType = $infServerFromPhp['OS Architecture'];
55			$serverInfo = $infServerFromPhp['OS Name+Host+Release+Version'];
56			}
57			return [
58			'serverMachineType' => $serverMachineType,
59			'serverInfo' => $serverInfo,
60			];
61			}
62
63			private function getServerDetailsFromPhp()
64			{
65			$aReturn = [];
66			$aReturn['OS Architecture'] = php_uname('m');
67			$knownValues = [
68			'AMD64' => 'x64 (64 bit)',
69			'i386' => 'x86 (32 bit)',
70			'i586' => 'x86 (32 bit)',
71			];
72			if (array_key_exists(php_uname('m'), $knownValues)) {
73			$aReturn['OS Architecture'] = $knownValues[php_uname('m')];
74			}
75			$aReturn['OS Name+Host+Release+Version'] = [
76			'name' => php_uname('s'),
77			'host' => php_uname('n'),
78			'release' => php_uname('r'),
79			'version' => php_uname('v'),
80			];
81			return $aReturn;
82			}
83
84			protected function getServerSoftware()
			0 ignored issues – show Coding Style introduced 2016-01-02 00:44 UTC by Report Bug Copy Issue Report `getServerSoftware` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
85			{
86			return $_SERVER['SERVER_SOFTWARE'];
87			}
88
89			protected function getTemporaryFolder()
90			{
91			return sys_get_temp_dir() . DIRECTORY_SEPARATOR;
92			}
93			}
94

danielgp / informator

Push — master ( 27cd9e...04f20b )

InformatorServer::getServerDetailsFromPhp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like