Compare - Code Metrics - Inspection of "the most complex function (method) now is a trait..." - danielgp/info-compare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2cd481...da65e9 )

by Daniel

created 2016-01-02 23:21 UTC

Compare B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	221
Duplicated Lines	5.88 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	10
Bugs	0	Features	1

Metric	Value
wmc	36
c	10
b	0
f	1
lcom	2
cbo	4
dl	13
loc	221
rs	8.8

10 Methods

Rating	Name	Duplication	Size	Complexity
C	mergeArraysIntoFirstSecond()	13	49	12
A	setFooterHtml()	0	13	1
A	setFormCurlInfos()	0	8	1
A	setFormInfos()	0	10	2
A	__construct()	0	23	2
C	displayTableFromMultiLevelArray()	0	41	7
A	getConfiguration()	0	15	2
A	processInfos()	0	13	3
B	setDefaultOptions()	0	15	5
A	setHeaderHtml()	0	12	1

How to fix Duplicated Code

<?php

/**
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2015 Daniel Popiniuc
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 */

namespace danielgp\info_compare;

/**
 * Description of compare
 *
 * @author Transformer-
 */
class Compare
{

    use \danielgp\common_lib\CommonCode,
        \danielgp\info_compare\ConfigurationCompare,
        \danielgp\info_compare\OutputFormBuilder;

    private $informatorInternalArray;
    private $localConfiguration;
    private $serverConfiguration;
    private $config;

    public function __construct()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->getConfiguration();
        $this->applicationFlags                        = [
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'available_languages' => [
                'en_US' => 'EN',
                'ro_RO' => 'RO',
            ],
            'default_language'    => 'ro_RO',
            'name'                => 'Info-Compare'
        ];
        echo $this->setHeaderHtml();
        $this->setDefaultOptions();
        $rqst                                          = new \Symfony\Component\HttpFoundation\Request;
        $this->informatorInternalArray['superGlobals'] = $rqst->createFromGlobals();
        echo $this->setFormOptions();
        if (isset($_GET['Label'])) {
            $this->processInfos();
            echo $this->setFormCurlInfos();
            echo $this->setFormInfos();
        }
        echo $this->setFooterHtml();
    }

    private function displayTableFromMultiLevelArray($firstArray, $secondArray)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ((!is_array($firstArray)) || (!is_array($secondArray))) {
            return '';
        }
        $firstRow     = $this->mergeArraysIntoFirstSecond($firstArray, $secondArray, ['first', 'second']);
        $secondRow    = $this->mergeArraysIntoFirstSecond($secondArray, $firstArray, ['second', 'first']);
        $row          = array_merge($firstRow, $secondRow);
        ksort($row);
        $urlArguments = '?Label=' . $_GET['Label'];
        $sString[]    = '<table style="width:100%">'
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                . '<thead><tr>'
                . '<th>Identifier</th>'
                . '<th><a href="' . $this->config['Servers'][$_GET['localConfig']]['url']
                . $urlArguments . '" target="_blank">'
                . $this->config['Servers'][$_GET['localConfig']]['name'] . '</a></th>'
                . '<th><a href="' . $this->config['Servers'][$_GET['serverConfig']]['url']
                . $urlArguments . '" target="_blank">'
                . $this->config['Servers'][$_GET['serverConfig']]['name'] . '</a></th>'
                . '</tr></thead>'
                . '<tbody>';
        if ($_GET['displayOnlyDifferent'] == '1') {
            $displayOnlyDifferent = true;
        } else {
            $displayOnlyDifferent = false;
        }
        foreach ($row as $key => $value) {
            $rowString = '<tr><td style="width:20%;">' . $key . '</td><td style="width:40%;">'
                    . str_replace(',', ', ', $value['first']) . '</td><td style="width:40%;">'
                    . str_replace(',', ', ', $value['second']) . '</td></tr>';
            if ($displayOnlyDifferent) {
                if ($value['first'] != $value['second']) {
                    $sString[] = $rowString;
                }
            } else {
                $sString[] = $rowString;
            }
        }
        $sString[] = '</tbody></table>';
        return implode('', $sString);
    }

    private function getConfiguration()
    {
        $storedConfiguration = $this->configuredDeployedInformators();
        foreach ($storedConfiguration['informators'] as $key => $value) {
            $this->config['Servers'][] = [
                'name' => $key,
                'url'  => $value,
            ];
        }
        $haystack                                = array_keys($storedConfiguration['informators']);
        $this->config['Defaults']['Label']       = $storedConfiguration['default']['label'];
        $this->config['Defaults']['Source']      = array_search($storedConfiguration['default']['source'], $haystack);
        $this->config['Defaults']['Target']      = array_search($storedConfiguration['default']['target'], $haystack);
        $this->config['Defaults']['ResultsType'] = $storedConfiguration['default']['typeOfResults'];
    }

    private function mergeArraysIntoFirstSecond($firstArray, $secondArray, $pSequence = ['first', 'second'])
    {
        $row = [];
        foreach ($firstArray as $key => $value) {
            if (is_array($value)) {
                foreach ($value as $key2 => $value2) {
                    if (is_array($value2)) {
                        foreach ($value2 as $key3 => $value3) {
                            if (is_array($value3)) {
                                foreach ($value3 as $key4 => $value4) {
                                    $keyCrt                      = $key . '_' . $key2 . '__' . $key3 . '__' . $key4;
                                    $row[$keyCrt][$pSequence[0]] = $value4;
                                    if (isset($secondArray[$key][$key2][$key3][$key4])) {
                                        $row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2][$key3][$key4];
                                    } else {
                                        $row[$keyCrt][$pSequence[1]] = '';
                                    }
                                }
                            } else {
                                $keyCrt                      = $key . '_' . $key2 . '__' . $key3;
                                $row[$keyCrt][$pSequence[0]] = $value3;
                                if (isset($secondArray[$key][$key2][$key3])) {

                                    $row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2][$key3];
                                } else {
                                    $row[$keyCrt][$pSequence[1]] = '';
                                }
                            }
                        }
                    } else {
                        $keyCrt                      = $key . '_' . $key2;
                        $row[$keyCrt][$pSequence[0]] = $value2;
                        if (isset($secondArray[$key][$key2])) {
                            $row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2];
                        } else {
                            $row[$keyCrt][$pSequence[1]] = '';
                        }
                    }
                }
            } else {

                $row[$key][$pSequence[0]] = $value;
                if (isset($secondArray[$key])) {
                    $row[$key][$pSequence[1]] = $secondArray[$key];
                } else {
                    $row[$key][$pSequence[1]] = '';
                }
            }
        }
        return $row;
    }

    private function processInfos()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_GET['localConfig']) && isset($_GET['serverConfig'])) {
            $urlArguments              = '?Label=' . urlencode($_GET['Label']);
            $source                    = $this->config['Servers'][$_GET['localConfig']]['url'] . $urlArguments;
            $this->localConfiguration  = $this->getContentFromUrlThroughCurlAsArrayIfJson($source);
            $destination               = $this->config['Servers'][$_GET['serverConfig']]['url'] . $urlArguments;
            $this->serverConfiguration = $this->getContentFromUrlThroughCurlAsArrayIfJson($destination);
        } else {
            $this->localConfiguration  = ['response' => '', 'info' => ''];
            $this->serverConfiguration = ['response' => '', 'info' => ''];
        }
    }

    private function setDefaultOptions()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_GET['displayOnlyDifferent'])) {
            $_GET['displayOnlyDifferent'] = $this->config['Defaults']['ResultsType'];
        }
        if (!isset($_GET['localConfig'])) {
            $_GET['localConfig'] = $this->config['Defaults']['Source'];
        }
        if (!isset($_GET['serverConfig'])) {
            $_GET['serverConfig'] = $this->config['Defaults']['Target'];
        }
        if (!isset($_GET['Label'])) {
            $_GET['Label'] = $this->config['Defaults']['Label'];
        }
    }

    private function setFooterHtml()
    {
        $sReturn   = [];
        $sReturn[] = '</div><!-- from main Tabber -->';
        $sReturn[] = '<div class="resetOnly author">&copy; 2015 Daniel Popiniuc</div>';
        $sReturn[] = '<hr/>';
        $sReturn[] = '<div class="disclaimer">'
                . 'The developer cannot be liable of any data input or results, '
                . 'included but not limited to any implication of these '
                . '(anywhere and whomever there might be these)!'
                . '</div>';
        return $this->setFooterCommon(implode('', $sReturn));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    private function setFormCurlInfos()
    {
        $source      = $this->localConfiguration['info'];
        $destination = $this->serverConfiguration['info'];
        return '<div class="tabbertab" id="tabCurl" title="CURL infos">'
                . $this->displayTableFromMultiLevelArray($source, $destination)
                . '</div><!--from tabCurl-->';
    }

    private function setFormInfos()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $source      = $this->localConfiguration['response'];
        $destination = $this->serverConfiguration['response'];
        return '<div class="tabbertab'
                . (isset($_GET['Label']) ? ' tabbertabdefault' : '')
                . '" id="tabConfigs" title="Informations">'
                . $this->displayTableFromMultiLevelArray($source, $destination)
                . '</div><!--from tabConfigs-->';
    }

    private function setHeaderHtml()
    {
        return $this->setHeaderCommon([
                    'lang'       => 'en-US',
                    'title'      => $this->applicationFlags['name'],
                    'css'        => 'css/main.css',
                    'javascript' => 'js/tabber.min.js',
                ])
                . $this->setJavascriptContent('document.write(\'<style type="text/css">.tabber{display:none;}</style>\');')
                . '<h1>' . $this->applicationFlags['name'] . '</h1>'
                . '<div class="tabber" id="tab">';
    }
}


1		<?php
2
3		/**
4		*
5		* The MIT License (MIT)
6		*
7		* Copyright (c) 2015 Daniel Popiniuc
8		*
9		* Permission is hereby granted, free of charge, to any person obtaining a copy
10		* of this software and associated documentation files (the "Software"), to deal
11		* in the Software without restriction, including without limitation the rights
12		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
13		* copies of the Software, and to permit persons to whom the Software is
14		* furnished to do so, subject to the following conditions:
15		*
16		* The above copyright notice and this permission notice shall be included in all
17		* copies or substantial portions of the Software.
18		*
19		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
20		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
21		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
22		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
23		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
24		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
25		* SOFTWARE.
26		*
27		*/
28
29		namespace danielgp\info_compare;
30
31		/**
32		* Description of compare
33		*
34		* @author Transformer-
35		*/
36		class Compare
37		{
38
39		use \danielgp\common_lib\CommonCode,
40		\danielgp\info_compare\ConfigurationCompare,
41		\danielgp\info_compare\OutputFormBuilder;
42
43		private $informatorInternalArray;
44		private $localConfiguration;
45		private $serverConfiguration;
46		private $config;
47
48		public function __construct()
		0 ignored issues – show Coding Style introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49		{
50		$this->getConfiguration();
51		$this->applicationFlags = [
		0 ignored issues – show Bug introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report The property `applicationFlags` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52		'available_languages' => [
53		'en_US' => 'EN',
54		'ro_RO' => 'RO',
55		],
56		'default_language' => 'ro_RO',
57		'name' => 'Info-Compare'
58		];
59		echo $this->setHeaderHtml();
60		$this->setDefaultOptions();
61		$rqst = new \Symfony\Component\HttpFoundation\Request;
62		$this->informatorInternalArray['superGlobals'] = $rqst->createFromGlobals();
63		echo $this->setFormOptions();
64		if (isset($_GET['Label'])) {
65		$this->processInfos();
66		echo $this->setFormCurlInfos();
67		echo $this->setFormInfos();
68		}
69		echo $this->setFooterHtml();
70		}
71
72		private function displayTableFromMultiLevelArray($firstArray, $secondArray)
		0 ignored issues – show Coding Style introduced 2016-01-02 23:23 UTC by Report Bug Copy Issue Report `displayTableFromMultiLevelArray` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
73		{
74		if ((!is_array($firstArray)) \|\| (!is_array($secondArray))) {
75		return '';
76		}
77		$firstRow = $this->mergeArraysIntoFirstSecond($firstArray, $secondArray, ['first', 'second']);
78		$secondRow = $this->mergeArraysIntoFirstSecond($secondArray, $firstArray, ['second', 'first']);
79		$row = array_merge($firstRow, $secondRow);
80		ksort($row);
81		$urlArguments = '?Label=' . $_GET['Label'];
82		$sString[] = '<table style="width:100%">'
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report `$sString` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$sString = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
83		. '<thead><tr>'
84		. '<th>Identifier</th>'
85		. '<th><a href="' . $this->config['Servers'][$_GET['localConfig']]['url']
86		. $urlArguments . '" target="_blank">'
87		. $this->config['Servers'][$_GET['localConfig']]['name'] . '</a></th>'
88		. '<th><a href="' . $this->config['Servers'][$_GET['serverConfig']]['url']
89		. $urlArguments . '" target="_blank">'
90		. $this->config['Servers'][$_GET['serverConfig']]['name'] . '</a></th>'
91		. '</tr></thead>'
92		. '<tbody>';
93		if ($_GET['displayOnlyDifferent'] == '1') {
94		$displayOnlyDifferent = true;
95		} else {
96		$displayOnlyDifferent = false;
97		}
98		foreach ($row as $key => $value) {
99		$rowString = '<tr><td style="width:20%;">' . $key . '</td><td style="width:40%;">'
100		. str_replace(',', ', ', $value['first']) . '</td><td style="width:40%;">'
101		. str_replace(',', ', ', $value['second']) . '</td></tr>';
102		if ($displayOnlyDifferent) {
103		if ($value['first'] != $value['second']) {
104		$sString[] = $rowString;
105		}
106		} else {
107		$sString[] = $rowString;
108		}
109		}
110		$sString[] = '</tbody></table>';
111		return implode('', $sString);
112		}
113
114		private function getConfiguration()
115		{
116		$storedConfiguration = $this->configuredDeployedInformators();
117		foreach ($storedConfiguration['informators'] as $key => $value) {
118		$this->config['Servers'][] = [
119		'name' => $key,
120		'url' => $value,
121		];
122		}
123		$haystack = array_keys($storedConfiguration['informators']);
124		$this->config['Defaults']['Label'] = $storedConfiguration['default']['label'];
125		$this->config['Defaults']['Source'] = array_search($storedConfiguration['default']['source'], $haystack);
126		$this->config['Defaults']['Target'] = array_search($storedConfiguration['default']['target'], $haystack);
127		$this->config['Defaults']['ResultsType'] = $storedConfiguration['default']['typeOfResults'];
128		}
129
130		private function mergeArraysIntoFirstSecond($firstArray, $secondArray, $pSequence = ['first', 'second'])
131		{
132		$row = [];
133		foreach ($firstArray as $key => $value) {
134		if (is_array($value)) {
135		foreach ($value as $key2 => $value2) {
136		if (is_array($value2)) {
137		foreach ($value2 as $key3 => $value3) {
138		if (is_array($value3)) {
139		foreach ($value3 as $key4 => $value4) {
140		$keyCrt = $key . '_' . $key2 . '__' . $key3 . '__' . $key4;
141		$row[$keyCrt][$pSequence[0]] = $value4;
142		if (isset($secondArray[$key][$key2][$key3][$key4])) {
143		$row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2][$key3][$key4];
144		} else {
145		$row[$keyCrt][$pSequence[1]] = '';
146		}
147		}
148		} else {
149		$keyCrt = $key . '_' . $key2 . '__' . $key3;
150		$row[$keyCrt][$pSequence[0]] = $value3;
151	View Code Duplication	if (isset($secondArray[$key][$key2][$key3])) {
		0 ignored issues – show Duplication introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		$row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2][$key3];
153		} else {
154		$row[$keyCrt][$pSequence[1]] = '';
155		}
156		}
157		}
158		} else {
159		$keyCrt = $key . '_' . $key2;
160		$row[$keyCrt][$pSequence[0]] = $value2;
161		if (isset($secondArray[$key][$key2])) {
162		$row[$keyCrt][$pSequence[1]] = $secondArray[$key][$key2];
163		} else {
164		$row[$keyCrt][$pSequence[1]] = '';
165		}
166		}
167		}
168	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
169		$row[$key][$pSequence[0]] = $value;
170		if (isset($secondArray[$key])) {
171		$row[$key][$pSequence[1]] = $secondArray[$key];
172		} else {
173		$row[$key][$pSequence[1]] = '';
174		}
175		}
176		}
177		return $row;
178		}
179
180		private function processInfos()
		0 ignored issues – show Coding Style introduced 2016-01-02 23:23 UTC by Report Bug Copy Issue Report `processInfos` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
181		{
182		if (isset($_GET['localConfig']) && isset($_GET['serverConfig'])) {
183		$urlArguments = '?Label=' . urlencode($_GET['Label']);
184		$source = $this->config['Servers'][$_GET['localConfig']]['url'] . $urlArguments;
185		$this->localConfiguration = $this->getContentFromUrlThroughCurlAsArrayIfJson($source);
186		$destination = $this->config['Servers'][$_GET['serverConfig']]['url'] . $urlArguments;
187		$this->serverConfiguration = $this->getContentFromUrlThroughCurlAsArrayIfJson($destination);
188		} else {
189		$this->localConfiguration = ['response' => '', 'info' => ''];
190		$this->serverConfiguration = ['response' => '', 'info' => ''];
191		}
192		}
193
194		private function setDefaultOptions()
		0 ignored issues – show Coding Style introduced 2016-01-02 23:23 UTC by Report Bug Copy Issue Report `setDefaultOptions` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
195		{
196		if (!isset($_GET['displayOnlyDifferent'])) {
197		$_GET['displayOnlyDifferent'] = $this->config['Defaults']['ResultsType'];
198		}
199		if (!isset($_GET['localConfig'])) {
200		$_GET['localConfig'] = $this->config['Defaults']['Source'];
201		}
202		if (!isset($_GET['serverConfig'])) {
203		$_GET['serverConfig'] = $this->config['Defaults']['Target'];
204		}
205		if (!isset($_GET['Label'])) {
206		$_GET['Label'] = $this->config['Defaults']['Label'];
207		}
208		}
209
210		private function setFooterHtml()
211		{
212		$sReturn = [];
213		$sReturn[] = '</div><!-- from main Tabber -->';
214		$sReturn[] = '<div class="resetOnly author">© 2015 Daniel Popiniuc</div>';
215		$sReturn[] = '<hr/>';
216		$sReturn[] = '<div class="disclaimer">'
217		. 'The developer cannot be liable of any data input or results, '
218		. 'included but not limited to any implication of these '
219		. '(anywhere and whomever there might be these)!'
220		. '</div>';
221		return $this->setFooterCommon(implode('', $sReturn));
		0 ignored issues – show Documentation introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report `implode('', $sReturn)` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
222		}
223
224		private function setFormCurlInfos()
225		{
226		$source = $this->localConfiguration['info'];
227		$destination = $this->serverConfiguration['info'];
228		return '<div class="tabbertab" id="tabCurl" title="CURL infos">'
229		. $this->displayTableFromMultiLevelArray($source, $destination)
230		. '</div><!--from tabCurl-->';
231		}
232
233		private function setFormInfos()
		0 ignored issues – show Coding Style introduced 2016-01-02 21:10 UTC by Report Bug Copy Issue Report `setFormInfos` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
234		{
235		$source = $this->localConfiguration['response'];
236		$destination = $this->serverConfiguration['response'];
237		return '<div class="tabbertab'
238		. (isset($_GET['Label']) ? ' tabbertabdefault' : '')
239		. '" id="tabConfigs" title="Informations">'
240		. $this->displayTableFromMultiLevelArray($source, $destination)
241		. '</div><!--from tabConfigs-->';
242		}
243
244		private function setHeaderHtml()
245		{
246		return $this->setHeaderCommon([
247		'lang' => 'en-US',
248		'title' => $this->applicationFlags['name'],
249		'css' => 'css/main.css',
250		'javascript' => 'js/tabber.min.js',
251		])
252		. $this->setJavascriptContent('document.write(\'<style type="text/css">.tabber{display:none;}</style>\');')
253		. '<h1>' . $this->applicationFlags['name'] . '</h1>'
254		. '<div class="tabber" id="tab">';
255		}
256		}
257

danielgp / info-compare

Push — master ( 2cd481...da65e9 )

Compare B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like