MySQLiAdvancedOutput::establishDefaultEnumSet() - Code Metrics - Inspection of "few code optimizations (eliminated few else constr..." - danielgp/common-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( e647cd...a0585d )

by Daniel
created 2016-01-22 20:12 UTC
MySQLiAdvancedOutput::establishDefaultEnumSet() A

↳ Parent: MySQLiAdvancedOutput
Complexity

Conditions	1
Paths	1
Size

Total Lines	8
Code Lines	5
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	1
<?php

/**
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2015 Daniel Popiniuc
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 */

namespace danielgp\common_lib;

/**
 * usefull functions to get quick results
 *
 * @author Daniel Popiniuc
 */
trait MySQLiAdvancedOutput
{

    use DomComponentsByDanielGP;

    protected $advCache = null;

    /**
     *
     * @param type $tblSrc
     */
    private function establishDatabaseAndTable($tblSrc)
    {
        if (strpos($tblSrc, '.') === false) { // in case the DB is ommited get the default one
            if (!defined('MYSQL_DATABASE')) {
                define('MYSQL_DATABASE', 'information_schema');
            }
            return [$tblSrc, MYSQL_DATABASE];
        }
        return explode('.', str_replace('`', '', $tblSrc));
    }

    private function establishDefaultEnumSet($fldType)
    {
        $dfltArray = [
            'enum' => ['additional' => ['size' => 1], 'suffix' => ''],
            'set'  => ['additional' => ['size' => 5, 'multiselect'], 'suffix' => '[]'],
        ];
        return $dfltArray[$fldType];
    }

    private function getFieldCompletionType($details)
    {
        $inputFeatures = ['display' => '***', 'ftrs' => ['title' => 'Mandatory', 'class' => 'inputMandatory']];
        if ($details['IS_NULLABLE'] == 'YES') {
            $inputFeatures = ['display' => '~', 'ftrs' => ['title' => 'Optional', 'class' => 'inputOptional']];
        }
        return $this->setStringIntoTag($inputFeatures['display'], 'span', $inputFeatures['ftrs']);
    }

    /**
     * Returns the name of a field for displaying
     *
     * @param array $details
     * @return string
     */
    private function getFieldNameForDisplay($details)
    {
        $tableUniqueId = $details['TABLE_SCHEMA'] . '.' . $details['TABLE_NAME'];
        if ($details['COLUMN_COMMENT'] != '') {
            return $details['COLUMN_COMMENT'];
        } elseif (isset($this->advCache['tableStructureLocales'][$tableUniqueId][$details['COLUMN_NAME']])) {
            return $this->advCache['tableStructureLocales'][$tableUniqueId][$details['COLUMN_NAME']];
        }
        return $details['COLUMN_NAME'];
    }

    /**
     * Returns a Enum or Set field to use in form
     *
     * @param string $tblSrc
     * @param string $fldType
     * @param array $val
     * @param string $iar
     * @return string
     */
    private function getFieldOutputEnumSet($tblSrc, $fldType, $val, $iar = null)
    {
        $adnlThings = $this->establishDefaultEnumSet($fldType);
        if (isset($iar['readonly'])) {
            return $this->getFieldOutputEnumSetReadOnly($tblSrc, $fldType, $val, $iar, $adnlThings);
        }
        $inAdtnl = $adnlThings['additional'];
        if (!is_null($iar)) {
            $inAdtnl = array_merge($inAdtnl, $iar);
        }
        $vlSlct    = explode(',', $this->getFieldValue($val));
        $slctOptns = $this->getSetOrEnum2Array($tblSrc, $val['COLUMN_NAME']);
        return $this->setArrayToSelect($slctOptns, $vlSlct, $val['COLUMN_NAME'] . $adnlThings['suffix'], $inAdtnl);
    }

    private function getFieldOutputEnumSetReadOnly($tblSrc, $fldType, $val, $iar, $adnlThings)

    {
        $inputFeatures = [
            'name'     => $val['COLUMN_NAME'] . $adnlThings['suffix'],
            'id'       => $val['COLUMN_NAME'],
            'readonly' => 'readonly',
            'class'    => 'input_readonly',
            'size'     => 50,
            'value'    => $this->getFieldValue($val),
        ];
        return $this->setStringIntoShortTag('input', $inputFeatures);
    }

    /**
     * Returns a Numeric field 2 use in a form
     *
     * @param string $tblSrc
     * @param array $value
     * @param array $features
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $iar
     * @return string
     */
    private function getFieldOutputNumeric($tblSrc, $value, $iar = null)
    {
        $input = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($value['EXTRA'] == 'auto_increment') {
            if ($this->getFieldValue($value) == '') {
                $input = $this->setStringIntoTag('auto-numar', 'span', [
                    'id'    => $value['COLUMN_NAME'],
                    'style' => 'font-style:italic;',
                ]);
            } else {
                $inAdtnl = [
                    'type'  => 'hidden',
                    'name'  => $value['COLUMN_NAME'],
                    'id'    => $value['COLUMN_NAME'],
                    'value' => $this->getFieldValue($value),
                ];
                if (!is_null($iar)) {
                    $inAdtnl = array_merge($inAdtnl, $iar);
                }
                $input = $this->setStringIntoTag($this->getFieldValue($value), 'b')
                        . $this->setStringIntoShortTag('input', $inAdtnl);
            }
        } else {
            $database = $this->advCache['workingDatabase'];
            $fkArray  = $this->getForeignKeysToArray($database, $tblSrc, $value['COLUMN_NAME']);
            if (is_null($fkArray)) {
                $fldNos  = $this->setFieldNumbers($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $inAdtnl = [
                    'type'      => 'text',
                    'name'      => $value['COLUMN_NAME'],
                    'id'        => $value['COLUMN_NAME'],
                    'value'     => $this->getFieldValue($value),
                    'size'      => min(50, $fldNos['l']),
                    'maxlength' => min(50, $fldNos['l'])
                ];
                if (isset($iar)) {
                    $inAdtnl = array_merge($inAdtnl, $iar);
                }
                $input = $this->setStringIntoShortTag('input', $inAdtnl);
            } else {
                $query         = $this->sQueryGenericSelectKeyValue([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                    $fkArray[$value['COLUMN_NAME']][1],
                    $fkArray[$value['COLUMN_NAME']][2],
                    $fkArray[$value['COLUMN_NAME']][0]
                ]);
                $selectOptions = $this->setMySQLquery2Server($query, 'array_key_value')['result'];
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $selectValue   = $this->getFieldValue($value);
                $inAdtnl       = ['size' => 1];
                if ($value['IS_NULLABLE'] == 'YES') {
                    $inAdtnl = array_merge($inAdtnl, ['include_null']);
                }
                if (isset($iar)) {
                    $inAdtnl = array_merge($inAdtnl, $iar);
                }
                $input = $this->setArrayToSelect($selectOptions, $selectValue, $value['COLUMN_NAME'], $inAdtnl);
            }
        }
        return $input;
    }

    /**
     * Returns a Char field 2 use in a form
     *
     * @param string $tbl
     * @param string $fieldType
     * @param array $value
     * @param array $features
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $iar
     * @return string
     */
    private function getFieldOutputText($tbl, $fieldType, $value, $iar = null)
    {
        if (!in_array($fieldType, ['char', 'tinytext', 'varchar'])) {
            return '';
        }
        $input    = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $database = $this->advCache['workingDatabase'];
        if (strpos($tbl, '`.`')) {
            $database = substr($tbl, 0, strpos($tbl, '`.`'));
        }
        if (($tbl != 'user_rights') && ($value['COLUMN_NAME'] != 'eid')) {
            $foreignKeysArray = $this->getForeignKeysToArray($database, $tbl, $value['COLUMN_NAME']);
            if (is_null($foreignKeysArray)) {
                unset($foreignKeysArray);
            }
        }
        if (isset($foreignKeysArray)) {
            $query   = $this->storedQuery('generic_select_key_value', [
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $foreignKeysArray[$value['COLUMN_NAME']][1],
                $foreignKeysArray[$value['COLUMN_NAME']][2],
                $foreignKeysArray[$value['COLUMN_NAME']][0]
            ]);
            $inAdtnl = ['size' => 1];
            if ($value['IS_NULLABLE'] == 'YES') {
                $inAdtnl = array_merge($inAdtnl, ['include_null']);
            }
            if (!is_null($iar)) {
                $inAdtnl = array_merge($inAdtnl, $iar);
            }
            $slct  = [
                'Options' => $this->setQuery2Server($query, 'array_key_value'),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                'Value'   => $this->getFieldValue($value),
            ];
            $input = $this->setArrayToSelect($slct['Options'], $slct['Value'], $value['COLUMN_NAME'], $inAdtnl);
            unset($foreignKeysArray);
        } else {
            $fldNos  = $this->setFieldNumbers($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $inAdtnl = [
                'type'      => ($value['COLUMN_NAME'] == 'password' ? 'password' : 'text'),
                'name'      => $value['COLUMN_NAME'],
                'id'        => $value['COLUMN_NAME'],
                'size'      => min(30, $fldNos['l']),
                'maxlength' => min(255, $fldNos['l']),
                'value'     => $this->getFieldValue($value),
            ];
            if (!is_null($iar)) {
                $inAdtnl = array_merge($inAdtnl, $iar);
            }
            $input = $this->setStringIntoShortTag('input', $inAdtnl);
        }
        return $input;
    }

    /**
     * Returns a Text field 2 use in a form
     *
     * @param string $table_source
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $fieldType
     * @param array $value
     * @param array $features
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $iar
     * @return string
     */
    private function getFieldOutputTextLarge($fieldType, $value, $iar = null)
    {
        if (!in_array($fieldType, ['blob', 'text'])) {
            $sReturn = '';
        } else {
            $inAdtnl = [
                'name' => $value['COLUMN_NAME'],
                'id'   => $value['COLUMN_NAME'],
                'rows' => 4,
                'cols' => 55,
            ];
            if (isset($iar)) {
                $inAdtnl = array_merge($inAdtnl, $iar);
            }
            $sReturn = $this->setStringIntoTag($this->getFieldValue($value), 'textarea', $inAdtnl);
        }
        return $sReturn;
    }

    /**
     * Returns a Time field 2 use in a form
     *
     * @param string $table_source
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $fieldType
     * @param array $value
     * @param array $features
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $iar
     * @return string
     */
    private function getFieldOutputTime($fieldType, $value, $iar = null)
    {
        $input = null;
        switch ($fieldType) {
            case 'time':
                $inAdtnl = [
                    'type'      => 'text',
                    'size'      => 9,
                    'maxlength' => 9,
                    'name'      => $value['COLUMN_NAME'],
                    'id'        => $value['COLUMN_NAME'],
                    'value'     => $this->getFieldValue($value),
                ];
                if (isset($iar)) {
                    $inAdtnl = array_merge($inAdtnl, $iar);
                }
                $input = $this->setStringIntoShortTag('input', $inAdtnl);
                break;
        }
        return $input;
    }

    /**
     * Returns a Timestamp field 2 use in a form
     *
     * @param string $table_source
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $fieldType
     * @param array $value
     * @param array $features
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $iar
     * @return string
     */
    private function getFieldOutputTimestamp($fieldType, $value, $iar = null)
    {
        $input = null;
        switch ($fieldType) {
            case 'timestamp':
            // intentioanlly left open
            case 'datetime':
                $inAdtnl = [
                    'type'      => 'text',
                    'size'      => 19,
                    'maxlength' => 19,
                    'name'      => $value['COLUMN_NAME'],
                    'id'        => $value['COLUMN_NAME'],
                    'value'     => $this->getFieldValue($value),
                ];
                if (isset($iar)) {
                    $inAdtnl = array_merge($inAdtnl, $iar);
                }
                $input = $this->setStringIntoShortTag('input', $inAdtnl);
                if (!isset($iar['readonly'])) {
                    $input .= $this->setCalendarControlWithTime($value['COLUMN_NAME']);
                }
                break;
        }
        return $input;
    }

    /**
     * Returns a Year field 2 use in a form
     *
     * @param array $details
     * @param string $iar
     * @return string
     */
    private function getFieldOutputYear($details, $iar)
    {
        for ($c = 1901; $c <= 2155; $c++) {
            $listOfValues[$c] = $c;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        if (is_null($iar)) {
            $slDflt  = $this->getFieldValue($details);
            $sReturn = $this->setArrayToSelect($listOfValues, $slDflt, $details['COLUMN_NAME'], [
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                'size' => 1
            ]);
        } else {
            $sReturn = $this->getFieldOutputText('varchar', $details, $iar);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return $sReturn;
    }

    /**
     * Returns given value for a field from $_REQUEST
     *
     * @param array $details
     * @return string
     */
    private function getFieldValue($details)
    {
        $this->initializeSprGlbAndSession();
        $rqCN = $this->tCmnRequest->request->get($details['COLUMN_NAME']);
        if (!is_null($rqCN)) {

            if (($details['IS_NULLABLE'] == 'YES') && ($rqCN == '')) {
                return 'NULL';
            }
            return $rqCN;
        }
        return $this->getFieldValueWithoutUserInput($details);
    }

    /**
     * Handles field value ignoring any input from the user
     *
     * @param array $details
     * @return string
     */
    private function getFieldValueWithoutUserInput($details)
    {
        if (is_null($details['COLUMN_DEFAULT'])) {

            if ($details['IS_NULLABLE'] == 'YES') {
                return 'NULL';
            }
            return '';
        }
        return $details['COLUMN_DEFAULT'];
    }

    /**
     * Returns an array with fields referenced by a Foreign key
     *
     * @param object $db
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $database
     * @param string $tblName
     * @param string $onlyCols
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return array
     */
    private function getForeignKeysToArray($database, $tblName, $onlyCol = '')
    {
        if (strpos($tblName, '.`')) {
            $tblName = substr($tblName, strpos($tblName, '.`') + 2, 64);
        }
        $this->setTableForeginKeyCache($database, $tblName);
        $array2return = null;
        if (isset($this->advCache['tableFKs'][$database][$tblName])) {
            foreach ($this->advCache['tableFKs'][$database][$tblName] as $value) {
                if ($value['COLUMN_NAME'] == $onlyCol) {
                    $query                  = $this->sQueryMySqlColumns([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                        'TABLE_SCHEMA' => $value['REFERENCED_TABLE_SCHEMA'],
                        'TABLE_NAME'   => $value['REFERENCED_TABLE_NAME'],
                        'DATA_TYPE'    => [
                            'char',
                            'varchar',
                            'text',
                        ],
                    ]);
                    $targetTblTxtFlds       = $this->setMySQLquery2Server($query, 'full_array_key_numbered')['result'];
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                    $significance           = $targetTblTxtFlds[0]['COLUMN_NAME'];
                    unset($targetTblTxtFlds);
                    $array2return[$onlyCol] = [
                        '`' . implode('`.`', [
                            $value['REFERENCED_TABLE_SCHEMA'],
                            $value['REFERENCED_TABLE_NAME'],
                        ]) . '`',
                        $value['REFERENCED_COLUMN_NAME'],
                        '`' . $significance . '`',
                    ];
                }
            }
        }
        return $array2return;
    }

    private function getLabel($details)
    {
        return $this->setStringIntoTag($this->getFieldNameForDisplay($details), 'span', ['class' => 'fake_label']);
    }

    /**
     * Returns an array with possible values of a SET or ENUM column
     *
     * @param string $refTbl
     * @param string $refCol
     * @return array
     */
    protected function getSetOrEnum2Array($refTbl, $refCol)
    {
        if ((strpos($refTbl, '`') !== false) && (substr($refTbl, 0, 1) != '`')) {
            $refTbl = '`' . $refTbl . '`';
        }
        $dat = $this->establishDatabaseAndTable($refTbl);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        foreach ($this->advCache['tableStructureCache'][$dat[0]][$dat[1]] as $value) {
            if ($value['COLUMN_NAME'] == $refCol) {
                $clndVls = explode(',', str_replace([$value['DATA_TYPE'], '(', "'", ')'], '', $value['COLUMN_TYPE']));
                $enmVls  = array_combine($clndVls, $clndVls);
                if ($value['IS_NULLABLE'] == 'YES') {
                    $enmVls['NULL'] = '';
                }
            }
        }
        ksort($enmVls);
        return $enmVls;
    }

    /**
     * Returns a timestamp field value
     *
     * @param $details
     * @return unknown_type
     */
    private function getTimestamping($details)
    {
        $label = $this->getLabel($details);
        if (in_array($this->getFieldValue($details), ['', 'CURRENT_TIMESTAMP', 'NULL'])) {
            switch ($details['COLUMN_NAME']) {
                case 'InsertDateTime':
                    $input = $this->setStringIntoTag('data/timpul ad. informatiei', 'span', [
                        'style' => 'font-style:italic;'
                    ]);
                    break;
                case 'modification_datetime':
                case 'ModificationDateTime':
                    $input = $this->setStringIntoTag('data/timpul modificarii inf.', 'span', [
                        'style' => 'font-style:italic;'
                    ]);
                    break;
            }
        } else {
            $input = $this->setStringIntoTag($this->getFieldValue($details), 'span');
        }
        return ['label' => $label, 'input' => $input];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * Manages features flag
     *
     * @param string $fieldName
     * @param array $features
     * @return string
     */
    private function handleFeatures($fieldName, $features)
    {
        $iar = null;
        if (isset($features['readonly']) && in_array($fieldName, $features['readonly'])) {
            $iar = ['readonly' => 'readonly', 'class' => 'input_readonly'];
        }
        if (isset($features['disabled']) && in_array($fieldName, $features['disabled'])) {

            $iar = ['disabled' => 'disabled'];
        }
        if (isset($features['include_null']) && in_array($fieldName, $features['include_null'])) {

            $iar = ['include_null'];
        }
        return $iar;
    }

    private function handleFeaturesSingle($fieldName, $features)

    {

    }

    /**
     * Returns a generic form based on a given table
     *
     * @param string $tblSrc Table Source
     * @param array $feat
     * @param string/array $hiddenInfo List of hidden fields

     *
     * @return string Form to add/modify detail for a single row within a table
     */
    protected function setFormGenericSingleRecord($tblSrc, $feat, $hiddenInfo = '')
    {
        echo $this->setStringIntoTag('', 'div', [
            'id' => 'loading'
        ]); // Ajax container
        if (strpos($tblSrc, '.') !== false) {
            $tblSrc = explode('.', str_replace('`', '', $tblSrc))[1];
        }
        $this->setTableCache($tblSrc); // will populate $this->advCache['tableStructureCache'][$dt[0]][$dt[1]]

        if (count($this->advCache['tableStructureCache'][$this->advCache['workingDatabase']][$tblSrc]) != 0) {
            foreach ($this->advCache['tableStructureCache'][$this->advCache['workingDatabase']][$tblSrc] as $value) {
                $sReturn[] = $this->setNeededField($tblSrc, $value, $feat);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }
        $btn[]                = $this->setStringIntoShortTag('input', [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'type'  => 'submit',
            'id'    => 'submit',
            'style' => 'margin-left:220px;',
            'value' => $this->lclMsgCmn('i18n_Form_ButtonSave'),
        ]);
        $adtnlScriptAfterForm = $this->setJavascriptContent(implode('', [
            '$(document).ready(function(){',
            '$("form#' . $feat['id'] . '").submit(function(){',
            '$("input").attr("readonly", true);',
            '$("input[type=submit]").attr("disabled", "disabled");',
            '$("input[type=submit]").attr("value", "' . $this->lclMsgCmn('i18n_Form_ButtonSaving') . '");',
            '});',
            '});',
        ]));
        if (isset($feat['insertAndUpdate'])) {
            $btn[] = $this->setStringIntoShortTag('input', [
                'type'  => 'hidden',
                'id'    => 'insertAndUpdate',
                'name'  => 'insertAndUpdate',
                'value' => 'insertAndUpdate'
            ]);
        }
        $sReturn[] = $this->setStringIntoTag(implode('', $btn), 'div');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        if (isset($hiddenInfo)) {
            if (is_array($hiddenInfo)) {
                foreach ($hiddenInfo as $key => $value) {
                    $hiddenInput = $this->setStringIntoShortTag('input', [
                        'type'  => 'hidden',
                        'name'  => $key,
                        'id'    => $key,
                        'value' => $value,
                    ]);
                    $sReturn[]   = $this->setStringIntoTag($hiddenInput, 'div');
                }
            }
        }
        return $this->setStringIntoTag(implode('', $sReturn), 'form', [
                    'id'     => $feat['id'],
                    'action' => $feat['action'],
                    'method' => $feat['method']
                ])
                . $adtnlScriptAfterForm;
    }

    protected function setTableLocaleFields($localizationStrings)
    {
        $this->advCache['tableStructureLocales'] = $localizationStrings;
    }

    /**
     * Analyse the field and returns the proper line 2 use in forms
     *
     * @param string $tableSource
     * @param array $details
     * @param array $features
     * @return string|array
     */
    private function setNeededField($tableSource, $details, $features)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($features['hidden'])) {
            if (in_array($details['COLUMN_NAME'], $features['hidden'])) {
                return null;
            }
        }
        $fieldLabel = $this->getFieldNameForDisplay($details);
        if ($fieldLabel == 'hidden') {
            return null;
        }
        switch ($details['COLUMN_NAME']) {
            case 'host':
                $sReturn['label'] = $this->setStringIntoTag('Numele calculatorului', 'label', [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    'for' => $details['COLUMN_NAME']
                ]);
                $sReturn['input'] = $this->setStringIntoShortTag('input', [
                    'type'     => 'input',
                    'size'     => 15,
                    'readonly' => 'readonly',
                    'value'    => gethostbyaddr($_SERVER['REMOTE_ADDR'])
                ]);
                break;
            case 'InsertDateTime':
            case 'modification_datetime':
            case 'ModificationDateTime':
                $sReturn          = call_user_func_array([$this, 'getTimestamping'], [$details]);
                break;
            default:
                $aLabel           = [
                    'for' => $details['COLUMN_NAME'],
                    'id'  => $details['COLUMN_NAME'] . '_label'
                ];
                if (isset($features['disabled'])) {
                    if (in_array($details['COLUMN_NAME'], $features['disabled'])) {
                        $aLabel = array_merge($aLabel, ['style' => 'color: grey;']);
                    }
                }
                $sReturn['label'] = $this->setStringIntoTag($fieldLabel, 'label', $aLabel);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                if ($details['COLUMN_NAME'] == 'ChoiceId') {
                    $result = $this->setStringIntoShortTag('input', [
                        'type'  => 'text',
                        'name'  => $details['COLUMN_NAME'],
                        'value' => $_REQUEST[$details['COLUMN_NAME']]
                    ]);
                } else {
                    $result = $this->setNeededFieldByType($tableSource, $details, $features);
                }
                $sReturn['input'] = $result;
                break;
        }
        $finalReturn[] = $sReturn['label'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $finalReturn[] = $this->setStringIntoTag($sReturn['input'], 'span', ['class' => 'labell']);
        $wrkDb         = $this->advCache['workingDatabase'];
        if (isset($this->tableFKsCache[$wrkDb][$tableSource])) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if (in_array($details['COLUMN_NAME'], $this->advCache['FKcol'][$wrkDb][$tableSource])) {
                $finalReturn[] = $this->getFieldLength($details);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
        return $this->setStringIntoTag(implode('', $finalReturn), 'div');
    }

    /**
     * Analyse the field type and returns the proper lines 2 use in forms
     *
     * @param string $tbl_src
     * @param array $details
     * @param array $features
     * @return string/array

     */
    private function setNeededFieldByType($tbl_src, $details, $features)
    {
        $sReturn = null;
        if (isset($features['special']) && isset($features['special'][$details['COLUMN_NAME']])) {
            $slctOpt = $this->setQuery2Server($features['special'][$details['COLUMN_NAME']], 'array_key_value');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $sReturn = $this->setArrayToSelect($slctOpt, $this->getFieldValue($details), $details['COLUMN_NAME'], [
                'size' => 1
            ]);
        } else {
            $iar = $this->handleFeatures($details['COLUMN_NAME'], $features);
            switch ($details['DATA_TYPE']) {
                case 'bigint':
                case 'int':
                case 'mediumint':
                case 'smallint':
                case 'tinyint':
                case 'float':
                case 'double':
                case 'decimal':
                case 'numeric':
                    $sReturn = $this->getFieldOutputNumeric($tbl_src, $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'char':
                case 'tinytext':
                case 'varchar':
                    $sReturn = $this->getFieldOutputText($tbl_src, $details['DATA_TYPE'], $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'date':
                    $sReturn = $this->getFieldOutputDate($details['DATA_TYPE'], $details, $iar);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                    break;
                case 'datetime':
                case 'timestamp':
                    $sReturn = $this->getFieldOutputTimestamp($details['DATA_TYPE'], $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'enum':
                case 'set':
                    $sReturn = $this->getFieldOutputEnumSet($tbl_src, $details['DATA_TYPE'], $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'text':
                case 'blob':
                    $sReturn = $this->getFieldOutputTextLarge($details['DATA_TYPE'], $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'time':
                    $sReturn = $this->getFieldOutputTime($details['DATA_TYPE'], $details, $iar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    break;
                case 'year':
                    $sReturn = $this->getFieldOutputYear($details, $iar);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    break;
            }
        }
        return $this->getFieldCompletionType($details) . $sReturn;
    }

    /**
     * create a Cache for given table to use it in many places
     *
     * @param type $tblSrc
     */
    private function setTableCache($tblSrc)
    {
        $dat = $this->establishDatabaseAndTable($tblSrc);
        if (!isset($this->advCache['tableStructureCache'][$dat[0]][$dat[1]])) {
            switch ($dat[1]) {
                case 'user_rights':
                    $this->advCache['workingDatabase'] = 'usefull_security';
                    break;
                default:
                    $this->advCache['workingDatabase'] = $dat[0];
                    break;
            }
            $this->advCache['tableStructureCache'][$dat[0]][$dat[1]] = $this->getMySQLlistColumns([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                'TABLE_SCHEMA' => $dat[0],
                'TABLE_NAME'   => $dat[1],
            ]);
            $this->setTableForeginKeyCache($dat[0], $dat[1]);
        }
    }

    private function setTableForeginKeyCache($dbName, $tblName)
    {
        $frgnKs = $this->getMySQLlistIndexes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'TABLE_SCHEMA'          => $dbName,
            'TABLE_NAME'            => $tblName,
            'REFERENCED_TABLE_NAME' => 'NOT NULL',
        ]);
        if (!is_null($frgnKs)) {
            $this->advCache['tableFKs'][$dbName][$tblName] = $frgnKs;
            $this->advCache['FKcol'][$dbName][$tblName]    = array_column($frgnKs, 'COLUMN_NAME', 'CONSTRAINT_NAME');
        }
    }

    /**
     * Automatic handler for Record deletion
     *
     * @param string $tbl
     * @param string $identifier
     * @return string
     */
    protected function setViewModernDelete($tbl, $identifier)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $sReturn = [];
        $tMsg    = [
            'Confirmation' => $this->lclMsgCmn('i18n_Action_Confirmation'),
            'Failed'       => $this->lclMsgCmn('i18n_ActionDelete_Failed'),
            'Impossible'   => $this->lclMsgCmn('i18n_ActionDelete_Impossible'),
            'Success'      => $this->lclMsgCmn('i18n_ActionDelete_Success'),
        ];
        if ($tbl == '') {
            $sReturn[] = $this->setFeedbackModern('error', $tMsg['Confirmation'], $tMsg['Impossible']);
        } else {
            $query = $this->sQueryToDeleteSingleIdentifier([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $tbl,
                $identifier,
                $_REQUEST[$identifier]
            ]);
            $this->setMySQLquery2Server($query);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            if ($this->mySQLconnection->affected_rows != 0) {
                $sReturn[] = $this->setFeedbackModern('check', $tMsg['Confirmation'], $tMsg['Success']);
            } else {
                $sReturn[] = $this->setFeedbackModern('error', $tMsg['Confirmation'], $tMsg['Failed']);
                $sReturn[] = '(' . $this->mySQLconnection->error . ')';
class MyClass { }

$x = new MyClass();
$x->foo = true;
            }
        }
        $finalJavascript = $this->setJavascriptContent(implode('', [
            '$("#DeleteFeedback").fadeOut(4000, function() {',
            '$(this).remove();',
            '});',
        ]));
        return '<div id="DeleteFeedback">' . implode('', $sReturn) . '</div>' . $finalJavascript;
    }
}

Push — master ( e647cd...a0585d )

MySQLiAdvancedOutput::establishDefaultEnumSet() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			*
5			* The MIT License (MIT)
6			*
7			* Copyright (c) 2015 Daniel Popiniuc
8			*
9			* Permission is hereby granted, free of charge, to any person obtaining a copy
10			* of this software and associated documentation files (the "Software"), to deal
11			* in the Software without restriction, including without limitation the rights
12			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
13			* copies of the Software, and to permit persons to whom the Software is
14			* furnished to do so, subject to the following conditions:
15			*
16			* The above copyright notice and this permission notice shall be included in all
17			* copies or substantial portions of the Software.
18			*
19			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
20			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
21			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
22			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
23			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
24			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
25			* SOFTWARE.
26			*
27			*/
28
29			namespace danielgp\common_lib;
30
31			/**
32			* usefull functions to get quick results
33			*
34			* @author Daniel Popiniuc
35			*/
36			trait MySQLiAdvancedOutput
37			{
38
39			use DomComponentsByDanielGP;
40
danielgp / common-lib

Push — master ( e647cd...a0585d )

MySQLiAdvancedOutput::establishDefaultEnumSet() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
