ShortLinkController::resolve()   A
last analyzed

Complexity

Conditions 6
Paths 8

Size

Total Lines 14

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 14
rs 9.2222
c 0
b 0
f 0
cc 6
nc 8
nop 1
1
<?php
2
3
namespace danielebuso\shortener\Controllers;
4
5
use App\Http\Controllers\Controller;
6
use Request;
7
use danielebuso\shortener\Models\ShortLink;
8
9
class ShortLinkController extends Controller
10
{
11
    public function resolve(ShortLink $short_link)
12
    {
13
        // Check if link is expired
14
        if ($short_link->expire_at && $short_link->expire_at->isPast()) abort(401);
0 ignored issues
show
Bug introduced by
The method isPast does only exist in Illuminate\Support\Carbon, but not in DateTime.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
15
16
        // Check if link is not yet available
17
        if ($short_link->not_before && $short_link->not_before->isFuture()) abort(401);
0 ignored issues
show
Bug introduced by
The method isFuture does only exist in Illuminate\Support\Carbon, but not in DateTime.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
18
19
        // Check if link is enabled
20
        if (!$short_link->enabled) abort(401);
21
22
        // Resolve
23
        return response()->redirectTo($short_link->url);
0 ignored issues
show
Bug introduced by
The method redirectTo does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
24
    }
25
}
26