GrammarFactory::make() - Code Metrics - Inspection of "Support laravel 5.x (#4)" - danhunsaker/laravel-spatial - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — v0.1 ( 3df3e6...629e1b )

by Hennik

created 2020-02-05 00:24 UTC

GrammarFactory::make() A

↳ Parent: GrammarFactory

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	9
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	13
rs	9.9666

<?php

namespace LaravelSpatial\Schema\Grammars;

use Illuminate\Database\Schema\Grammars\Grammar;

/**
 * Class GrammarFactory
 *
 * @package LaravelSpatial\Schema\Grammars
 * @internal
 */
class GrammarFactory
{

    /**
     * @param string $name
     *
     * @return \Illuminate\Database\Schema\Grammars\Grammar
     */
    public static function make(string $name): Grammar
    {
        switch ($name) {
            case 'mysql':
                return new MySqlGrammar();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'postgresql':
            case 'pg_sql':
                return new PostgresGrammar();
                break;
        }

        throw new \InvalidArgumentException(\sprintf('%s is not a supported grammar.', $name));
    }
}


1			<?php
2
3			namespace LaravelSpatial\Schema\Grammars;
4
5			use Illuminate\Database\Schema\Grammars\Grammar;
6
7			/**
8			* Class GrammarFactory
9			*
10			* @package LaravelSpatial\Schema\Grammars
11			* @internal
12			*/
13			class GrammarFactory
14			{
15
16			/**
17			* @param string $name
18			*
19			* @return \Illuminate\Database\Schema\Grammars\Grammar
20			*/
21			public static function make(string $name): Grammar
22			{
23			switch ($name) {
24			case 'mysql':
25			return new MySqlGrammar();
26			break;
			0 ignored issues – show Unused Code introduced 2020-01-28 23:29 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
27			case 'postgresql':
28			case 'pg_sql':
29			return new PostgresGrammar();
30			break;
31			}
32
33			throw new \InvalidArgumentException(\sprintf('%s is not a supported grammar.', $name));
34			}
35			}
36

danhunsaker / laravel-spatial

Push — v0.1 ( 3df3e6...629e1b )

GrammarFactory::make() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like