danbelden /
php-siren
| Total Complexity | 12 |
| Total Lines | 111 |
| Duplicated Lines | 31.53 % |
| Changes | 0 | ||
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class Link |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var array |
||
| 11 | */ |
||
| 12 | protected $rel = array(); |
||
| 13 | |||
| 14 | /** |
||
| 15 | * @var string |
||
| 16 | */ |
||
| 17 | protected $href; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Get rel |
||
| 21 | * |
||
| 22 | * @return array |
||
| 23 | */ |
||
| 24 | public function getRel() |
||
| 27 | } |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Set rel |
||
| 31 | * |
||
| 32 | * @param array $rel |
||
| 33 | * @return $this |
||
| 34 | * @throws LogicException |
||
| 35 | */ |
||
| 36 | View Code Duplication | public function setRel(array $rel) |
|
|
|
|||
| 37 | { |
||
| 38 | foreach ($rel as $relItem) { |
||
| 39 | if (!is_string($relItem)) { |
||
| 40 | $exMsg = sprintf('Provided rel `%s` is not a string', $relItem); |
||
| 41 | throw new LogicException($exMsg); |
||
| 42 | } |
||
| 43 | } |
||
| 44 | |||
| 45 | $this->rel = $rel; |
||
| 46 | |||
| 47 | return $this; |
||
| 48 | } |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Add rel |
||
| 52 | * |
||
| 53 | * @param string $rel |
||
| 54 | * @return $this |
||
| 55 | * @throws LogicException |
||
| 56 | */ |
||
| 57 | View Code Duplication | public function addRel($rel) |
|
| 58 | { |
||
| 59 | if (!is_string($rel)) { |
||
| 60 | $exMsg = sprintf('Provided rel `%s` is not a string', $rel); |
||
| 61 | throw new LogicException($exMsg); |
||
| 62 | } |
||
| 63 | |||
| 64 | $this->rel[] = $rel; |
||
| 65 | |||
| 66 | return $this; |
||
| 67 | } |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Get href |
||
| 71 | * |
||
| 72 | * @return string |
||
| 73 | */ |
||
| 74 | public function getHref() |
||
| 75 | { |
||
| 76 | return $this->href; |
||
| 77 | } |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Set href |
||
| 81 | * |
||
| 82 | * @param string $href |
||
| 83 | * @return $this |
||
| 84 | * @throws LogicException |
||
| 85 | */ |
||
| 86 | View Code Duplication | public function setHref($href) |
|
| 96 | } |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Convert object to array |
||
| 100 | * |
||
| 101 | * @return array |
||
| 102 | */ |
||
| 103 | public function toArray() |
||
| 118 | } |
||
| 119 | } |
||
| 120 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.