IndexController::listFiles() - Code Metrics - Inspection of "fixes for sensiolabs insight, updated service name..." - damianz5/simple_file_server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3db8c2...905420 )

by Damian

created 2017-04-21 14:01 UTC

IndexController::listFiles() A

↳ Parent: IndexController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	1
crap	1

<?php

namespace App\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;

class IndexController extends Controller
{
    use CredentialsCheckTrait;

    /**
     * @Route("/api/list/{name}", requirements={"name" = "^[a-f0-9]{32}$"})
     * @Method({"GET"})
     *
     * @param $name string
     *
     * @return JsonResponse
     */
    public function listAction($name)

    {
        try {
            return $this->listFiles($name);
        } catch (\Exception $e) {
            return new JsonResponse([
                'status'  => 'error',
                'message' => $e->getMessage(),
            ]);
        }
    }

    private function listFiles($name)
    {
        $this->checkCredentials();
        $files = $this->get('app.file_collection_manager')->listFiles($name);

        return new JsonResponse([
            'status'          => 'ok',
            'collection_name' => $name,
            'files'           => $files,
        ]);
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\HttpFoundation\JsonResponse;
9
10			class IndexController extends Controller
11			{
12			use CredentialsCheckTrait;
13
14			/**
15			* @Route("/api/list/{name}", requirements={"name" = "^[a-f0-9]{32}$"})
16			* @Method({"GET"})
17			*
18			* @param $name string
19			*
20			* @return JsonResponse
21			*/
22	4	View Code Duplication	public function listAction($name)
			0 ignored issues – show Duplication introduced 2017-04-21 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23			{
24			try {
25	4		return $this->listFiles($name);
26	2		} catch (\Exception $e) {
27	2		return new JsonResponse([
28	2		'status' => 'error',
29	2		'message' => $e->getMessage(),
30	2		]);
31			}
32			}
33
34	4		private function listFiles($name)
35			{
36	4		$this->checkCredentials();
37	3		$files = $this->get('app.file_collection_manager')->listFiles($name);
38
39	2		return new JsonResponse([
40	2		'status' => 'ok',
41	2		'collection_name' => $name,
42	2		'files' => $files,
43	2		]);
44			}
45			}
46

damianz5 / simple_file_server

GitHub Access Token became invalid

Push — master ( 3db8c2...905420 )

IndexController::listFiles() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like