App\Controller\UploadController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	26.19 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	uploadAction()	11	11	2
A	upload()	0	17	1

<?php

namespace App\Controller;

use App\Model\FileCollection;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;

class UploadController extends Controller
{
    use CredentialsCheckTrait;

    /**
     * @Route("/api/upload/{name}", defaults={"name" = null}, requirements={"name" = "^[a-f0-9]{32}$"})
     * @Method({"POST"})
     *
     * @param string|null $name
     *
     * @return JsonResponse
     */
    public function uploadAction($name = null)

This method seems to be duplicated in your project.

    {
        try {
            return $this->upload($name);
        } catch (\Exception $e) {
            return new JsonResponse([
                'status'  => 'error',
                'message' => $e->getMessage(),
            ]);
        }
    }

    private function upload($name)
    {
        $this->checkCredentials();

        /** @var $fileCollection FileCollection */
        $fileCollection = $this->get('app.file_collection_manager')->getOrCreate($name);

        $newFiles = $this->get('app.upload_manager')->upload(
            $fileCollection
        );

        return new JsonResponse([
            'status'          => 'ok',
            'collection_name' => $fileCollection->getName(),
            'files'           => $newFiles,
        ]);
    }
}