Issues in WithLanguageSettingsModel.php (master) - Issues in master - dameter/survey-abstracts - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

src/WithLanguageSettingsModel.php (1 issue)

Labels

Severity

Major 1

Tõnis Ormisson 1

<?php

namespace dameter\abstracts;

use dameter\abstracts\interfaces\Translatable;
use dameter\abstracts\models\BaseLanguageSetting;
use dameter\abstracts\models\Language;

/**
 * Class WithLanguageSettingsModel
 * @property BaseLanguageSetting[] $languageSettings
 *
 * @package dameter\abstracts
 * @author Tõnis Ormisson <[email protected]>
 */
class WithLanguageSettingsModel extends WithSurveyModel implements Translatable
{

    /** @var string */
    public static $settingsClass;

    /** @var Language */
    public $language;

    /**
     * {@inheritdoc}
     */
    public function init()
    {
        parent::init();
        if (empty($this->language)) {
            $this->language = $this->survey->language;
        }
    }

    /**
     * @return \yii\db\ActiveQuery
     */
    public function getLanguageSettings() {
        return $this->hasMany(self::$settingsClass);
    }

    /**
     * @return \yii\db\ActiveQuery
     * @throws \yii\base\NotSupportedException
     */
    public function getTexts()
    {
        $query = $this->hasMany(static::$settingsClass, ['parent_id' => static::primaryKeySingle()]);
        return $query->andWhere(['language_id' => $this->language->primaryKey])->indexBy(Language::primaryKeySingle());
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

}

1			<?php
2
3			namespace dameter\abstracts;
4
5			use dameter\abstracts\interfaces\Translatable;
6			use dameter\abstracts\models\BaseLanguageSetting;
7			use dameter\abstracts\models\Language;
8
9			/**
10			* Class WithLanguageSettingsModel
11			* @property BaseLanguageSetting[] $languageSettings
12			*
13			* @package dameter\abstracts
14			* @author Tõnis Ormisson <[email protected]>
15			*/
16			class WithLanguageSettingsModel extends WithSurveyModel implements Translatable
17			{
18
19			/** @var string */
20			public static $settingsClass;
21
22			/** @var Language */
23			public $language;
24
25			/**
26			* {@inheritdoc}
27			*/
28			public function init()
29			{
30			parent::init();
31			if (empty($this->language)) {
32			$this->language = $this->survey->language;
33			}
34			}
35
36			/**
37			* @return \yii\db\ActiveQuery
38			*/
39			public function getLanguageSettings() {
40			return $this->hasMany(self::$settingsClass);
41			}
42
43			/**
44			* @return \yii\db\ActiveQuery
45			* @throws \yii\base\NotSupportedException
46			*/
47			public function getTexts()
48			{
49			$query = $this->hasMany(static::$settingsClass, ['parent_id' => static::primaryKeySingle()]);
50			return $query->andWhere(['language_id' => $this->language->primaryKey])->indexBy(Language::primaryKeySingle());
			0 ignored issues – show Bug Best Practice introduced 2018-07-31 20:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $query->andWhere(...ge::primaryKeySingle())` returns the type `yii\db\ActiveQuery` which is incompatible with the return type mandated by `dameter\abstracts\interf...ranslatable::getTexts()` of `dameter\abstracts\models\BaseLanguageSetting[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
51			}
52
53			}

dameter / survey-abstracts

Issues (6)

src/WithLanguageSettingsModel.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like