DActiveRecord::primaryKey() - Code Metrics - Inspection of "DEV: clean pk from rules" - dameter/survey-abstracts - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5b8bc2...b011b0 )

by Tõnis

created 2018-05-20 08:59 UTC

DActiveRecord::primaryKey() A

↳ Parent: DActiveRecord

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace dameter\abstracts;


use yii\db\ActiveRecord;

class DActiveRecord extends ActiveRecord
{
    /** in case we would need to customize stuff */

    /**
     * @return string
     */
    public static function primaryKey()
    {
        return static::tableName() . "_id";
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /** {@inheritdoc} */
    public function hasMany($class, $link = null)
    {
        if (empty($link)) {
            /** @var DActiveRecord $class */
            $link = [$class::primaryKey() => $class::primaryKey()];
        }
        return parent::hasMany($class, $link);
    }

    /** {@inheritdoc} */
    public function hasOne($class, $link = null)
    {
        if (empty($link)) {
            /** @var DActiveRecord $class */
            $link = [$class::primaryKey() => $class::primaryKey()];
        }
        return parent::hasOne($class, $link);
    }
}

1			<?php
2
3			namespace dameter\abstracts;
4
5
6			use yii\db\ActiveRecord;
7
8			class DActiveRecord extends ActiveRecord
9			{
10			/** in case we would need to customize stuff */
11
12			/**
13			* @return string
14			*/
15			public static function primaryKey()
16			{
17			return static::tableName() . "_id";
			0 ignored issues – show Bug Best Practice introduced 2018-05-20 09:01 UTC by Report Bug Copy Issue Report The expression `return static::tableName() . '_id'` returns the type `string` which is incompatible with the return type mandated by `yii\db\ActiveRecordInterface::primaryKey()` of `string[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
18			}
19
20
21			/** {@inheritdoc} */
22			public function hasMany($class, $link = null)
23			{
24			if (empty($link)) {
25			/** @var DActiveRecord $class */
26			$link = [$class::primaryKey() => $class::primaryKey()];
27			}
28			return parent::hasMany($class, $link);
29			}
30
31			/** {@inheritdoc} */
32			public function hasOne($class, $link = null)
33			{
34			if (empty($link)) {
35			/** @var DActiveRecord $class */
36			$link = [$class::primaryKey() => $class::primaryKey()];
37			}
38			return parent::hasOne($class, $link);
39			}
40			}

dameter / survey-abstracts

Push — master ( 5b8bc2...b011b0 )

DActiveRecord::primaryKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like