BookFixtures::load() - Code Metrics - Inspection of "Fix sample app." - damax-solutions/common - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 75052b...8ecf83 )

by Dmitri

created 2019-02-17 21:58 UTC

BookFixtures::load() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	116
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	55
nc	2
nop	1
dl	0
loc	116
rs	8.9818
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace App\Doctrine\DataFixtures;

use App\Domain\Model\Author;
use App\Domain\Model\Book;
use App\Domain\Model\IdGenerator;
use Doctrine\Bundle\FixturesBundle\Fixture;
use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;

final class BookFixtures extends Fixture implements OrderedFixtureInterface
{
    private $idGenerator;

    public function __construct(IdGenerator $idGenerator)
    {
        $this->idGenerator = $idGenerator;
    }

    public function getOrder(): int
    {
        return 200;
    }

    public function load(ObjectManager $manager): void
    {
        $data = [
            // Author 1
            [
                'title' => 'Antony and Cleopatra',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Coriolanus',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Hamlet',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Julius Caesar',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'King Lear',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Macbeth',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Othello',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'The Tragedy of Romeo and Juliet',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Timon of Athens',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Titus Andronicus',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Troilus and Cressida',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'All\'s Well That Ends Well',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'As You Like It',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'The Comedy of Errors',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Cymbeline',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Love\'s Labour\'s Lost',
                'author' => 'shakespeare',
            ],
            [
                'title' => 'Measure for Measure',
                'author' => 'shakespeare',
            ],

            // Author 2
            [
                'title' => 'The Mysterious Affair at Styles',
                'author' => 'christie',
            ],
            [
                'title' => 'The Secret Adversary',
                'author' => 'christie',
            ],
            [
                'title' => 'The Murder on the Links',
                'author' => 'christie',
            ],
            [
                'title' => 'The Man in the Brown Suit',
                'author' => 'christie',
            ],
            [
                'title' => 'The Secret of Chimneys',
                'author' => 'christie',
            ],
            [
                'title' => 'The Murder of Roger Ackroyd',
                'author' => 'christie',
            ],
            [
                'title' => 'The Big Four',
                'author' => 'christie',
            ],
            [
                'title' => 'The Mystery of the Blue Train',
                'author' => 'christie',
            ],
        ];

        foreach ($data as $item) {
            /** @var Author $author */
            $author = $this->getReference('author-' . $item['author']);

            $manager->persist(new Book($this->idGenerator->bookId(), $author->id(), $item['title']));
        }

        $manager->flush();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Doctrine\DataFixtures;
6
7			use App\Domain\Model\Author;
8			use App\Domain\Model\Book;
9			use App\Domain\Model\IdGenerator;
10			use Doctrine\Bundle\FixturesBundle\Fixture;
11			use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
12			use Doctrine\Common\Persistence\ObjectManager;
13
14			final class BookFixtures extends Fixture implements OrderedFixtureInterface
15			{
16			private $idGenerator;
17
18			public function __construct(IdGenerator $idGenerator)
19			{
20			$this->idGenerator = $idGenerator;
21			}
22
23			public function getOrder(): int
24			{
25			return 200;
26			}
27
28			public function load(ObjectManager $manager): void
29			{
30			$data = [
31			// Author 1
32			[
33			'title' => 'Antony and Cleopatra',
34			'author' => 'shakespeare',
35			],
36			[
37			'title' => 'Coriolanus',
38			'author' => 'shakespeare',
39			],
40			[
41			'title' => 'Hamlet',
42			'author' => 'shakespeare',
43			],
44			[
45			'title' => 'Julius Caesar',
46			'author' => 'shakespeare',
47			],
48			[
49			'title' => 'King Lear',
50			'author' => 'shakespeare',
51			],
52			[
53			'title' => 'Macbeth',
54			'author' => 'shakespeare',
55			],
56			[
57			'title' => 'Othello',
58			'author' => 'shakespeare',
59			],
60			[
61			'title' => 'The Tragedy of Romeo and Juliet',
62			'author' => 'shakespeare',
63			],
64			[
65			'title' => 'Timon of Athens',
66			'author' => 'shakespeare',
67			],
68			[
69			'title' => 'Titus Andronicus',
70			'author' => 'shakespeare',
71			],
72			[
73			'title' => 'Troilus and Cressida',
74			'author' => 'shakespeare',
75			],
76			[
77			'title' => 'All\'s Well That Ends Well',
78			'author' => 'shakespeare',
79			],
80			[
81			'title' => 'As You Like It',
82			'author' => 'shakespeare',
83			],
84			[
85			'title' => 'The Comedy of Errors',
86			'author' => 'shakespeare',
87			],
88			[
89			'title' => 'Cymbeline',
90			'author' => 'shakespeare',
91			],
92			[
93			'title' => 'Love\'s Labour\'s Lost',
94			'author' => 'shakespeare',
95			],
96			[
97			'title' => 'Measure for Measure',
98			'author' => 'shakespeare',
99			],
100
101			// Author 2
102			[
103			'title' => 'The Mysterious Affair at Styles',
104			'author' => 'christie',
105			],
106			[
107			'title' => 'The Secret Adversary',
108			'author' => 'christie',
109			],
110			[
111			'title' => 'The Murder on the Links',
112			'author' => 'christie',
113			],
114			[
115			'title' => 'The Man in the Brown Suit',
116			'author' => 'christie',
117			],
118			[
119			'title' => 'The Secret of Chimneys',
120			'author' => 'christie',
121			],
122			[
123			'title' => 'The Murder of Roger Ackroyd',
124			'author' => 'christie',
125			],
126			[
127			'title' => 'The Big Four',
128			'author' => 'christie',
129			],
130			[
131			'title' => 'The Mystery of the Blue Train',
132			'author' => 'christie',
133			],
134			];
135
136			foreach ($data as $item) {
137			/** @var Author $author */
138			$author = $this->getReference('author-' . $item['author']);
139
140			$manager->persist(new Book($this->idGenerator->bookId(), $author->id(), $item['title']));
141			}
142
143			$manager->flush();
144			}
145			}
146

damax-solutions / common

Push — master ( 75052b...8ecf83 )

BookFixtures::load() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like