NodeKey::isAwaitingChild() - Code Metrics - Inspection of "after conversin to class for each nodes: ALL TESTS..." - dallgoot/yaml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 844759...f0c5ab )

by stéphane

created 2019-02-28 00:26 UTC

NodeKey::isAwaitingChild() B

↳ Parent: NodeKey

Complexity

Conditions	10
Paths	15

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	25
rs	7.6666
c	0
b	0
f	0
cc	10
nc	15
nop	1

How to fix Complexity

<?php

namespace Dallgoot\Yaml;

/**
 *
 * @author  Stéphane Rebai <[email protected]>
 * @license Apache 2.0
 * @link    TODO : url to specific online doc
 */
class NodeKey extends Node
{
    const ERROR_NO_KEYNAME = self::class.": key has NO IDENTIFIER on line %d";

    public function __construct(string $nodeString, int $line, array $matches)
    {
        parent::__construct($nodeString, $line);
        $this->setIdentifier(trim($matches[1], '"\' '));
        $value = isset($matches[2]) ? trim($matches[2]) : null;
        if (!empty($value)) {
            $child = NodeFactory::get($value, $line);
            $child->indent = null;
            $this->add($child);
        }
    }

    public function setIdentifier(string $keyString)
    {
        if ($keyString === '') {
           throw new \ParseError(sprintf(self::ERROR_NO_KEYNAME, $this->line));
        } else {
            $keyNode = NodeFactory::get($keyString);
            if (!is_null($keyNode->_anchor)) {
                $this->_anchor = $keyNode->_anchor;
                $this->identifier = trim($keyNode->value->raw);

            } elseif (!is_null($keyNode->_tag)) {
                $this->_tag = $keyNode->_tag;
                $this->identifier = trim($keyNode->value->raw);
            } elseif ($keyNode instanceof NodeScalar) {
                $this->identifier = trim($keyNode->raw);
            }
        }
    }

    public function add(Node $child):Node
    {
        if ($this->value instanceof Node && isOneOf($this->value, ['NodeLit','NodeLitFolded', 'NodeAnchor'])) {
            return $this->value->add($child);
        } else {
            return parent::add($child);
        }
    }

    public function getTargetOnEqualIndent(Node &$node):Node
    {
        if ($node instanceof NodeItem) {
            return $this;
        }
        return $this->getParent();
    }

    public function getTargetOnMoreIndent(Node &$node):Node
    {
        if (!is_null($this->value)) {
            if ($this->getDeepestNode()->isAwaitingChild($node)) {
                return $this->getDeepestNode();
            }
        }
        return $this;
    }


    public function isAwaitingChild(Node $node):bool
    {
        if (is_null($this->value) || $node instanceof NodeComment) {
            return true;
        }
        $current = $this->value instanceof Node ? $this->value : $this->value->current();
        if ($current instanceof NodeComment) {
            return true;
        }
        if($current instanceof NodeScalar) {
            return isOneOf($node, ['NodeScalar', 'NodeBlank']);
        }
        if ($current instanceof NodeItem) {
            return $node instanceof NodeItem;
        }
        if ($current instanceof NodeKey) {
            return $node instanceof NodeKey;
        }
        if ($current instanceof NodeLiterals) {
            return $node->indent > $this->indent;
        }
        if ($current instanceof NodeAnchor) {
            return $current->isAwaitingChild($node);
        }
        return false;
    }

    /**
     * Builds a key and set the property + value to the given parent
     *
     * @param object|array $parent The parent
     *
     * @throws \ParseError if Key has no name(identifier) Note: empty string is allowed
     * @return null
     */
    public function build(&$parent = null)
    {
        if (!is_null($this->_tag)) {
            return TagFactory::transform($this->_tag, $this)->build($parent);
        }
        $result = is_null($this->value) ? null : $this->value->build();
        if (is_null($parent)) {
            $parent = new \StdClass;
            $parent->{$this->identifier} = $result;
            return $parent;

        } else {
            $parent->{$this->identifier} = $result;
        }
    }
}

1			<?php
2
3			namespace Dallgoot\Yaml;
4
5			/**
6			*
7			* @author Stéphane Rebai <[email protected]>
8			* @license Apache 2.0
9			* @link TODO : url to specific online doc
10			*/
11			class NodeKey extends Node
12			{
13			const ERROR_NO_KEYNAME = self::class.": key has NO IDENTIFIER on line %d";
14
15			public function __construct(string $nodeString, int $line, array $matches)
16			{
17			parent::__construct($nodeString, $line);
18			$this->setIdentifier(trim($matches[1], '"\' '));
19			$value = isset($matches[2]) ? trim($matches[2]) : null;
20			if (!empty($value)) {
21			$child = NodeFactory::get($value, $line);
22			$child->indent = null;
23			$this->add($child);
24			}
25			}
26
27			public function setIdentifier(string $keyString)
28			{
29			if ($keyString === '') {
30			throw new \ParseError(sprintf(self::ERROR_NO_KEYNAME, $this->line));
31			} else {
32			$keyNode = NodeFactory::get($keyString);
33			if (!is_null($keyNode->_anchor)) {
34			$this->_anchor = $keyNode->_anchor;
35			$this->identifier = trim($keyNode->value->raw);
			0 ignored issues – show Bug introduced 2019-02-28 00:34 UTC by Report Bug Copy Issue Report The property `raw` does not seem to exist on `Dallgoot\Yaml\NodeList`. Loading history...
36			} elseif (!is_null($keyNode->_tag)) {
37			$this->_tag = $keyNode->_tag;
38			$this->identifier = trim($keyNode->value->raw);
39			} elseif ($keyNode instanceof NodeScalar) {
40			$this->identifier = trim($keyNode->raw);
41			}
42			}
43			}
44
45			public function add(Node $child):Node
46			{
47			if ($this->value instanceof Node && isOneOf($this->value, ['NodeLit','NodeLitFolded', 'NodeAnchor'])) {
48			return $this->value->add($child);
49			} else {
50			return parent::add($child);
51			}
52			}
53
54			public function getTargetOnEqualIndent(Node &$node):Node
55			{
56			if ($node instanceof NodeItem) {
57			return $this;
58			}
59			return $this->getParent();
60			}
61
62			public function getTargetOnMoreIndent(Node &$node):Node
63			{
64			if (!is_null($this->value)) {
65			if ($this->getDeepestNode()->isAwaitingChild($node)) {
66			return $this->getDeepestNode();
67			}
68			}
69			return $this;
70			}
71
72
73			public function isAwaitingChild(Node $node):bool
74			{
75			if (is_null($this->value) \|\| $node instanceof NodeComment) {
76			return true;
77			}
78			$current = $this->value instanceof Node ? $this->value : $this->value->current();
79			if ($current instanceof NodeComment) {
80			return true;
81			}
82			if($current instanceof NodeScalar) {
83			return isOneOf($node, ['NodeScalar', 'NodeBlank']);
84			}
85			if ($current instanceof NodeItem) {
86			return $node instanceof NodeItem;
87			}
88			if ($current instanceof NodeKey) {
89			return $node instanceof NodeKey;
90			}
91			if ($current instanceof NodeLiterals) {
92			return $node->indent > $this->indent;
93			}
94			if ($current instanceof NodeAnchor) {
95			return $current->isAwaitingChild($node);
96			}
97			return false;
98			}
99
100			/**
101			* Builds a key and set the property + value to the given parent
102			*
103			* @param object\|array $parent The parent
104			*
105			* @throws \ParseError if Key has no name(identifier) Note: empty string is allowed
106			* @return null
107			*/
108			public function build(&$parent = null)
109			{
110			if (!is_null($this->_tag)) {
111			return TagFactory::transform($this->_tag, $this)->build($parent);
112			}
113			$result = is_null($this->value) ? null : $this->value->build();
114			if (is_null($parent)) {
115			$parent = new \StdClass;
116			$parent->{$this->identifier} = $result;
117			return $parent;
			0 ignored issues – show Bug Best Practice introduced 2019-02-28 00:34 UTC by Report Bug Copy Issue Report The expression `return $parent` returns the type `StdClass` which is incompatible with the documented return type `null`. Loading history...
118			} else {
119			$parent->{$this->identifier} = $result;
120			}
121			}
122			}

dallgoot / yaml

Push — master ( 844759...f0c5ab )

NodeKey::isAwaitingChild() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like