school_api.client.api.score

Complexity

Total Complexity

15

Size/Duplication

Total Lines	97
Duplicated Lines	86.6 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	Score.get_score()	26	26	5
A	ScoreParse.handle_data()	6	6	2
A	ScoreParse.get_score()	7	7	3
A	ScoreParse._html_parse_of_score()	33	33	4
A	ScoreParse.__init__()	3	3	1

# -*- coding: utf-8 -*-

This module should have a docstring.

from __future__ import absolute_import, unicode_literals


from bs4 import BeautifulSoup

from requests import RequestException


from school_api.client.api.base import BaseSchoolApi

from school_api.exceptions import ScoreException



class Score(BaseSchoolApi):

This code seems to be duplicated in your project.

The variable __class__ seems to be unused.

    ''' 学生成绩获取 '''


    def get_score(self, score_year=None, score_term=None, **kwargs):

        ''' 成绩信息 获取入口 '''

        score_url = self.school_url['SCORE_URL'] + self.account


        try:

            view_state = self._get_view_state(score_url, **kwargs)

        except RequestException:

            raise ScoreException(self.code, '获取成绩请求参数失败')


        payload = {

            '__VIEWSTATE': view_state,

            'Button2': u'在校学习成绩查询',

            'ddlXN': '',

            'ddlXQ': ''

        }


        try:

            res = self._post(score_url, data=payload, **kwargs)

            if res.status_code == 302:

                raise ScoreException(self.code, '成绩接口已关闭')

            elif res.status_code != 200:

                raise RequestException

        except RequestException:

            raise ScoreException(self.code, '获取成绩信息失败')


        return ScoreParse(res.content).get_score(score_year, score_term)



class ScoreParse():

This code seems to be duplicated in your project.

The variable __class__ seems to be unused.

    ''' 成绩页面解析模块 '''


    def __init__(self, html):

        self.soup = BeautifulSoup(html.decode('GB18030'), "html.parser")

        self._html_parse_of_score()


    def _html_parse_of_score(self):

        rows = self.soup.find("table", {"id": "Datagrid1"}).find_all('tr')

        rows.pop(0)

        self.score_info = {}

        for row in rows:

            cells = row.find_all("td")

            # 学年学期

            year = cells[0].text

            term = cells[1].text

            # 课程名

            lesson_name = cells[3].text.strip()

            credit = cells[6].text.strip() or 0

            point = cells[7].text.strip() or 0

            score = cells[8].text.strip() or 0

            score_dict = {

                "lesson_name": lesson_name,

                "credit": float(credit),

                "point": float(point),

                "score": self.handle_data(score)

            }

            # 有其他成绩内容则输出

            makeup_score = cells[10].text

            retake_score = cells[11].text

            if makeup_score != '\xa0':

                # 补考成绩

                score_dict['bkcj'] = makeup_score

            if retake_score != '\xa0':

                # 重修成绩

                score_dict['cxcj'] = retake_score

            # 组装数组格式的数据备用

            self.score_info[year] = self.score_info.get(year, {})

            self.score_info[year][term] = self.score_info[year].get(term, [])

            self.score_info[year][term].append(score_dict)


    def get_score(self, year, term):

        ''' 返回成绩信息json格式 '''

        if year:

            if term:

                return self.score_info[year][term]

            return self.score_info[year]

        return self.score_info


    @staticmethod

    def handle_data(data):

This method should have a docstring.

        try:

            return float(data)

        except ValueError:

            return data