school_api.client.api.place_schedule

Complexity

Total Complexity

30

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
F	PlaceSchedule.get_schedule()	0	65	14
A	PlaceSchedule._is_skip()	0	3	5
A	PlaceSchedule._get_payload()	0	31	1
A	PlaceSchedule._update_payload()	0	8	2
B	PlaceSchedule._get_api()	0	28	8

# -*- coding: utf-8 -*-

This module should have a docstring.

from __future__ import absolute_import, unicode_literals


import six.moves.urllib.parse as urlparse


from bs4 import BeautifulSoup

from requests import RequestException


from school_api.client.api.base import BaseSchoolApi

from school_api.client.api.utils.schedule_parse import ScheduleParse

from school_api.client.utils import ScheduleType

from school_api.exceptions import ScheduleException



class PlaceSchedule(BaseSchoolApi):

This class should have a docstring.

The variable __class__ seems to be unused.

    schedule_url = None

    payload = None


    def get_schedule(self,

Too many arguments (8/5)

This function exceeds the maximum number of variables (17/15).

                     campus_list=None,

                     building_list=None,

                     classroom_type_list=None,

                     classroom_name_list=None,

                     filter_campus_list=None,

                     filter_building_list=None,

                     filter_classroom_type_list=None,

                     **kwargs):

        ''' 课表信息 获取入口

        返回一个生成器，生成器一旦报错则将退出：https://codeday.me/bug/20180125/124136.html

        除了解析异常其他报错均不抛出

        '''

        self.schedule_url = self.school_url['PLACE_SCHEDULE_URL'] + \

            urlparse.quote(self.account.encode('gb2312'))


        if not self._update_payload(**kwargs):

Too many nested blocks (6/5)

            yield {'error': "获取教学场地课表失败"}

        else:

            # 遍历校区

            for campus in self.payload['campus_list']:

                if self._is_skip(campus["name"], campus_list, filter_name_list=filter_campus_list):

                    continue

                if not self._update_payload(campus, **kwargs):

                    continue


                # 遍历楼号

                for building in self.payload['building_list']:

                    kwargs['building'] = building

                    if self._is_skip(building["name"], building_list, filter_name_list=filter_building_list):

This line is too long as per the coding-style (109/100).

                        continue

                    if not self._update_payload(campus, **kwargs):

                        continue


                    # 遍历教室类别

                    for classroom_type in self.payload['classroom_type_list']:

                        kwargs['classroom_type'] = classroom_type

                        if self._is_skip(classroom_type["name"], classroom_type_list, filter_name_list=filter_classroom_type_list):

This line is too long as per the coding-style (131/100).

                            continue

                        if not self._update_payload(campus, **kwargs):

                            continue

                        # 遍历教室名称

                        for classroom_name in self.payload['classroom_name_list']:

                            kwargs['classroom_name'] = classroom_name

                            if self._is_skip(classroom_name["name"], classroom_name_list):

                                continue

                            try:

                                res = self._get_api(campus, **kwargs)

                            except ScheduleException:

                                continue


                            schedule = ScheduleParse(

                                res.content.decode('GB18030'),

                                self.time_list,

                                ScheduleType.CLASS

                            ).get_schedule_dict()


                            data = {

                                "campus": campus["name"],

                                "building": building["name"],

                                "classroom_type": classroom_type["name"],

                                "classroom_name": classroom_name["name"]

                            }

                            data.update(schedule)

                            yield data


    def _is_skip(self, name, name_list, filter_name_list=None):

This method could be written as a function/class method.

        if (name_list and name not in name_list) or (filter_name_list and name in filter_name_list):

            return True


    def _get_api(self, campus=None, **kwargs):

        """ 请求函数 """

        if self.payload and campus:

            building = kwargs.pop('building', None)

            classroom_type = kwargs.pop('classroom_type', None)

            classroom_name = kwargs.pop('classroom_name', None)

            data = {

                "Button1": "",

                "xq": self.payload['schedule_term'],

                "xn": self.payload['schedule_year'],

                "ddlXq": campus["value"],

                'ddllh': building["value"] if building else '',

                "ddlJslb": classroom_type["value"].encode('gb2312') if classroom_type else '',

                "ddlJsmc": classroom_name["value"].encode('gb2312') if classroom_name else '',

                "__VIEWSTATE": self.payload['view_state'],

            }

            _request = self._post

        else:

            data = ""

            _request = self._get


        try:

            res = _request(self.schedule_url, data=data, **kwargs)

            if res.status_code != 200:

                raise RequestException

        except RequestException:

            raise ScheduleException(self.code, '获取教学场地课表失败')

        return res


    def _update_payload(self, *args, **kwargs):

        # 更新提交参数 payload

        try:

            res = self._get_api(*args, **kwargs)

        except ScheduleException:

            return None

        self.payload = self._get_payload(res.text)

        return True


    @staticmethod

    def _get_payload(html):

This function exceeds the maximum number of variables (16/15).

        pre_soup = BeautifulSoup(html, "html.parser")

        view_state = pre_soup.find(attrs={"name": "__VIEWSTATE"})['value']

        searchbox = pre_soup.find("div", {"class": "searchbox"})


        schedule_year = searchbox.find("select", {"id": "xn"}).find(

            "option", {"selected": "selected"}).text

        schedule_term = searchbox.find("select", {"id": "xq"}).find(

            "option", {"selected": "selected"}).text


        campus = searchbox.find(id='ddlXq').find_all('option')

        buildings = searchbox.find(id='ddllh').find_all('option')

        types = searchbox.find(id='ddlJslb').find_all('option')

        names = searchbox.find(id='ddlJsmc').find_all('option')


        campus_list = [{"name": v.text, "value": v['value']} for v in campus]

        building_list = [{"name": v.text, "value": v['value']} for v in buildings]

        type_list = [{"name": v.text, "value": v['value']} for v in types]

        name_list = [{"name": v.text, "value": v['value']} for v in names]


        payload = {

            'view_state': view_state,

            'schedule_term': schedule_term,

            'schedule_year': schedule_year,

            'campus_list': campus_list,

            'building_list': building_list,

            'classroom_type_list': type_list,

            'classroom_name_list': name_list,

        }

        return payload