Issues in NullValueTest.php (master) - Issues in master - daikon-cqrs/value-object - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

tests/NullValueTest.php (3 issues)

Labels

Bug 3

Severity

Minor 3

<?php declare(strict_types=1);
/**
 * This file is part of the daikon-cqrs/value-object project.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Daikon\Tests\ValueObject;

use Daikon\Interop\InvalidArgumentException;
use Daikon\ValueObject\NullValue;
use PHPUnit\Framework\TestCase;

final class NullValueTest extends TestCase
{
    private NullValue $nullValue;

    public function testToNative(): void
    {
        $this->assertNull($this->nullValue->toNative());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertNull(NullValue::fromNative(null)->toNative());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertNull(NullValue::fromNative('')->toNative());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        $this->expectException(InvalidArgumentException::class);
        NullValue::fromNative('xyz');
    }

    public function testEquals(): void
    {
        $this->assertTrue($this->nullValue->equals(NullValue::fromNative('')));
    }

    public function testToString(): void
    {
        $this->assertEquals('', (string)$this->nullValue);
    }

    protected function setUp(): void
    {
        $this->nullValue = NullValue::makeEmpty();
    }
}


1		<?php declare(strict_types=1);
2		/**
3		* This file is part of the daikon-cqrs/value-object project.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Daikon\Tests\ValueObject;
10
11		use Daikon\Interop\InvalidArgumentException;
12		use Daikon\ValueObject\NullValue;
13		use PHPUnit\Framework\TestCase;
14
15		final class NullValueTest extends TestCase
16		{
17		private NullValue $nullValue;
18
19	1	public function testToNative(): void
20		{
21	1	$this->assertNull($this->nullValue->toNative());
		0 ignored issues – show Bug introduced 2020-06-03 22:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->nullValue->toNative()` targeting `Daikon\ValueObject\NullValue::toNative()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22	1	$this->assertNull(NullValue::fromNative(null)->toNative());
		0 ignored issues – show Bug introduced 2020-06-03 22:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `Daikon\ValueObject\NullV...ative(null)->toNative()` targeting `Daikon\ValueObject\NullValue::toNative()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
23	1	$this->assertNull(NullValue::fromNative('')->toNative());
		0 ignored issues – show Bug introduced 2020-06-03 22:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `Daikon\ValueObject\NullV...mNative('')->toNative()` targeting `Daikon\ValueObject\NullValue::toNative()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
24
25	1	$this->expectException(InvalidArgumentException::class);
26	1	NullValue::fromNative('xyz');
27		}
28
29	1	public function testEquals(): void
30		{
31	1	$this->assertTrue($this->nullValue->equals(NullValue::fromNative('')));
32	1	}
33
34	1	public function testToString(): void
35		{
36	1	$this->assertEquals('', (string)$this->nullValue);
37	1	}
38
39	3	protected function setUp(): void
40		{
41	3	$this->nullValue = NullValue::makeEmpty();
42	3	}
43		}
44

daikon-cqrs / value-object

Issues (13)

tests/NullValueTest.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like