Daikon\MessageBus\FromArrayTrait::fromArray()

Complexity

Conditions	10
Paths	50

Size

Total Lines	45
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
    public static function fromArray(array $arrayState): MessageInterface
    {
        $classReflection = new \ReflectionClass(static::class);
        $classes = [ $classReflection ];
        $parent = $classReflection;
        while ($parent = $parent->getParentClass()) {
            $classes[] = $parent;
        }
        $valueFactories = [];
        foreach ($classes as $curClass) {
            $classProps = $curClass->getProperties();
            foreach ($classProps as $prop) {
                $propName = $prop->getName();
                $docBlock = $prop->getDocComment();
                if (!preg_match("/@MessageBus::deserialize\((.*)\)/", $docBlock, $matches)) {
                    continue;
                }
                $factoryMethod = $matches[1];
                if ($factoryMethod === '$ctor') {
                    $valueFactories[$propName] = function ($value) use ($valueImplementor) {

The variable $valueImplementor does not exist. Did you forget to declare it?

                        return new $valueImplementor($value);
                    };
                } else {
                    $valueFactories[$propName] = $factoryMethod;
                }
            }
        }
        $ctorReflection = $classReflection->getMethod("__construct");
        $ctorArgs = [];
        foreach ($ctorReflection->getParameters() as $argumentReflection) {
            $argName = $argumentReflection->getName();
            if (isset($arrayState[$argName])) {
                if (isset($valueFactories[$argName])) {
                    $ctorArgs[] = call_user_func($valueFactories[$argName], $arrayState[$argName]);
                } else {

This else statement is empty and can be removed.

                    // missing factory annoation, throw exception or ignore?
                }
            } elseif ($argumentReflection->allowsNull()) {
                $ctorArgs[] = null;
            } else {
                throw new \Exception("Missing required value for array-key: $argName while constructing from array");
            }
        }
        return new static(...$ctorArgs);

The call to FromArrayTrait::__construct() has too many arguments starting with $ctorArgs.

    }
}