LazySubscription::getKey() - Code Metrics - Inspection of "add LazySubscription" - daikon-cqrs/message-bus - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 328ed1...c52d79 )

by Thorsten

created 2017-07-13 23:30 UTC

LazySubscription::getKey() A

↳ Parent: LazySubscription

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * This file is part of the daikon-cqrs/message-bus project.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Daikon\MessageBus\Channel\Subscription;

use Daikon\MessageBus\Channel\Subscription\MessageHandler\MessageHandlerList;
use Daikon\MessageBus\EnvelopeInterface;
use Daikon\MessageBus\MessageBusInterface;
use Daikon\MessageBus\Metadata\CallbackMetadataEnricher;
use Daikon\MessageBus\Metadata\Metadata;
use Daikon\MessageBus\Metadata\MetadataEnricherList;

final class LazySubscription implements SubscriptionInterface
{
    private $compositeSubscription;

    private $factoryCallback;

    public function __construct(
        string $key,
        callable $transport,
        callable $messageHandlers,
        callable $guard = null,
        MetadataEnricherList $metadataEnrichers = null
    ) {
        $this->factoryCallback = function () use ($key, $transport, $messageHandlers, $guard, $metadataEnrichers) {
            $metadataEnrichers = $metadataEnrichers->prepend(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                new CallbackMetadataEnricher(function (Metadata $metadata): Metadata {
                    return $metadata->with(self::METADATA_KEY, $this->getKey());
                })
            );
            return new Subscription(
                $key,
                $transport(),
                $messageHandlers(),
                $guard,
                $metadataEnrichers
            );
        };
    }

    public function publish(EnvelopeInterface $envelope, MessageBusInterface $messageBus): bool
    {
        return $this->getSubscription()->publish($envelope);

    }

    public function receive(EnvelopeInterface $envelope): bool
    {
        return $this->getSubscription()->receive($envelope);

    }

    public function getKey(): string
    {
        return $this->getSubscription()->getKey();

    }

    private function getSubscription(): MessageHandlerList
    {
        if (!$this->compositeSubscription) {
            $this->compositeSubscription = call_user_func($this->factoryCallback);
            $this->factoryCallback = null;
        }
        return $this->compositeSubscription;
    }
}


1			<?php
2			/**
3			* This file is part of the daikon-cqrs/message-bus project.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8
9			declare(strict_types=1);
10
11			namespace Daikon\MessageBus\Channel\Subscription;
12
13			use Daikon\MessageBus\Channel\Subscription\MessageHandler\MessageHandlerList;
14			use Daikon\MessageBus\EnvelopeInterface;
15			use Daikon\MessageBus\MessageBusInterface;
16			use Daikon\MessageBus\Metadata\CallbackMetadataEnricher;
17			use Daikon\MessageBus\Metadata\Metadata;
18			use Daikon\MessageBus\Metadata\MetadataEnricherList;
19
20			final class LazySubscription implements SubscriptionInterface
21			{
22			private $compositeSubscription;
23
24			private $factoryCallback;
25
26			public function __construct(
27			string $key,
28			callable $transport,
29			callable $messageHandlers,
30			callable $guard = null,
31			MetadataEnricherList $metadataEnrichers = null
32			) {
33			$this->factoryCallback = function () use ($key, $transport, $messageHandlers, $guard, $metadataEnrichers) {
34			$metadataEnrichers = $metadataEnrichers->prepend(
			0 ignored issues – show Bug introduced 2017-07-13 23:32 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$metadataEnrichers`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
35			new CallbackMetadataEnricher(function (Metadata $metadata): Metadata {
36			return $metadata->with(self::METADATA_KEY, $this->getKey());
37			})
38			);
39			return new Subscription(
40			$key,
41			$transport(),
42			$messageHandlers(),
43			$guard,
44			$metadataEnrichers
45			);
46			};
47			}
48
49			public function publish(EnvelopeInterface $envelope, MessageBusInterface $messageBus): bool
50			{
51			return $this->getSubscription()->publish($envelope);
			0 ignored issues – show Bug introduced 2017-07-13 23:32 UTC by Report Bug Copy Issue Report The method `publish()` does not seem to exist on `object<Daikon\MessageBus...ler\MessageHandlerList>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52			}
53
54			public function receive(EnvelopeInterface $envelope): bool
55			{
56			return $this->getSubscription()->receive($envelope);
			0 ignored issues – show Bug introduced 2017-07-13 23:32 UTC by Report Bug Copy Issue Report The method `receive()` does not seem to exist on `object<Daikon\MessageBus...ler\MessageHandlerList>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57			}
58
59			public function getKey(): string
60			{
61			return $this->getSubscription()->getKey();
			0 ignored issues – show Bug introduced 2017-07-13 23:32 UTC by Report Bug Copy Issue Report The method `getKey()` does not seem to exist on `object<Daikon\MessageBus...ler\MessageHandlerList>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
62			}
63
64			private function getSubscription(): MessageHandlerList
65			{
66			if (!$this->compositeSubscription) {
67			$this->compositeSubscription = call_user_func($this->factoryCallback);
68			$this->factoryCallback = null;
69			}
70			return $this->compositeSubscription;
71			}
72			}
73

daikon-cqrs / message-bus

Push — master ( 328ed1...c52d79 )

LazySubscription::getKey() A

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like