Issues in MapInterface.php (master) - Issues in master - daikon-cqrs/data-structure - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

src/MapInterface.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php declare(strict_types=1);
/**
 * This file is part of the daikon-cqrs/data-structure project.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Daikon\DataStructure;

use Countable;
use Ds\Map;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use IteratorAggregate;

interface MapInterface extends IteratorAggregate, Countable
{
    public function keys(): array;

    public function empty(): self;

    public function has(string $key): bool;

    /**
     * @param mixed $default
     * @return mixed
     */
    public function get(string $key, $default = null);

    /** @param mixed $value */
    public function with(string $key, $value): self;

    public function without(string $key): self;

    /** @return mixed */
    public function first();

    /** @return mixed */
    public function last();

    public function isEmpty(): bool;

    /** @psalm-suppress MissingParamType */
    public function equals($comparator): bool;

    public function unwrap(): array;

    public function getIterator(): Map;

    /** @return mixed */
    public function __get(string $key);
}


1			<?php declare(strict_types=1);
2			/**
3			* This file is part of the daikon-cqrs/data-structure project.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8
9			namespace Daikon\DataStructure;
10
11			use Countable;
12			use Ds\Map;
			0 ignored issues – show Bug introduced 2020-06-05 18:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Daikon\DataStructure\Map`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
13			use IteratorAggregate;
14
15			interface MapInterface extends IteratorAggregate, Countable
16			{
17			public function keys(): array;
18
19			public function empty(): self;
20
21			public function has(string $key): bool;
22
23			/**
24			* @param mixed $default
25			* @return mixed
26			*/
27			public function get(string $key, $default = null);
28
29			/** @param mixed $value */
30			public function with(string $key, $value): self;
31
32			public function without(string $key): self;
33
34			/** @return mixed */
35			public function first();
36
37			/** @return mixed */
38			public function last();
39
40			public function isEmpty(): bool;
41
42			/** @psalm-suppress MissingParamType */
43			public function equals($comparator): bool;
44
45			public function unwrap(): array;
46
47			public function getIterator(): Map;
48
49			/** @return mixed */
50			public function __get(string $key);
51			}
52

daikon-cqrs / data-structure

Issues (19)

src/MapInterface.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like