Modifiable - Code Metrics - Inspection of "Bug fix modifiable" - dacastro4/laravel-gmail - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( e5f8b7...3f2fec )

by Daniel

created 2018-02-06 20:18 UTC

Modifiable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
wmc	17
lcom	2
cbo	1
dl	0
loc	118
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	markAsRead()	8	2
A	markAsUnread()	8	2
A	markAsImportant()	8	2
A	markAsNotImportant()	8	2
A	addStar()	8	2
A	removeStar()	8	2
A	sendToTrash()	8	2
A	removeFromTrash()	8	2

<?php

namespace Dacastro4\LaravelGmail\Traits;

use Dacastro4\LaravelGmail\Services\Message\Mail;
use Google_Service_Gmail;
use Google_Service_Gmail_ModifyMessageRequest;

/**
 * @property Google_Service_Gmail $service
 */
trait Modifiable
{

	use ModifiesLabels {
		ModifiesLabels::__construct as private __mlConstruct;
	}

	private $messageRequest;

	public function __construct()
	{
		$this->__mlConstruct();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * Marks emails as "READ". Returns string of message if fail
	 *
	 * @return Mail|string
	 */
	public function markAsRead()
	{
		try {
			return $this->removeSingleLabel( 'UNREAD' );
		} catch ( \Exception $e ) {
			return "Couldn't mark email as read: {$e->getMessage()}";
		}
	}

	/**
	 * Marks emails as unread
	 *
	 * @return Mail|string
	 * @throws \Exception
	 */
	public function markAsUnread()
	{
		try {
			return $this->addSingleLabel( 'UNREAD' );
		} catch ( \Exception $e ) {
			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
		}
	}

	/**
	 * @return Mail|string
	 * @throws \Exception
	 */
	public function markAsImportant()
	{
		try {
			return $this->addSingleLabel( 'IMPORTANT' );
		} catch ( \Exception $e ) {
			throw new \Exception( "Couldn't remove mark email as important.: {$e->getMessage()}" );
		}
	}

	/**
	 * @return Mail|string
	 * @throws \Exception
	 */
	public function markAsNotImportant()
	{
		try {
			return $this->removeSingleLabel( 'IMPORTANT' );
		} catch ( \Exception $e ) {
			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
		}
	}

	/**
	 * @return Mail|string
	 * @throws \Exception
	 */
	public function addStar()
	{
		try {
			return $this->addSingleLabel( 'STARRED' );
		} catch ( \Exception $e ) {
			throw new \Exception( "Couldn't remove mark email as important.: {$e->getMessage()}" );
		}
	}

	/**
	 * @return Mail|string
	 * @throws \Exception
	 */
	public function removeStar()
	{
		try {
			return $this->removeSingleLabel( 'STARRED' );
		} catch ( \Exception $e ) {
			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
		}
	}

	/**
	 * Send the email to the trash
	 *
	 * @return \Dacastro4\LaravelGmail\Services\Message\Mail|\Exception
	 */
	public function sendToTrash()
	{
		try {
			return $this->addSingleLabel( 'TRASH' );
		} catch ( \Exception $e ) {
			return new \Exception( "Couldn't mark email as trash: {$e->getMessage()}" );
		}
	}

	public function removeFromTrash()
	{
		try {
			return $this->removeSingleLabel( 'TRASH' );
		} catch ( \Exception $e ) {
			return new \Exception( "Couldn't untrash the email: {$e->getMessage()}" );
		}
	}
}

1			<?php
2
3			namespace Dacastro4\LaravelGmail\Traits;
4
5			use Dacastro4\LaravelGmail\Services\Message\Mail;
6			use Google_Service_Gmail;
7			use Google_Service_Gmail_ModifyMessageRequest;
8
9			/**
10			* @property Google_Service_Gmail $service
11			*/
12			trait Modifiable
13			{
14
15			use ModifiesLabels {
16			ModifiesLabels::__construct as private __mlConstruct;
17			}
18
19			private $messageRequest;
20
21			public function __construct()
22			{
23			$this->__mlConstruct();
			0 ignored issues – show Bug introduced 2018-02-06 20:20 UTC by Report Bug Copy Issue Report It seems like `__mlConstruct()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			/**
27			* Marks emails as "READ". Returns string of message if fail
28			*
29			* @return Mail\|string
30			*/
31			public function markAsRead()
32			{
33			try {
34			return $this->removeSingleLabel( 'UNREAD' );
35			} catch ( \Exception $e ) {
36			return "Couldn't mark email as read: {$e->getMessage()}";
37			}
38			}
39
40			/**
41			* Marks emails as unread
42			*
43			* @return Mail\|string
44			* @throws \Exception
45			*/
46			public function markAsUnread()
47			{
48			try {
49			return $this->addSingleLabel( 'UNREAD' );
50			} catch ( \Exception $e ) {
51			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
52			}
53			}
54
55			/**
56			* @return Mail\|string
57			* @throws \Exception
58			*/
59			public function markAsImportant()
60			{
61			try {
62			return $this->addSingleLabel( 'IMPORTANT' );
63			} catch ( \Exception $e ) {
64			throw new \Exception( "Couldn't remove mark email as important.: {$e->getMessage()}" );
65			}
66			}
67
68			/**
69			* @return Mail\|string
70			* @throws \Exception
71			*/
72			public function markAsNotImportant()
73			{
74			try {
75			return $this->removeSingleLabel( 'IMPORTANT' );
76			} catch ( \Exception $e ) {
77			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
78			}
79			}
80
81			/**
82			* @return Mail\|string
83			* @throws \Exception
84			*/
85			public function addStar()
86			{
87			try {
88			return $this->addSingleLabel( 'STARRED' );
89			} catch ( \Exception $e ) {
90			throw new \Exception( "Couldn't remove mark email as important.: {$e->getMessage()}" );
91			}
92			}
93
94			/**
95			* @return Mail\|string
96			* @throws \Exception
97			*/
98			public function removeStar()
99			{
100			try {
101			return $this->removeSingleLabel( 'STARRED' );
102			} catch ( \Exception $e ) {
103			throw new \Exception( "Couldn't mark email as unread: {$e->getMessage()}" );
104			}
105			}
106
107			/**
108			* Send the email to the trash
109			*
110			* @return \Dacastro4\LaravelGmail\Services\Message\Mail\|\Exception
111			*/
112			public function sendToTrash()
113			{
114			try {
115			return $this->addSingleLabel( 'TRASH' );
116			} catch ( \Exception $e ) {
117			return new \Exception( "Couldn't mark email as trash: {$e->getMessage()}" );
118			}
119			}
120
121			public function removeFromTrash()
122			{
123			try {
124			return $this->removeSingleLabel( 'TRASH' );
125			} catch ( \Exception $e ) {
126			return new \Exception( "Couldn't untrash the email: {$e->getMessage()}" );
127			}
128			}
129			}

dacastro4 / laravel-gmail

Push — master ( e5f8b7...3f2fec )

Modifiable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like