HasParts::iterateParts() - Code Metrics - Inspection of "v2.0" - dacastro4/laravel-gmail - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#87)

by Daniel

created 2019-06-26 14:10 UTC

HasParts::iterateParts() A

↳ Parent: HasParts

Complexity

Conditions	5
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	11
c	2
b	0
f	0
nc	3
nop	2
dl	0
loc	21
rs	9.6111

<?php

namespace Dacastro4\LaravelGmail\Traits;

use Illuminate\Support\Collection;

trait HasParts
{
	/**
	 * Find all Parts of a message.
	 * Necessary to reset the $allParts Varibale.
	 *
	 * @param  collection  $partsContainer  . F.e. collect([$message->payload])
	 *
	 * @return Collection of all 'parts' flattened
	 */
	private function getAllParts($partsContainer)
	{
		return $this->iterateParts($partsContainer);

	}


	/**
	 * Recursive Method. Iterates through a collection,
	 * finding all 'parts'.
	 *
	 * @param  collection  $partsContainer
	 * @param  bool  $returnOnFirstFound
	 *
	 * @return Collection|boolean
	 */

	private function iterateParts($partsContainer, $returnOnFirstFound = false)
	{
		$allParts = [];
		$parts = $partsContainer->pluck('parts');

		if ($parts) {

			foreach ($parts as $part) {
				if ($part) {
					if ($returnOnFirstFound) {
						return true;
					}

					$allParts[] = $part;
					$part = collect($part);
					$this->iterateParts($part);
				}
			}

		}

		return (collect($allParts))->flatten();
	}
}


1			<?php
2
3			namespace Dacastro4\LaravelGmail\Traits;
4
5			use Illuminate\Support\Collection;
6
7			trait HasParts
8			{
9			/**
10			* Find all Parts of a message.
11			* Necessary to reset the $allParts Varibale.
12			*
13			* @param collection $partsContainer . F.e. collect([$message->payload])
14			*
15			* @return Collection of all 'parts' flattened
16			*/
17			private function getAllParts($partsContainer)
18			{
19			return $this->iterateParts($partsContainer);
			0 ignored issues – show Bug Best Practice introduced 2019-06-26 14:00 UTC by Report Bug Copy Issue Report The expression `return $this->iterateParts($partsContainer)` also could return the type `true` which is incompatible with the documented return type `Illuminate\Support\Collection`. Loading history...
20			}
21
22
23			/**
24			* Recursive Method. Iterates through a collection,
25			* finding all 'parts'.
26			*
27			* @param collection $partsContainer
28			* @param bool $returnOnFirstFound
29			*
30			* @return Collection\|boolean
31			*/
32
33			private function iterateParts($partsContainer, $returnOnFirstFound = false)
34			{
35			$allParts = [];
36			$parts = $partsContainer->pluck('parts');
37
38			if ($parts) {
			0 ignored issues – show introduced 2019-06-26 14:00 UTC by Report Bug Copy Issue Report `$parts` is of type `Illuminate\Support\Collection`, thus it always evaluated to `true`. Loading history...
39			foreach ($parts as $part) {
40			if ($part) {
41			if ($returnOnFirstFound) {
42			return true;
43			}
44
45			$allParts[] = $part;
46			$part = collect($part);
47			$this->iterateParts($part);
48			}
49			}
50
51			}
52
53			return (collect($allParts))->flatten();
54			}
55			}
56

dacastro4 / laravel-gmail

Pull Request — master (#87)

HasParts::iterateParts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like