Day1::calculateFrequency() - Code Metrics - Inspection of "refactor" - daanmooij/advent-of-code-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdce49...6393b8 )

by Daan

created 2020-12-20 14:34 UTC

Day1::calculateFrequency() A

↳ Parent: Day1

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace DaanMooij\AdventOfCode\Year2018\Day1;

use DaanMooij\AdventOfCode\Day;
use Exception;

class Day1 implements Day
{
    /**
     * @var array<int>
     */
    private array $changes = [];

    /**
     * @return void
     */
    public function loadInput(): void
    {
        $filepath = __DIR__ . '/input.txt';
        $input = fopen($filepath, "r");

        if (!is_resource($input)) {
            throw new Exception("Could not open input file: {$filepath}");
        }

        while (!feof($input)) {
            $this->changes[] = intval(fgets($input));
        }
        fclose($input);
    }

    /**
     * @return void
     */
    public function solve(): void
    {
        printf("The resulting frequency is: %s\n", $this->calculateFrequency());
        printf("The first frequency that's reached twice is: %s\n", $this->getFrequencyReachedTwice());
    }

    /**
     * @param array<int> $changes
     * @return void
     */
    public function setChanges(array $changes): void
    {
        $this->changes = $changes;
    }

    /**
     * @return array<int>
     */
    public function getChanges(): array
    {
        return $this->changes;
    }

    /**
     * @param int $frequency -> The starting frequency
     * @return int
     */
    public function calculateFrequency(int $frequency = 0): int
    {
        foreach ($this->changes as $change) {
            $frequency += $change;
        }

        return $frequency;
    }

    /**
     * @param int $frequency -> The starting frequency
     * @return int
     */
    public function getFrequencyReachedTwice(int $frequency = 0): int
    {
        $memory = [$frequency => 1];

        $found = false;
        while (!$found) {
            foreach ($this->changes as $change) {
                $frequency += $change;

                if (isset($memory[$frequency])) {
                    $found = true;
                    break;
                }

                $memory[$frequency] = 1;
            }
        }

        return $frequency;
    }
}


1			<?php
2
3			namespace DaanMooij\AdventOfCode\Year2018\Day1;
4
5			use DaanMooij\AdventOfCode\Day;
6			use Exception;
7
8			class Day1 implements Day
9			{
10			/**
11			* @var array<int>
12			*/
13			private array $changes = [];
14
15			/**
16			* @return void
17			*/
18			public function loadInput(): void
19			{
20			$filepath = __DIR__ . '/input.txt';
21			$input = fopen($filepath, "r");
22
23			if (!is_resource($input)) {
24			throw new Exception("Could not open input file: {$filepath}");
25			}
26
27			while (!feof($input)) {
28			$this->changes[] = intval(fgets($input));
29			}
30			fclose($input);
31			}
32
33			/**
34			* @return void
35			*/
36			public function solve(): void
37			{
38			printf("The resulting frequency is: %s\n", $this->calculateFrequency());
39			printf("The first frequency that's reached twice is: %s\n", $this->getFrequencyReachedTwice());
40			}
41
42			/**
43			* @param array<int> $changes
44			* @return void
45			*/
46			public function setChanges(array $changes): void
47			{
48			$this->changes = $changes;
49			}
50
51			/**
52			* @return array<int>
53			*/
54			public function getChanges(): array
55			{
56			return $this->changes;
57			}
58
59			/**
60			* @param int $frequency -> The starting frequency
61			* @return int
62			*/
63			public function calculateFrequency(int $frequency = 0): int
64			{
65			foreach ($this->changes as $change) {
66			$frequency += $change;
67			}
68
69			return $frequency;
70			}
71
72			/**
73			* @param int $frequency -> The starting frequency
74			* @return int
75			*/
76			public function getFrequencyReachedTwice(int $frequency = 0): int
77			{
78			$memory = [$frequency => 1];
79
80			$found = false;
81			while (!$found) {
82			foreach ($this->changes as $change) {
83			$frequency += $change;
84
85			if (isset($memory[$frequency])) {
86			$found = true;
87			break;
88			}
89
90			$memory[$frequency] = 1;
91			}
92			}
93
94			return $frequency;
95			}
96			}
97

daanmooij / advent-of-code-php

Push — master ( bdce49...6393b8 )

Day1::calculateFrequency() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like