NovaPoshta::getResponse() - Code Metrics - Inspection of "See changelog 2022-11-03 2" - daaner/NovaPoshta - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 655901...c58a64 )

by Andrey

created 2022-11-03 16:05 UTC

NovaPoshta::getResponse() B

↳ Parent: NovaPoshta

Complexity

Conditions	10
Paths	36

Size

Total Lines	71
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	11
Bugs	1	Features	0

Metric	Value
cc	10
eloc	31
nc	36
nop	4
dl	0
loc	71
rs	7.6666
c	11
b	1
f	0

How to fix Long Method Complexity

<?php

namespace Daaner\NovaPoshta;

use Daaner\NovaPoshta\Contracts\NovaPoshtaInterface;
use Exception;
use Illuminate\Support\Facades\Http;
use Illuminate\Support\Facades\Log;

class NovaPoshta implements NovaPoshtaInterface
{
    protected $baseUri;
    protected $point;

    protected $api;
    protected $url;
    protected $dev;

    protected $return;


    /**
     * NovaPoshta constructor main settings.
     */
    public function __construct()
    {
        $this->baseUri = config('novaposhta.base_uri');
        $this->point = config('novaposhta.point');
        $this->dev = config('novaposhta.dev');
        $this->getApi();
        $this->url = $this->baseUri.$this->point;

        $this->return = [
            'success' => false,
            'result' => null,
            'info' => [],
        ];
    }

    /**
     * @return string
     */
    public function getApi(): string
    {
        if (! $this->api) {
            $this->api = config('novaposhta.api_key');
        }

        return $this->api;
    }

    /**
     * Устанавливаем API токен отличный от значения в конфиге.
     *
     * @param  string  $api  API токен
     * @return $this
     */
    public function setApi(string $api): self
    {
        $this->api = $api;

        return $this;
    }

    /**
     * @param  string  $model  Модель Новой Почты
     * @param  string  $calledMethod  Метод модели
     * @param  array|null  $methodProperties  Тело запроса
     * @param  bool|null  $auth  Использовать ли аутентификацию токеном или нет
     * @return array
     */
    public function getResponse(
        string $model,
        string $calledMethod,
        ?array $methodProperties,
        ?bool $auth = true
    ): array {
        $url = $this->url.'/'.$model.'/'.$calledMethod;

        $body= [];
        $body['modelName'] = $model;
        $body['calledMethod'] = $calledMethod;
        $body['methodProperties'] = $methodProperties;

        if ($auth) {
            $body['apiKey'] = $this->api;
        }

        $response = Http::timeout(config('novaposhta.http_response_timeout', 3))
            ->retry(
                config('novaposhta.http_retry_max_time', 2),
                config('novaposhta.http_retry_delay', 200)
            )
            ->withHeaders([
                'Accept' => 'application/json',
                'Content-Type' => 'application/json',
            ])
            ->post($url, $body);

        if ($response->failed() || $response->json() === null) {

            $this->return['info']['error'] = trans('novaposhta::novaposhta.error_data');

            if ($this->dev) {
                $this->development($model, $calledMethod, $auth, $methodProperties, '');
                $this->development($model, $calledMethod, /** @scrutinizer ignore-type */ $auth, $methodProperties, '');
            }

            return $this->return;
        }

        $answer = $response->json();

        /**
         * Development
         */
        if ($this->dev) {
            $this->development($model, $calledMethod, $auth, $methodProperties, $answer);
        }

        // TODO Возможно, исправлено
        if ($auth === false && isset($answer[0])) {
            /**
             * Костыль для Новой Почты.
             * Спасибо Вам большое, что нормально не выдаете ответ :).
             */
            $answer = $answer[0];
        }

        if (isset($answer['success'])) {
            $this->return['success'] = $answer['success'];
        }

        if (isset($answer['data'])) {
            $this->return['result'] = $answer['data'];
        }

        /**
         * Формирование info
         */
        $this->return['info'] = $this->addInfo($answer);

        return $this->return;
    }

    /**
     * Формирование информации.
     * Ошибки, уведомления.
     *
     * @param mixed $answer Ответ от НП
     */
    public function addInfo($answer): array
    {
        $info = [];

        if (isset($answer['warnings']) && $answer['warnings']) {
            $info['warnings'] = $answer['warnings'];
        }

        if (isset($answer['errors']) && $answer['errors']) {
            $info['errors'] = $answer['errors'];
            if ($answer['errorCodes']) {
                foreach ($answer['errorCodes'] as $err) {
                    $info['StatusCode'] = $err;
                }
                if (isset($answer['errorCodes'][0])) {
                    $info['StatusLocale'] = __('novaposhta::novaposhta.statusCode.'.$answer['errorCodes'][0]);
                }
            }
        }

        if (empty($info) && isset($answer['info']) && $answer['info']) {
            $info['info'] = $answer['info'];
        }

        return $info;
    }


    /**
     * Логирование запроса.
     *
     * @param string $model Модель
     * @param string $calledMethod Метод
     * @param bool $auth Аутентификация
     * @param mixed $methodProperties Тело запроса
     * @param mixed $answer Ответ
     * @return void
     */
    public function development(
        string $model,
        string $calledMethod,
        bool $auth,
        $methodProperties,
        $answer
    ): void
    {
        Log::debug('= = = = = = = = = = = = = = = = = = = =');
        Log::debug($model.' / '.$calledMethod.' // apiKey: '. (int) $auth);
        Log::debug('--------------------');

        if (! empty($methodProperties)) {
            try {
                Log::notice(json_encode($methodProperties));
            } catch (Exception $e) {
                Log::notice('method json_encode error');
            }
        }

        $this->return['dev'] = $answer;
    }
}


daaner / NovaPoshta

Push — master ( 655901...c58a64 )

NovaPoshta::getResponse() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like