Daaner\NovaPoshta\Traits\CounterpartyProperty

Complexity

Total Complexity

14

Size/Duplication

Total Lines	123
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getEDRPOU()	0	9	2
A	getCounterpartyType()	0	9	2
A	setCounterpartyProperty()	0	5	1
A	getOwnershipForm()	0	9	2
A	setCounterpartyType()	0	5	1
A	getCounterpartyProperty()	0	15	3
A	setOwnershipForm()	0	5	1
A	makeOrganization()	0	8	1
A	setEDRPOU()	0	5	1

<?php

namespace Daaner\NovaPoshta\Traits;

trait CounterpartyProperty
{
    protected $counterpartyType;
    protected $counterpartyProperty;
    protected $ownershipForm;
    protected $EDRPOU;

    /**
     * @return this
     */
    public function setCounterpartyType($counterpartyType)
    {
        $this->counterpartyType = $counterpartyType;

        return $this;
    }

    /**
     * @return this
     */
    public function setCounterpartyProperty($counterpartyProperty)
    {
        $this->counterpartyProperty = $counterpartyProperty;

        return $this;
    }

    /**
     * @return this
     */
    public function setOwnershipForm($ownershipForm)
    {
        $this->ownershipForm = $ownershipForm;

        return $this;
    }

    /**
     * @return this
     */
    public function setEDRPOU($EDRPOU)
    {
        $this->EDRPOU = $EDRPOU;

        return $this;
    }

    /**
     * @return this
     */
    public function getCounterpartyType()
    {
        if (! $this->counterpartyType) {
            $this->counterpartyType = 'PrivatePerson';
        }

        $this->methodProperties['CounterpartyType'] = $this->counterpartyType;

The property methodProperties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @return this
     */
    public function getCounterpartyProperty()
    {
        //Сделано для getCounterpartyAddresses,
        //однако этот справочник игнорирует СounterpartyProperty в поиске
        if ($this->counterpartyProperty == 'All') {
            return $this;
        }

        if (! $this->counterpartyProperty) {
            $this->counterpartyProperty = 'Recipient';
        }

        $this->methodProperties['CounterpartyProperty'] = $this->counterpartyProperty;

The property methodProperties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @return this
     */
    public function getOwnershipForm()
    {
        if ($this->ownershipForm) {
            $this->methodProperties['OwnershipForm'] = $this->ownershipForm;

The property methodProperties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->methodProperties['CounterpartyType'] = 'Organization';
            $this->makeOrganization();
        }

        return $this;
    }

    /**
     * @return this
     */
    public function getEDRPOU()
    {
        if ($this->EDRPOU) {
            $this->methodProperties['EDRPOU'] = $this->EDRPOU;

The property methodProperties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->methodProperties['CounterpartyProperty'] = 'ThirdPerson';
            $this->makeOrganization();
        }

        return $this;
    }


    /**
     * Вынесенная логика для удаления контактов
     * используется для создания / изменения данных организаций или третьих лиц
     * @return this
     */
    public function makeOrganization()
    {
        $lastName = '';

The assignment to $lastName is dead and can be removed.

        $middleName = '';

The assignment to $middleName is dead and can be removed.

        $phone = '';

The assignment to $phone is dead and can be removed.

        $email = '';

The assignment to $email is dead and can be removed.

        return $this;
    }


}