Daaner\NovaPoshta\NovaPoshta::getResponse()

Complexity

Conditions	19
Paths	258

Size

Total Lines	99
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	1	Features	0

<?php
    public function getResponse(string $model, string $calledMethod, ?array $methodProperties, bool $auth = true): array
    {
        $url = $this->url.'/'.$model.'/'.$calledMethod;
        $body = [];
        $info = '';

        $body['modelName'] = $model;
        $body['calledMethod'] = $calledMethod;
        $body['methodProperties'] = $methodProperties;

        if ($auth) {
            $body['apiKey'] = $this->api;
        }

        $response = Http::timeout(config('novaposhta.http_response_timeout', 3))
            ->retry(config('novaposhta.http_retry_max_time', 2), config('novaposhta.http_retry_delay', 200))
            ->withHeaders([
                'Accept' => 'application/json',
                'Content-Type' => 'application/json',
            ])
            ->post($url, $body);

        if ($response->failed()) {
            return [
                'success' => false,
                'result' => null,
                'info' => trans('novaposhta::novaposhta.error_data'),
            ];
        }

        $answer = $response->json();
        if ($auth === false && isset($answer[0])) {
            /**
             * Костыль для Новой Почты.
             * Спасибо Вам большое, что нормально не выдаете ответ :).
             */
            $answer = $answer[0];
        }

        if (! isset($answer['success']) || ! isset($answer['data']) || empty($answer['data'])) {
            /**
             * Что-то не так в ответе.
             */
            $info = trans('novaposhta::novaposhta.error_answer');

The assignment to $info is dead and can be removed.

            $success = false;
            $result = null;
        } else {
            $success = $answer['success'];
            $result = $answer['data'];
        }

        /**
         * Ошибки, либо уведомления.
         */
        $info = [];
        if (isset($answer['warnings']) && $answer['warnings']) {
            $info['warnings'] = $answer['warnings'];

            if ($answer['errors']) {
                $info['errors'] = $answer['errors'];
                if ($answer['errorCodes']) {
                    foreach ($answer['errorCodes'] as $err) {
                        $info['StatusCode'] = $err;
                        $info['StatusLocale'] = __('novaposhta::novaposhta.statusCode.'.$err);
                    }
                }
            }
        }

        if (! $info && isset($answer['info']) && $answer['info']) {
            $info['info'] = $answer['info'];
        }

        $return = [
            'success' => $success,
            'result' => $result,
            'info' => $info,
        ];

        if ($this->dev) {
            /**
             * Test and Dev.
             */
            Log::debug('= = = = = = = = = = = = = = = = = = = =');
            Log::debug($model.' / '.$calledMethod.' // apiKey: '.$auth);
            Log::debug('--------------------');

            if ($methodProperties) {

The expression $methodProperties of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                try {
                    Log::notice(json_encode($methodProperties));
                } catch (Exception $e) {
                    Log::notice('method json_encode error');
                }
            }

            $return['dev'] = $answer;
        }

        return $return;
    }