Issues in LikeDislikeAPITest.php (master) - Issues in master - d3ltcod/LaravelTube - Measure and Improve Code Quality continuously with Scrutinizer

Issues (162)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/LikeDislikeAPITest.php (8 issues)

Labels

Severity

Informational 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use App\LikeDislike;
use App\User;
use App\Video;
use Chrisbjr\ApiGuard\Models\ApiKey;
use Illuminate\Foundation\Testing\DatabaseMigrations;

class LikeDislikeAPITest extends TestCase
{
    use DatabaseMigrations;

    /**
     * Create fake user.
     *
     * @return mixed
     */
    public function createUser()
    {
        $user = factory(User::class)->create();
        $this->createUserApiKey($user);

        return $user;
    }

    /**
     * @param User $user
     *
     * @return mixed
     */
    private function createUserApiKey(User $user)
    {
        $apiKey = ApiKey::make($user->id);
        $user->apiKey()->save($apiKey);
    }

    /**
     * Create fake video.
     *
     * @return \App\Video
     */
    private function createFakeVideo($user)

    {
        $faker = Faker\Factory::create();
        $video = new Video();
        $video->name = $faker->sentence;
        $video->category = $faker->word;
        $video->path = $faker->url;
        $user->getVideos()->save($video);

        $this->createFakeLikes($video->id);

        return $video;
    }

    private function createFakeLikes($video_id)

    {
        $video = Video::find($video_id);
        $type = [
            'like',
            'dislike',
        ];

        for ($i = 0; $i < 10; $i++) {
            $user = $this->createUser();
            $key = array_rand($type);

            $data = [
                'user_id'  => $user->id,
                'video_id' => $video->id,
                'type'     => $type[$key],
            ];

            LikeDislike::create($data);
        }
    }

    /**
     * Test likes in database are listed by API.
     *
     * @return void
     */
    public function testLikesInDatabaseAreListedByAPI()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);

        $this->get('/api/videos/'.$video->id.'/likes')
            ->seeJsonStructure([
                '*' => [
                    '*' => [
                        'user_id', 'video_id', 'type',
                    ],
                ],
            ])->seeStatusCode(200);
    }

    /**
     * Test dislikes in database are listed by API.
     *
     * @return void
     */
    public function testDislikesInDatabaseAreListedByAPI()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $this->get('/api/videos/'.$video->id.'/dislikes')
            ->seeJsonStructure([
                '*' => [
                    '*' => [
                        'user_id', 'video_id', 'type',
                    ],
                ],
            ])->seeStatusCode(200);
    }

    /**
     * Test likes count return integer.
     *
     * @return void
     */
    public function testLikesCountReturnInteger()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $count = $this->get('/api/videos/'.$video->id.'/likes/count');

        $this->assertTrue(is_int($count->response->original));
    }

    /**
     * Test dislikes count return integer.
     *
     * @return void
     */
    public function testDisikesCountReturnInteger()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $count = $this->get('/api/videos/'.$video->id.'/dislikes/count');

        $this->assertTrue(is_int($count->response->original));
    }

    /**
     * Test store like and see in DB.
     *
     * @return void
     */
    public function testCanBePostLikeAndSeeInDB()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);

        $data = [
            'user_id'  => $user->id,
            'video_id' => $video->id,
            'type'     => 'like',
        ];

        $this->post('/api/videos/'.$video->id.'/like-dislike', $data, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('likes_dislikes', $data);
        $this->get('/api/videos/'.$video->id.'/likes')->seeJsonContains($data)->seeStatusCode(200);
    }

    /**
     * Test delete likeDislike and not see in DB.
     *
     * @return void
     */
    public function testCanBeDeleteLikeAndSeeInDB()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);

        $data = [
            'user_id'  => $user->id,
            'video_id' => $video->id,
            'type'     => 'like',
        ];

        LikeDislike::create($data);

        $this->post('/api/videos/'.$video->id.'/like-dislike', $data, ['X-Authorization' => $user->apiKey->key])->notSeeInDatabase('likes_dislikes', $data);
        $this->get('/api/videos/'.$video->id.'/likes')->dontSeeJson([$data])->seeStatusCode(200);
    }

    /**
     * Test update type likeDislike and not see in DB.
     *
     * @return void
     */
    public function testCanBeUpdateTypeLikeAndSeeInDB()
    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);

        $data = [
            'user_id'  => $user->id,
            'video_id' => $video->id,
            'type'     => 'like',
        ];

        LikeDislike::create($data);

        $dataUpdate = [
            'user_id'  => $user->id,
            'video_id' => $video->id,
            'type'     => 'dislike',
        ];

        $this->post('/api/videos/'.$video->id.'/like-dislike', $dataUpdate, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('likes_dislikes', $dataUpdate);
        $this->get('/api/videos/'.$video->id.'/dislikes')->seeJsonContains($dataUpdate)->seeStatusCode(200);
    }
}


1		<?php
2
3		use App\LikeDislike;
4		use App\User;
5		use App\Video;
6		use Chrisbjr\ApiGuard\Models\ApiKey;
7		use Illuminate\Foundation\Testing\DatabaseMigrations;
8
9		class LikeDislikeAPITest extends TestCase
10		{
11		use DatabaseMigrations;
12
13		/**
14		* Create fake user.
15		*
16		* @return mixed
17		*/
18		public function createUser()
19		{
20		$user = factory(User::class)->create();
21		$this->createUserApiKey($user);
22
23		return $user;
24		}
25
26		/**
27		* @param User $user
28		*
29		* @return mixed
30		*/
31		private function createUserApiKey(User $user)
32		{
33		$apiKey = ApiKey::make($user->id);
34		$user->apiKey()->save($apiKey);
35		}
36
37		/**
38		* Create fake video.
39		*
40		* @return \App\Video
41		*/
42	View Code Duplication	private function createFakeVideo($user)
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$faker = Faker\Factory::create();
45		$video = new Video();
46		$video->name = $faker->sentence;
47		$video->category = $faker->word;
48		$video->path = $faker->url;
49		$user->getVideos()->save($video);
50
51		$this->createFakeLikes($video->id);
52
53		return $video;
54		}
55
56	View Code Duplication	private function createFakeLikes($video_id)
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$video = Video::find($video_id);
59		$type = [
60		'like',
61		'dislike',
62		];
63
64		for ($i = 0; $i < 10; $i++) {
65		$user = $this->createUser();
66		$key = array_rand($type);
67
68		$data = [
69		'user_id' => $user->id,
70		'video_id' => $video->id,
71		'type' => $type[$key],
72		];
73
74		LikeDislike::create($data);
75		}
76		}
77
78		/**
79		* Test likes in database are listed by API.
80		*
81		* @return void
82		*/
83	View Code Duplication	public function testLikesInDatabaseAreListedByAPI()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84		{
85		$user = $this->createUser();
86		$video = $this->createFakeVideo($user);
87
88		$this->get('/api/videos/'.$video->id.'/likes')
89		->seeJsonStructure([
90		'*' => [
91		'*' => [
92		'user_id', 'video_id', 'type',
93		],
94		],
95		])->seeStatusCode(200);
96		}
97
98		/**
99		* Test dislikes in database are listed by API.
100		*
101		* @return void
102		*/
103	View Code Duplication	public function testDislikesInDatabaseAreListedByAPI()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		$user = $this->createUser();
106		$video = $this->createFakeVideo($user);
107		$this->get('/api/videos/'.$video->id.'/dislikes')
108		->seeJsonStructure([
109		'*' => [
110		'*' => [
111		'user_id', 'video_id', 'type',
112		],
113		],
114		])->seeStatusCode(200);
115		}
116
117		/**
118		* Test likes count return integer.
119		*
120		* @return void
121		*/
122	View Code Duplication	public function testLikesCountReturnInteger()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123		{
124		$user = $this->createUser();
125		$video = $this->createFakeVideo($user);
126		$count = $this->get('/api/videos/'.$video->id.'/likes/count');
127
128		$this->assertTrue(is_int($count->response->original));
129		}
130
131		/**
132		* Test dislikes count return integer.
133		*
134		* @return void
135		*/
136	View Code Duplication	public function testDisikesCountReturnInteger()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
137		{
138		$user = $this->createUser();
139		$video = $this->createFakeVideo($user);
140		$count = $this->get('/api/videos/'.$video->id.'/dislikes/count');
141
142		$this->assertTrue(is_int($count->response->original));
143		}
144
145		/**
146		* Test store like and see in DB.
147		*
148		* @return void
149		*/
150	View Code Duplication	public function testCanBePostLikeAndSeeInDB()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$user = $this->createUser();
153		$video = $this->createFakeVideo($user);
154
155		$data = [
156		'user_id' => $user->id,
157		'video_id' => $video->id,
158		'type' => 'like',
159		];
160
161		$this->post('/api/videos/'.$video->id.'/like-dislike', $data, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('likes_dislikes', $data);
162		$this->get('/api/videos/'.$video->id.'/likes')->seeJsonContains($data)->seeStatusCode(200);
163		}
164
165		/**
166		* Test delete likeDislike and not see in DB.
167		*
168		* @return void
169		*/
170	View Code Duplication	public function testCanBeDeleteLikeAndSeeInDB()
		0 ignored issues – show Duplication introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
171		{
172		$user = $this->createUser();
173		$video = $this->createFakeVideo($user);
174
175		$data = [
176		'user_id' => $user->id,
177		'video_id' => $video->id,
178		'type' => 'like',
179		];
180
181		LikeDislike::create($data);
182
183		$this->post('/api/videos/'.$video->id.'/like-dislike', $data, ['X-Authorization' => $user->apiKey->key])->notSeeInDatabase('likes_dislikes', $data);
184		$this->get('/api/videos/'.$video->id.'/likes')->dontSeeJson([$data])->seeStatusCode(200);
185		}
186
187		/**
188		* Test update type likeDislike and not see in DB.
189		*
190		* @return void
191		*/
192		public function testCanBeUpdateTypeLikeAndSeeInDB()
193		{
194		$user = $this->createUser();
195		$video = $this->createFakeVideo($user);
196
197		$data = [
198		'user_id' => $user->id,
199		'video_id' => $video->id,
200		'type' => 'like',
201		];
202
203		LikeDislike::create($data);
204
205		$dataUpdate = [
206		'user_id' => $user->id,
207		'video_id' => $video->id,
208		'type' => 'dislike',
209		];
210
211		$this->post('/api/videos/'.$video->id.'/like-dislike', $dataUpdate, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('likes_dislikes', $dataUpdate);
212		$this->get('/api/videos/'.$video->id.'/dislikes')->seeJsonContains($dataUpdate)->seeStatusCode(200);
213		}
214		}
215

d3ltcod / LaravelTube

Issues (162)

Security Analysis not enabled

tests/LikeDislikeAPITest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like