VideoAPITest - Code Metrics - d3ltcod/LaravelTube - Measure and Improve Code Quality continuously with Scrutinizer

VideoAPITest A
last analyzed 2018-01-04 22:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	225
Duplicated Lines	20.89 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

Metric	Value
wmc	17
lcom	1
cbo	10
dl	47
loc	225
rs	10
c	0
b	0
f	0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	createUser()	0	7	1
A	createUserApiKey()	0	5	1
A	createFakeVideo()	11	11	1
A	createFakeVideos()	0	7	2
A	testVideoUseJson()	0	4	1
A	testVideosInDatabaseAreListedByAPI()	0	12	1
A	testVideoReturn404OnVideoNotExists()	0	4	1
A	testBestVideosUseJson()	0	6	1
A	testVideosUserUseJson()	7	7	1
A	testVideosForCategory()	7	7	1
A	testVideoInDatabaseAreShownByAPI()	7	7	1
A	testVideosUnauthorizedPostedWithoutApiKey()	0	5	1
A	testVideosCanBePostedAndSavedIntoDatabase()	0	18	1
A	testVideosCanBeUpdatedAndSeeChangesInDatabase()	0	8	1
A	testVideosCanBeDeletedAndNotSeenOnDatabase()	8	8	1
A	testVideosCanBeSearchAndSeenResult()	7	7	1

How to fix Duplicated Code

<?php

use App\User;
use App\Video;
use Chrisbjr\ApiGuard\Models\ApiKey;
use Illuminate\Foundation\Testing\DatabaseMigrations;

/**
 * Created by PhpStorm.
 * User: adam
 * Date: 22/04/16
 * Time: 09:18.
 */
class VideoAPITest extends TestCase
namespace YourVendor;

class YourClass { }
{
    use DatabaseMigrations;

    /**
     * Create fake user.
     *
     * @return mixed
     */
    public function createUser()
    {
        $user = factory(User::class)->create();
        $this->createUserApiKey($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $user;
    }

    /**
     * @param User $user
     *
     * @return mixed
     */
    private function createUserApiKey(User $user)
    {
        $apiKey = ApiKey::make($user->id);
        $user->apiKey()->save($apiKey);
    }

    /**
     * Create fake video.
     *
     * @return \App\Video
     */
    private function createFakeVideo($user)

    {
        $faker = Faker\Factory::create();
        $video = new Video();
        $video->name = $faker->sentence;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $video->category = $faker->word;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $video->path = $faker->url;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->getVideos()->save($video);

        return $video;
    }

    /**
     * Create fake videos.
     *
     * @param int $count
     *
     * @return \App\Video
     */
    private function createFakeVideos($count = 10)
    {
        $user = $this->createUser();
        foreach (range(0, $count) as $number) {
            $this->createFakeVideo($user);
        }
    }

    /**
     * Test video is an api then returns JSON.
     *
     * @return void
     */
    public function testVideoUseJson()
    {
        $this->get('/api/videos')->seeJson()->seeStatusCode(200);
    }

    /**
     * Test videos in database are listed by API.
     *
     * @return void
     */
    public function testVideosInDatabaseAreListedByAPI()
    {
        $this->createFakeVideos();
        $this->get('/api/videos')
            ->seeJsonStructure([
                '*' => [
                    '*' => [
                        'category', 'id', 'name', 'path',
                    ],
                ],
            ])->seeStatusCode(200);
    }

    /**
     * Test Video Return 404 on video not exists.
     *
     * @return void
     */
    public function testVideoReturn404OnVideoNotExists()
    {
        $this->get('/api/videos/50000')->seeJson()->seeStatusCode(404);
    }

    /**
     * Test best videos is an api then returns JSON.
     *
     * @return void
     */
    public function testBestVideosUseJson()
    {
        $user = $this->createUser();
        $this->createFakeVideo($user);
        $this->get('/api/videos/best')->seeJson()->seeStatusCode(200);
    }

    /**
     * Test videos user is an api then returns JSON.
     *
     * @return void
     */
    public function testVideosUserUseJson()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $this->get('/api/videos/user/'.$user->id)->seeJsonContains(['name' => $video->name, 'category' => $video->category, 'path' => $video->path])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->seeStatusCode(200);
    }

    /**
     * Test videos for category is an api then returns JSON.
     *
     * @return void
     */
    public function testVideosForCategory()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $this->get('/api/videos/category/'.$video->category)->seeJsonContains(['name' => $video->name, 'category' => $video->category, 'path' => $video->path])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->seeStatusCode(200);
    }

    /**
     * Test video in database is shown by API.
     *
     * @return void
     */
    public function testVideoInDatabaseAreShownByAPI()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $this->get('/api/videos/'.$video->id)->seeJsonContains(['name' => $video->name, 'category' => $video->category, 'path' => $video->path])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->seeStatusCode(200);
    }

    /**
     * Test videos Unauthorized posted without apikey.
     *
     * @return void
     */
    public function testVideosUnauthorizedPostedWithoutApiKey()
    {
        $data = ['name' => 'Foobar', 'category' => 'Movie', 'path' => '/videos/foobar.mp4'];
        $this->post('/api/videos', $data)->seeStatusCode(401)->seeJsonContains(['message' => 'Unauthorized']);
    }

    /**
     * Test videos can be posted and saved to database.
     *
     * @return void
     */
    public function testVideosCanBePostedAndSavedIntoDatabase()
    {
        $user = $this->createUser();
        $this->createUserApiKey($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $file = storage_path('app/public/videos/demo.mp4');
        $video = new Symfony\Component\HttpFoundation\File\UploadedFile(
                $file,
                'demo.mp4',
                'video/mp4',
                null,
                null,
                true
            );

        $data = ['name' => 'demo', 'category' => 'Movie', 'video' => $video];
        $this->post('/api/videos', $data, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('videos', ['name' => 'demo', 'category' => 'Movie', 'path' => '/storage/videos/demo'.$user->id]);
        $this->get('/api/videos')->seeJsonContains(['name' => 'demo', 'category' => 'Movie', 'path' => '/storage/videos/demo'.$user->id])->seeStatusCode(200);
    }

    /**
     * Test videos can be update and see changes on database.
     *
     * @return void
     */
    public function testVideosCanBeUpdatedAndSeeChangesInDatabase()
    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $data = ['name' => 'V for Vendetta', 'category' => 'Movie'];
        $this->put('/api/videos/'.$video->id, $data, ['X-Authorization' => $user->apiKey->key])->seeInDatabase('videos', $data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->get('/api/videos')->seeJsonContains([$data = ['id' => $video->id, 'name' => 'V for Vendetta', 'category' => 'Movie', 'path' => $video->path, 'likes' => $video->likes()->count(), 'dislikes' => $video->dislikes()->count(), 'comments' => $video->getComments]])->seeStatusCode(200);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Test videos can be deleted and not see on database.
     *
     * @return void
     */
    public function testVideosCanBeDeletedAndNotSeenOnDatabase()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $data = ['name' => $video->name, 'category' => $video->category, 'path' => $video->path];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->delete('/api/videos/'.$video->id, ['X-Authorization' => $user->apiKey->key])->notSeeInDatabase('videos', $data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->get('/api/videos')->dontSeeJson($data)->seeStatusCode(200);
    }

    /**
     * Test videos can be search and see result.
     *
     * @return void
     */
    public function testVideosCanBeSearchAndSeenResult()

    {
        $user = $this->createUser();
        $video = $this->createFakeVideo($user);
        $data = ['name' => $video->name, 'category' => $video->category, 'path' => $video->path];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->get('/api/videos/search/'.$video->name)->seeJson($data)->seeStatusCode(200);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			use App\User;
4			use App\Video;
5			use Chrisbjr\ApiGuard\Models\ApiKey;
6			use Illuminate\Foundation\Testing\DatabaseMigrations;
7
8			/**
9			* Created by PhpStorm.
10			* User: adam
11			* Date: 22/04/16
12			* Time: 09:18.
13			*/
14			class VideoAPITest extends TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
15			{
16			use DatabaseMigrations;
17
18			/**
19			* Create fake user.
20			*
21			* @return mixed
22			*/
23			public function createUser()
24			{
25			$user = factory(User::class)->create();
26			$this->createUserApiKey($user);
			0 ignored issues – show Documentation introduced 2018-01-03 13:39 UTC by Report Bug Copy Issue Report `$user` is of type `object<Illuminate\Databa...se\Eloquent\Collection>`, but the function expects a `object<App\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27
28			return $user;
29			}
30
31			/**
32			* @param User $user
33			*
34			* @return mixed
35			*/
36			private function createUserApiKey(User $user)
37			{
38			$apiKey = ApiKey::make($user->id);

d3ltcod / LaravelTube

VideoAPITest A last analyzed 2018-01-04 22:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

VideoAPITest A
last analyzed 2018-01-04 22:25 UTC