GetTablesCommand::getSql() - Code Metrics - czogori/Rentgen - Measure and Improve Code Quality continuously with Scrutinizer

GetTablesCommand::getSql() A
last analyzed 2015-12-11 15:33 UTC

↳ Parent: GetTablesCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4286
cc	2
eloc	7
nc	2
nop	0

<?php
namespace Rentgen\Schema\Info;

use Rentgen\Schema\Command;
use Rentgen\Database\Table;
use Rentgen\Database\Schema;

class GetTablesCommand extends Command
{
    private $schemaName;

     /**
      * Sets a schema name.
      *
      * @param string $schemaName Schema name.
      *
      * @return GetTablesCommand
      */
    public function setSchemaName($schemaName)
    {
        $this->schemaName = $schemaName;

        return $this;
    }

     /**
     * {@inheritdoc}
     */
    public function getSql()
    {
        $schemaCondition = null === $this->schemaName
            ? ''
            : sprintf(" AND table_schema = '%s'", $this->schemaName);
        $sql = sprintf("SELECT table_name, table_schema FROM information_schema.tables WHERE table_schema <> 'information_schema'
            AND table_schema <> 'pg_catalog' AND table_type = 'BASE TABLE'%s;", $schemaCondition);

        return $sql;
    }

     /**
     * {@inheritdoc}
     */
    public function execute()

    {
        $this->preExecute();
        $result = $this->connection->query($this->getSql());
        $this->postExecute();

        $tables = array();
        foreach ($result as $row) {
            $tables[] = new Table($row['table_name'], new Schema($row['table_schema']));
        }

        return $tables;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2		namespace Rentgen\Schema\Info;
3
4		use Rentgen\Schema\Command;
5		use Rentgen\Database\Table;
6		use Rentgen\Database\Schema;
7
8		class GetTablesCommand extends Command
9		{
10		private $schemaName;
11
12		/**
13		* Sets a schema name.
14		*
15		* @param string $schemaName Schema name.
16		*
17		* @return GetTablesCommand
18		*/
19		public function setSchemaName($schemaName)
20		{
21		$this->schemaName = $schemaName;
22
23		return $this;
24		}
25
26		/**
27		* {@inheritdoc}
28		*/
29		public function getSql()
30		{
31		$schemaCondition = null === $this->schemaName
32		? ''
33		: sprintf(" AND table_schema = '%s'", $this->schemaName);
34		$sql = sprintf("SELECT table_name, table_schema FROM information_schema.tables WHERE table_schema <> 'information_schema'
35		AND table_schema <> 'pg_catalog' AND table_type = 'BASE TABLE'%s;", $schemaCondition);
36
37		return $sql;
38		}
39
40		/**
41		* {@inheritdoc}
42		*/
43	View Code Duplication	public function execute()
		0 ignored issues – show Duplication introduced 2015-12-09 12:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$this->preExecute();
46		$result = $this->connection->query($this->getSql());
47		$this->postExecute();
48
49		$tables = array();
50		foreach ($result as $row) {
51		$tables[] = new Table($row['table_name'], new Schema($row['table_schema']));
52		}
53
54		return $tables;
		0 ignored issues – show Bug Best Practice introduced 2015-12-09 12:12 UTC by Report Bug Copy Issue Report The return type of `return $tables;` (`array`) is incompatible with the return type of the parent method `Rentgen\Schema\Command::execute` of type `integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
55		}
56		}
57

czogori / Rentgen

GitHub Access Token became invalid

GetTablesCommand::getSql() A last analyzed 2015-12-11 15:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GetTablesCommand::getSql() A
last analyzed 2015-12-11 15:33 UTC