ConnectionPass::process() - Code Metrics - czogori/DamiBundle - Measure and Improve Code Quality continuously with Scrutinizer

ConnectionPass::process() A
last analyzed 2016-01-24 23:30 UTC

↳ Parent: ConnectionPass

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	3
eloc	12
nc	3
nop	1

<?php

namespace Czogori\DamiBundle\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\Yaml\Yaml;
use Symfony\Component\Config\FileLocator;

class ConnectionPass implements CompilerPassInterface
{
    /**
     * Processes container.
     *
     * @param ContainerBuilder $container
     */
    public function process(ContainerBuilder $container)
    {
        $dir = __DIR__ . '/../../../../../app/config';
        $fileLocator = new FileLocator($dir);
        foreach(array('dev', 'prod', 'test') as $environment) {
            $configFile = $fileLocator->locate('config_' . $environment . '.yml');
            $config = Yaml::parse($configFile);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if (isset($config['propel']['dbal'])) {
                $connectionConfig[$environment] = $config['propel']['dbal'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $connectionConfig[$environment]['adapter'] = $config['propel']['dbal']['driver'];
                $connectionConfig[$environment]['username'] = $config['propel']['dbal']['user'];
            }
        }
        $definition = $container->getDefinition('connection_config');
        $definition->setArguments(array($connectionConfig));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


GitHub Access Token became invalid

ConnectionPass::process() A
last analyzed 2016-01-24 23:30 UTC

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			namespace Czogori\DamiBundle\DependencyInjection\Compiler;
4
5			use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
6			use Symfony\Component\DependencyInjection\ContainerBuilder;
7			use Symfony\Component\Yaml\Yaml;
8			use Symfony\Component\Config\FileLocator;
9
10			class ConnectionPass implements CompilerPassInterface
11			{
12			/**
13			* Processes container.
14			*
15			* @param ContainerBuilder $container
16			*/
17			public function process(ContainerBuilder $container)
18			{
19			$dir = __DIR__ . '/../../../../../app/config';
20			$fileLocator = new FileLocator($dir);
21			foreach(array('dev', 'prod', 'test') as $environment) {
22			$configFile = $fileLocator->locate('config_' . $environment . '.yml');
23			$config = Yaml::parse($configFile);
			0 ignored issues – show Bug introduced 2016-01-24 23:30 UTC by Report Bug Copy Issue Report It seems like `$configFile` defined by `$fileLocator->locate('co... $environment . '.yml')` on line `22` can also be of type `array`; however, `Symfony\Component\Yaml\Yaml::parse()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
24			if (isset($config['propel']['dbal'])) {
25			$connectionConfig[$environment] = $config['propel']['dbal'];
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-19 22:53 UTC by Report Bug Copy Issue Report `$connectionConfig` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$connectionConfig = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
26			$connectionConfig[$environment]['adapter'] = $config['propel']['dbal']['driver'];
27			$connectionConfig[$environment]['username'] = $config['propel']['dbal']['user'];
28			}
29			}
30			$definition = $container->getDefinition('connection_config');
31			$definition->setArguments(array($connectionConfig));
			0 ignored issues – show Bug introduced 2016-01-19 22:53 UTC by Report Bug Copy Issue Report The variable `$connectionConfig` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
32			}
33			}
34

czogori / DamiBundle

GitHub Access Token became invalid

ConnectionPass::process() A last analyzed 2016-01-24 23:30 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ConnectionPass::process() A
last analyzed 2016-01-24 23:30 UTC