ColumnFactory::createInstance() - Code Metrics - czogori/Dami - Measure and Improve Code Quality continuously with Scrutinizer

ColumnFactory::createInstance() D
last analyzed 2017-05-31 08:43 UTC

↳ Parent: ColumnFactory

Complexity

Conditions	17
Paths	97

Size

Total Lines	34
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	4.9807
c	0
b	0
f	0
cc	17
eloc	26
nc	97
nop	0

How to fix Complexity

<?php

namespace Dami\Migration\Api;

class ColumnFactory
{
    /**
     * @param string $method A method name.
     * @param array  $params Parameters.
     */
    public function __construct($method, $params)
    {
        $this->method = $method;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->params = $params;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Create a new instance.
     *
     * @return Rentgen\Database\Column
     */
    public function createInstance()
    {
        switch ($this->method) {
            case 'addBigIntegerColumn':
            case 'addBinaryColumn':
            case 'addBooleanColumn':
            case 'addDateColumn':
            case 'addDateTimeColumn':
            case 'addDecimalColumn':
            case 'addFloatColumn':
            case 'addIntegerColumn':
            case 'addSmallIntegerColumn':
            case 'addStringColumn':
            case 'addTextColumn':
            case 'addTimeColumn':
                $namespace = 'Rentgen\\Database\\Column\\';
                $class = $namespace . ltrim($this->method, 'add');
                $options = isset($this->params[1]) ? $this->params[1] : array();

                if ('addStringColumn' === $this->method && !isset($options['limit'])) {
                    $options['limit'] = 255;
                }
                $column = new $class($this->params[0], $options);

                if (isset($options['comment'])) {
                    $column->setDescription($options['comment']);
                }
                break;
            default:
                throw new \Exception(sprintf("Unsupported method " . $this->method));
        }

        return $column;
    }
}


GitHub Access Token became invalid

ColumnFactory::createInstance() D
last analyzed 2017-05-31 08:43 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1			<?php
2
3			namespace Dami\Migration\Api;
4
5			class ColumnFactory
6			{
7			/**
8			* @param string $method A method name.
9			* @param array $params Parameters.
10			*/
11			public function __construct($method, $params)
12			{
13			$this->method = $method;
			0 ignored issues – show Bug introduced 2016-01-23 10:43 UTC by Report Bug Copy Issue Report The property `method` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14			$this->params = $params;
			0 ignored issues – show Bug introduced 2016-01-23 10:43 UTC by Report Bug Copy Issue Report The property `params` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			}
16
17			/**
18			* Create a new instance.
19			*
20			* @return Rentgen\Database\Column
21			*/
22			public function createInstance()
23			{
24			switch ($this->method) {
25			case 'addBigIntegerColumn':
26			case 'addBinaryColumn':
27			case 'addBooleanColumn':
28			case 'addDateColumn':
29			case 'addDateTimeColumn':
30			case 'addDecimalColumn':
31			case 'addFloatColumn':
32			case 'addIntegerColumn':
33			case 'addSmallIntegerColumn':
34			case 'addStringColumn':
35			case 'addTextColumn':
36			case 'addTimeColumn':
37			$namespace = 'Rentgen\\Database\\Column\\';
38			$class = $namespace . ltrim($this->method, 'add');
39			$options = isset($this->params[1]) ? $this->params[1] : array();
40
41			if ('addStringColumn' === $this->method && !isset($options['limit'])) {
42			$options['limit'] = 255;
43			}
44			$column = new $class($this->params[0], $options);
45
46			if (isset($options['comment'])) {
47			$column->setDescription($options['comment']);
48			}
49			break;
50			default:
51			throw new \Exception(sprintf("Unsupported method " . $this->method));
52			}
53
54			return $column;
55			}
56			}
57

czogori / Dami

GitHub Access Token became invalid

ColumnFactory::createInstance() D last analyzed 2017-05-31 08:43 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ColumnFactory::createInstance() D
last analyzed 2017-05-31 08:43 UTC