Conditions | 5 |
Paths | 6 |
Total Lines | 52 |
Code Lines | 38 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
18 | public function load(array $configs, ContainerBuilder $container) |
||
19 | { |
||
20 | $configFilename = 'config.yml'; |
||
21 | if (file_exists($configFilename)) { |
||
22 | $config = Yaml::parse(file_get_contents($configFilename)); |
||
23 | $container->setParameter('dami.migrations_directory', str_replace('@@DAMI_DIRECTORY@@', getcwd(), $config['migrations'])); |
||
24 | $this->defineConnectionConfigParameter($container, $config); |
||
25 | } else { |
||
26 | foreach ($configs as $config) { |
||
27 | if (isset($config['migrations_directory'])) { |
||
28 | $container->setParameter('dami.migrations_directory', $config['migrations_directory']); |
||
29 | } |
||
30 | } |
||
31 | } |
||
32 | $this->defineParameters($container); |
||
33 | if(!$container->hasParameter('dami.migrations_directory')) { |
||
34 | $container->setParameter('dami.migrations_directory', getcwd() . '/migrations'); |
||
35 | } |
||
36 | |||
37 | $definition = new Definition('%dami.migration_name_parser.class%'); |
||
38 | $container->setDefinition('dami.migration_name_parser', $definition); |
||
39 | |||
40 | $definition = new Definition('%dami.template_initialization.class%', |
||
41 | array(new Reference('dami.migration_name_parser'))); |
||
42 | $container->setDefinition('dami.template_initialization', $definition); |
||
43 | |||
44 | $definition = new Definition('%dami.template_renderer.class%', |
||
45 | array(new Reference('dami.template_initialization'))); |
||
46 | $container->setDefinition('dami.template_renderer', $definition); |
||
47 | |||
48 | $definition = new Definition('Dami\Migration\SchemaTable'); |
||
49 | $definition->setArguments(array(new Reference('connection'), |
||
50 | new Reference('rentgen.schema.manipulation'), new Reference('rentgen.schema.info'))); |
||
51 | $container->setDefinition('dami.schema_table', $definition); |
||
52 | |||
53 | $definition = new Definition('Dami\Migration\MigrationFiles'); |
||
54 | $definition->setArguments(array('%dami.migrations_directory%', new Reference('dami.schema_table'))); |
||
55 | $container->setDefinition('dami.migration_files', $definition); |
||
56 | |||
57 | $definition = new Definition('Dami\Migration'); |
||
58 | $definition->setArguments(array(new Reference('dami.schema_table'), |
||
59 | new Reference('dami.migration_files'), new Reference('rentgen.schema.manipulation'), new Reference('rentgen.schema.info'))); |
||
60 | $container->setDefinition('dami.migration', $definition); |
||
61 | |||
62 | $definition = new Definition('Dami\Cli\Verbosity'); |
||
63 | $container->setDefinition('dami.verbosity', $definition); |
||
64 | |||
65 | $definition = new Definition('Dami\EventListener\SqlSubscriber', |
||
66 | [new Reference('dami.verbosity')]); |
||
67 | $definition->addTag('kernel.event_subscriber'); |
||
68 | $container->setDefinition('dami.sql.subscriber', $definition); |
||
69 | } |
||
70 | |||
125 |