AbstractCommand::execute() - Code Metrics - czogori/Dami - Measure and Improve Code Quality continuously with Scrutinizer

AbstractCommand::execute() A
last analyzed 2017-05-31 08:43 UTC

↳ Parent: AbstractCommand

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	4
nop	2

<?php

namespace Dami\Cli\Command;

use Symfony\Component\Console\Command\Command,
    Symfony\Component\Console\Input\InputOption,
    Symfony\Component\Console\Input\InputInterface,
    Symfony\Component\Console\Output\OutputInterface;


class AbstractCommand extends Command
{
    protected function configure()
    {
        $this
            ->addOption('env', null, InputOption::VALUE_REQUIRED, 'Set environment');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->getContainer()->get('dami.verbosity')->change($output->getVerbosity());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        
        $environment = $input->getOption('env');
        if (null !== $environment) {
            $config = $this->getContainer()->get('connection_config');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $config->changeEnvironment($environment);
        }

        $migrationDirectory = $this->getContainer()->getparameter('dami.migrations_directory');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if (!file_exists($migrationDirectory)) {
            mkdir($migrationDirectory);
        }
    }
}


GitHub Access Token became invalid

AbstractCommand::execute() A
last analyzed 2017-05-31 08:43 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Dami\Cli\Command;
4
5			use Symfony\Component\Console\Command\Command,
6			Symfony\Component\Console\Input\InputOption,
7			Symfony\Component\Console\Input\InputInterface,
8			Symfony\Component\Console\Output\OutputInterface;
9
10
11			class AbstractCommand extends Command
12			{
13			protected function configure()
14			{
15			$this
16			->addOption('env', null, InputOption::VALUE_REQUIRED, 'Set environment');
17			}
18
19			protected function execute(InputInterface $input, OutputInterface $output)
20			{
21			$this->getContainer()->get('dami.verbosity')->change($output->getVerbosity());
			0 ignored issues – show Bug introduced 2016-01-23 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Dami\Cli\Command\AbstractCommand` as the method `getContainer()` does only exist in the following sub-classes of `Dami\Cli\Command\AbstractCommand`: `Dami\Cli\Command\ContainerAwareCommand`, `Dami\Cli\Command\CreateCommand`, `Dami\Cli\Command\MigrateCommand`, `Dami\Cli\Command\RollbackCommand`, `Dami\Cli\Command\StatusCommand`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
22
23			$environment = $input->getOption('env');
24			if (null !== $environment) {
25			$config = $this->getContainer()->get('connection_config');
			0 ignored issues – show Bug introduced 2016-01-23 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Dami\Cli\Command\AbstractCommand` as the method `getContainer()` does only exist in the following sub-classes of `Dami\Cli\Command\AbstractCommand`: `Dami\Cli\Command\ContainerAwareCommand`, `Dami\Cli\Command\CreateCommand`, `Dami\Cli\Command\MigrateCommand`, `Dami\Cli\Command\RollbackCommand`, `Dami\Cli\Command\StatusCommand`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26			$config->changeEnvironment($environment);
27			}
28
29			$migrationDirectory = $this->getContainer()->getparameter('dami.migrations_directory');
			0 ignored issues – show Bug introduced 2016-01-23 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Dami\Cli\Command\AbstractCommand` as the method `getContainer()` does only exist in the following sub-classes of `Dami\Cli\Command\AbstractCommand`: `Dami\Cli\Command\ContainerAwareCommand`, `Dami\Cli\Command\CreateCommand`, `Dami\Cli\Command\MigrateCommand`, `Dami\Cli\Command\RollbackCommand`, `Dami\Cli\Command\StatusCommand`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
30			if (!file_exists($migrationDirectory)) {
31			mkdir($migrationDirectory);
32			}
33			}
34			}
35

czogori / Dami

GitHub Access Token became invalid

AbstractCommand::execute() A last analyzed 2017-05-31 08:43 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AbstractCommand::execute() A
last analyzed 2017-05-31 08:43 UTC