ObjectToPreview::get_price() - Code Metrics - Inspection of "Add preview" - cyrrill/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f459ca...44ae62 )

by Cyril

created 2017-07-13 20:09 UTC

ObjectToPreview::get_price() B

↳ Parent: ObjectToPreview

Complexity

Conditions	8
Paths	128

Size

Total Lines	8
Code Lines	6

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
ccs	0
cts	8
cp	0
rs	7
cc	8
eloc	6
nc	128
nop	1
crap	72

<?php
/**
 *
 */
namespace ApaiIO\ResponseTransformer;

/**
 *
 */
class ObjectToPreview extends ObjectToArray implements ResponseTransformerInterface
{
	/**
	 *
	 * @var type
	 */
    protected $data = array();

	/**
	 *
	 * @var type
	 */
	protected $items = array();

	/**
	 *
	 * @param type $response
	 * @return type
	 */
	public function transform($response)
    {
        $response = parent::transform($response);

        if( ! $this->get_items( $response ) )
		{
			return array();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}
        $c = count( $this->items );
        for( $i=0; $i < $c; $i++ )
        {
            $this->set( $i, 'asin', 'ASIN' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'sales_rank', 'SalesRank' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'title', 'ItemAttributes', 'Title' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'url', 'DetailPageURL');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'manufacturer', 'ItemAttributes', 'Manufacturer' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'large_image', 'LargeImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'medium_image', 'MediumImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'small_image', 'SmallImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->get_price($i);
        }

        return $this->data;
    }

	/**
	 *
	 * @param type $response
	 * @return mixed
	 */
	protected function get_items($response)

	{
		if( isset($response['Items']['Item']) AND is_array($response['Items']['Item']) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
		{
			return $this->items = $response['Items']['Item'];
		}
		else
		{
			return FALSE;
		}
	}


	/**
	 *
	 * @param type $data
	 * @param type $key1
	 * @param type $key2
	 * @param type $key3
	 */
	protected function set($i, $data, $key1, $key2=NULL, $key3=NULL)

	{
		if($key3)
		{
			if( isset($this->items[$i][$key1][$key2][$key3]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1][$key2][$key3];
			}
		}
		elseif($key2)
		{
			if( isset($this->items[$i][$key1][$key2]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1][$key2];
			}
		}
		else
		{
			if( isset($this->items[$i][$key1]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1];
			}
		}
	}

    protected function set_array($i, $data, $key1, $key2=NULL, $key3=NULL)

    {
        $this->set($i, $data, $key1, $key2, $key3);
        if(isset($this->data[$i][$data]) AND !is_array( $this->data[$i][$data]))
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            $this->data[$i][$data] = array($this->data[$i][$data]);
        }
    }

    private function get_price($i)

    {
        $list_price = isset( $this->items[$i]['ItemAttributes']['ListPrice']['Amount'] ) ? $this->items[$i]['ItemAttributes']['ListPrice']['Amount'] : NULL;
        $amazon_price = isset( $this->items[$i]['Offers']['Offer']['OfferListing']['Price']['Amount'] ) ? $this->items[$i]['Offers']['Offer']['OfferListing']['Price']['Amount'] : NULL;
        $saved = isset( $this->items[$i]['Offers']['Offer']['OfferListing']['AmountSaved'] ) ? $this->items[$i]['Offers']['Offer']['OfferListing']['AmountSaved']['Amount'] : NULL;
        $price = ($list_price) ? $list_price : ($amazon_price ? ($amazon_price + $saved) : NULL );
        $this->data[$i]['price'] = ($price) ? $price : (isset($this->data[$i]['lowest_new_price']) ? $this->data[$i]['lowest_new_price'] : NULL);
    }
}

Push — master ( f459ca...44ae62 )

ObjectToPreview::get_price() B

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

cyrrill / apai-io

Push — master ( f459ca...44ae62 )

ObjectToPreview::get_price() B

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like