ObjectToItems - Code Metrics - cyrrill/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

ObjectToItems B
last analyzed 2017-08-01 15:15 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	201
Duplicated Lines	17.41 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	8
Bugs	0	Features	0

Metric	Value
wmc	38
c	8
b	0
f	0
lcom	1
cbo	1
dl	35
loc	201
ccs	0
cts	148
cp	0
rs	8.3999

9 Methods

Rating	Name	Duplication	Size	Complexity
B	transform()	0	43	3
A	set_array()	0	8	3
A	get_description()	0	8	2
B	get_image_sets()	13	24	6
A	get_category()	0	16	4
A	get_ancestor()	11	11	3
B	get_price()	0	8	8
A	get_items()	11	11	3
B	set()	0	24	6

How to fix Duplicated Code

<?php
/**
 *
 */
namespace ApaiIO\ResponseTransformer;

/**
 *
 */
class ObjectToItems extends ObjectToArray implements ResponseTransformerInterface
{
	/**
	 *
	 * @var type
	 */
    protected $data = array();

	/**
	 *
	 * @var type
	 */
	protected $items = array();

	/**
	 *
	 * @param type $response
	 * @return type
	 */
	public function transform($response)
    {
        $response = parent::transform($response);

        if( ! $this->get_items( $response ) )
		{
			return array();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}
        $c = count( $this->items );
        for( $i=0; $i < $c; $i++ )
        {
            $this->set( $i, 'asin', 'ASIN' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'sales_rank', 'SalesRank' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'title', 'ItemAttributes', 'Title' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'url', 'DetailPageURL');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'manufacturer', 'ItemAttributes', 'Manufacturer' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'isbn', 'ItemAttributes', 'ISBN' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'publisher', 'ItemAttributes', 'Publisher' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'number_of_pages', 'ItemAttributes', 'NumberOfPages' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'number_of_items', 'ItemAttributes', 'NumberOfItems' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'number_of_issues', 'ItemAttributes', 'NumberOfIssues' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'model', 'ItemAttributes', 'Model' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'label', 'ItemAttributes', 'Label' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'format', 'ItemAttributes', 'Format' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'edition', 'ItemAttributes', 'Edition' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'artist', 'ItemAttributes', 'Artist' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'description', 'EditorialReviews', 'EditorialReview', 'Content' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'lowest_new_price', 'OfferSummary', 'LowestNewPrice', 'Amount' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'large_image', 'LargeImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'medium_image', 'MediumImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'small_image', 'SmallImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set( $i, 'reviews', 'CustomerReviews', 'IFrameURL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->set_array( $i, 'author', 'ItemAttributes', 'Author' );
            $this->set_array( $i, 'features', 'ItemAttributes', 'Feature' );

            $this->get_price($i);
            $this->get_description($i);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->get_category($i);
            $this->get_image_sets($i);
        }

        return $this->data;
    }

	/**
	 *
	 * @param type $response
	 * @return mixed
	 */
	protected function get_items($response)

	{
		if( isset($response['Items']['Item']) AND is_array($response['Items']['Item']) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
		{
			return $this->items = $response['Items']['Item'];
		}
		else
		{
			return FALSE;
		}
	}


	/**
	 *
	 * @param type $data
	 * @param type $key1
	 * @param type $key2
	 * @param type $key3
	 */
	protected function set($i, $data, $key1, $key2=NULL, $key3=NULL)
	{
		if($key3)
		{
			if( isset($this->items[$i][$key1][$key2][$key3]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1][$key2][$key3];
			}
		}
		elseif($key2)
		{
			if( isset($this->items[$i][$key1][$key2]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1][$key2];
			}
		}
		else
		{
			if( isset($this->items[$i][$key1]) )
			{
				$this->data[$i][$data] = $this->items[$i][$key1];
			}
		}
	}

    protected function set_array($i, $data, $key1, $key2=NULL, $key3=NULL)
    {
        $this->set($i, $data, $key1, $key2, $key3);
        if(isset($this->data[$i][$data]) AND !is_array( $this->data[$i][$data]))
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            $this->data[$i][$data] = array($this->data[$i][$data]);
        }
    }

    private function get_price($i)
    {
        $list_price = isset( $this->items[$i]['ItemAttributes']['ListPrice']['Amount'] ) ? $this->items[$i]['ItemAttributes']['ListPrice']['Amount'] : NULL;
        $amazon_price = isset( $this->items[$i]['Offers']['Offer']['OfferListing']['Price']['Amount'] ) ? $this->items[$i]['Offers']['Offer']['OfferListing']['Price']['Amount'] : NULL;
        $saved = isset( $this->items[$i]['Offers']['Offer']['OfferListing']['AmountSaved'] ) ? $this->items[$i]['Offers']['Offer']['OfferListing']['AmountSaved']['Amount'] : NULL;
        $price = ($list_price) ? $list_price : ($amazon_price ? ($amazon_price + $saved) : NULL );
        $this->data[$i]['price'] = ($price) ? $price : (isset($this->data[$i]['lowest_new_price']) ? $this->data[$i]['lowest_new_price'] : NULL);
    }

    /**
     *
     * @param type $i
     */
    private function get_description($i)
    {
        $this->set($i, 'description', 'EditorialReviews', 'EditorialReview', 'Content');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if(isset($this->data[$i]['description']))
        {
            $this->data[$i]['description'] = $this->html2txt( $this->data[$i]['description'] );
        }
    }

    /**
	 *
	 */
	private function get_image_sets($i)
	{
		if( isset($this->items[$i]['ImageSets']['ImageSet'])
				AND is_array($this->items[$i]['ImageSets']['ImageSet']) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
		{
			$this->data[$i]['image_sets'] = array();

			$sets = $this->items[$i]['ImageSets'];

			foreach( $sets as $set )

			{
				$row = array();
				if( isset($set['MediumImage']['URL']) )
				{
					$row['medium_image'] = $set['MediumImage']['URL'];
				}
				if( isset($set['LargeImage']['URL']) )
				{
					$row['large_image'] = $set['LargeImage']['URL'];
				}
				$this->data[$i]['image_sets'][] = $row;
			}
		}
	}

    private function get_category($i)
    {
        if( isset($this->items[$i]['BrowseNodes']['BrowseNode'])
				AND is_array($this->items[$i]['BrowseNodes']['BrowseNode']) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
		{
			if( isset($this->items[$i]['BrowseNodes']['BrowseNode'][0]) )
            {
                $node = $this->items[$i]['BrowseNodes']['BrowseNode'][0];
            }
            else
            {
                $node = $this->items[$i]['BrowseNodes']['BrowseNode'];
            }
            $this->data[$i]['category'] = $this->get_ancestor( $node );
        }
    }

    private function get_ancestor($node)

    {
        if(isset($node['Ancestors']) AND is_array( $node['Ancestors'] ))
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            return $this->get_ancestor($node['Ancestors']['BrowseNode']);
        }
        else
        {
            return $node['Name'];
        }
    }
}

ObjectToItems B
last analyzed 2017-08-01 15:15 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

cyrrill / apai-io

ObjectToItems B last analyzed 2017-08-01 15:15 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

ObjectToItems B
last analyzed 2017-08-01 15:15 UTC