ObjectToItem - Code Metrics - cyrrill/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

ObjectToItem B
last analyzed 2017-08-01 15:15 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	263
Duplicated Lines	13.31 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	10
Bugs	0	Features	0

Metric	Value
wmc	46
c	10
b	0
f	0
lcom	1
cbo	1
dl	35
loc	263
ccs	0
cts	198
cp	0
rs	8.3999

10 Methods

Rating	Name	Duplication	Size	Complexity
C	set()	11	31	8
A	set_array()	0	8	3
B	get_price()	0	8	8
A	get_description()	0	15	3
B	get_reviews()	0	48	4
B	get_image_sets()	13	23	6
A	get_category()	0	15	4
A	get_ancestor()	11	11	4
B	transform()	0	38	2
A	get_item()	0	18	4

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ObjectToItem often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ObjectToItem, and based on these observations, apply Extract Interface, too.

<?php

/**
 *
 */

namespace ApaiIO\ResponseTransformer;

/**
 *
 */
class ObjectToItem extends ObjectToArray implements ResponseTransformerInterface {

    /**
     *
     * @var type
     */
    protected $data = array();

    /**
     *
     * @var type
     */
    protected $item = array();

    /**
     *
     * @param type $response
     * @return type
     */
    public function transform($response)
    {
        $response = parent::transform($response);

        if( !$this->get_item( $response ) )
        {
            return array();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->set( 'asin', 'ASIN' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'title', 'ItemAttributes', 'Title' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'manufacturer', 'ItemAttributes', 'Manufacturer' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'isbn', 'ItemAttributes', 'ISBN' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'publisher', 'ItemAttributes', 'Publisher' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'number_of_pages', 'ItemAttributes', 'NumberOfPages' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'number_of_items', 'ItemAttributes', 'NumberOfItems' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'number_of_issues', 'ItemAttributes', 'NumberOfIssues' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'model', 'ItemAttributes', 'Model' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'label', 'ItemAttributes', 'Label' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'format', 'ItemAttributes', 'Format' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'edition', 'ItemAttributes', 'Edition' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'artist', 'ItemAttributes', 'Artist' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'description', 'EditorialReviews', 'EditorialReview', 'Content' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'lowest_new_price', 'OfferSummary', 'LowestNewPrice', 'Amount' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'large_image', 'LargeImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'medium_image', 'MediumImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set( 'small_image', 'SmallImage', 'URL' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->set_array( 'author', 'ItemAttributes', 'Author' );
        $this->set_array( 'features', 'ItemAttributes', 'Feature' );

        $this->get_reviews();
        $this->get_price();
        $this->get_description();
        $this->get_category();
        $this->get_image_sets();

        return $this->data;
    }

    /**
     *
     * @param type $response
     * @return mixed
     */
    protected function get_item($response)
    {
        if( isset( $response['Items']['Item'] ) AND is_array( $response['Items']['Item'] ) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            if( array_key_exists( 1, $response['Items']['Item'] ) )
            {
                return $this->item = $response['Items']['Item'][0];
            }
            else
            {
                return $this->item = $response['Items']['Item'];
            }
        }
        else
        {
            return FALSE;
        }
    }

    /**
     *
     * @param type $data
     * @param type $key1
     * @param type $key2
     * @param type $key3
     */
    protected function set($data, $key1, $key2 = NULL, $key3 = NULL, $key4 = NULL)
    {
        if( $key4 )
        {
            if( isset( $this->item[$key1][$key2][$key3][$key4] ) )

            {
                $this->data[$data] = $this->item[$key1][$key2][$key3][$key4];
            }
        }
        elseif( $key3 )

        {
            if( isset( $this->item[$key1][$key2][$key3] ) )
            {
                $this->data[$data] = $this->item[$key1][$key2][$key3];
            }
        }
        elseif( $key2 )
        {
            if( isset( $this->item[$key1][$key2] ) )
            {
                $this->data[$data] = $this->item[$key1][$key2];
            }
        }
        else
        {
            if( isset( $this->item[$key1] ) )
            {
                $this->data[$data] = $this->item[$key1];
            }
        }
    }

    protected function set_array($data, $key1, $key2 = NULL, $key3 = NULL)
    {
        $this->set( $data, $key1, $key2, $key3 );
        if( isset( $this->data[$data] ) AND !is_array( $this->data[$data] ) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            $this->data[$data] = array($this->data[$data]);
        }
    }

    private function get_price()
    {
        $list_price = isset( $this->item['ItemAttributes']['ListPrice']['Amount'] ) ? $this->item['ItemAttributes']['ListPrice']['Amount'] : NULL;
        $amazon_price = isset( $this->item['Offers']['Offer']['OfferListing']['Price']['Amount'] ) ? $this->item['Offers']['Offer']['OfferListing']['Price']['Amount'] : NULL;
        $saved = isset( $this->item['Offers']['Offer']['OfferListing']['AmountSaved'] ) ? $this->item['Offers']['Offer']['OfferListing']['AmountSaved']['Amount'] : NULL;
        $price = ($list_price) ? $list_price : ($amazon_price ? ($amazon_price + $saved) : NULL );
        $this->data['price'] = ($price) ? $price : (isset($this->data['lowest_new_price']) ? $this->data['lowest_new_price'] : 0);
    }

    private function get_description()
    {
        if(isset( $this->item['EditorialReviews']['EditorialReview'][1] ) )
        {
            $this->set( 'description', 'EditorialReviews', 'EditorialReview', 0, 'Content' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        else
        {
            $this->set( 'description', 'EditorialReviews', 'EditorialReview', 'Content' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        if( isset( $this->data['description'] ) )
        {
            $this->data['description'] = $this->html2txt( $this->data['description'] );
        }
    }

    /**
     * Parses the Amazon reviews iframe to get precise numeric review metrics
     */
    private function get_reviews()
    {
        if( isset( $this->item['CustomerReviews']['IFrameURL'] ) )
        {
            // Load the iFrame HTML from the URL returned by the API
            $text = file_get_contents( $this->item['CustomerReviews']['IFrameURL'] );

            // Clean up the HTML removing scripts and other unneeded data
            $text = preg_replace( '/(<style>.+?)+(<\/style>)/i', '', $text );
            $search = array('@<script[^>]*?>.*?</script>@si',  // javascript
                            '@<style[^>]*?>.*?</style>@siU',   // style tags properly
                            '@<![\s\S]*?--[ \t\n\r]*>@',       // multi-line comments including CDATA
                            '/^\n+|^[\t\s]*\n+/m',             // empty lines
            );
            $text = trim( preg_replace( $search, '', $text ) );

            // Load HTML into SimpleXML for parsing
            libxml_use_internal_errors( TRUE );
            $dom = new \DOMDocument();
            $dom->strictErrorChecking = FALSE;
            $dom->recover = TRUE;
            $dom->loadHTML( $text );
            $xml = simplexml_import_dom( $dom );

            // Get the total amount of reviews
            $stars = $xml->xpath( "//span[@class='crAvgStars']" );
            $total_reviews = isset( $stars[0] ) ? (int)preg_replace( '/[^\d]/', '', $stars[0]->a ) : 0;

            // Get the average rating
            $summary = $xml->xpath( "//span[@class='asinReviewsSummary']" );
            if( isset($summary[0]) )
            {
                $img = $summary[0]->xpath('a/img');
                $summary = preg_replace( '/[^\d]/', '', (string)$img[0]->attributes()->alt );
                $summary = (float)((int)substr( $summary, 0, strlen($summary)-1 ))/10;
            }
            else
            {
                $summary = 0;
            }

            // Set data in response
            $this->data['reviews'] = array(
                'total' => $total_reviews,
                'average' => $summary,
            );
        }
    }

    /**
     *
     */
    private function get_image_sets()
    {
        if( isset( $this->item['ImageSets']['ImageSet'] ) AND is_array( $this->item['ImageSets']['ImageSet'] ) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            $this->data['image_sets'] = array();

            $sets = $this->item['ImageSets'];

            foreach( $sets as $set )

            {
                $row = array();
                if( isset( $set['MediumImage']['URL'] ) )
                {
                    $row['medium_image'] = $set['MediumImage']['URL'];
                }
                if( isset( $set['LargeImage']['URL'] ) )
                {
                    $row['large_image'] = $set['LargeImage']['URL'];
                }
                $this->data['image_sets'][] = $row;
            }
        }
    }

    private function get_category()
    {
        if( isset( $this->item['BrowseNodes']['BrowseNode'] ) AND is_array( $this->item['BrowseNodes']['BrowseNode'] ) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            if( isset( $this->item['BrowseNodes']['BrowseNode'][0] ) )
            {
                $node = $this->item['BrowseNodes']['BrowseNode'][0];
            }
            else
            {
                $node = $this->item['BrowseNodes']['BrowseNode'];
            }
            $this->data['category'] = $this->get_ancestor( $node );
        }
    }

    private function get_ancestor($node)

    {
        if( isset( $node['Ancestors'] ) AND is_array( $node['Ancestors'] ) )
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
        {
            return $this->get_ancestor( $node['Ancestors']['BrowseNode'] );
        }
        else
        {
            return isset( $node['Name'] ) ? $node['Name'] : 'Uncategorized';
        }
    }

}


ObjectToItem B
last analyzed 2017-08-01 15:15 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

cyrrill / apai-io

ObjectToItem B last analyzed 2017-08-01 15:15 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

ObjectToItem B
last analyzed 2017-08-01 15:15 UTC