Cycle\Schema\Definition\Relation

Complexity

Total Complexity

12

Size/Duplication

Total Lines	114
Duplicated Lines	0 %

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	isInversed()	0	3	1
A	getOptions()	0	3	1
A	getType()	0	7	2
A	getInverseName()	0	3	1
A	setInverse()	0	6	1
A	getInverseType()	0	3	1
A	setTarget()	0	5	1
A	setType()	0	5	1
A	getTarget()	0	7	2

<?php declare(strict_types=1);
/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

namespace Cycle\Schema\Definition;

use Cycle\Schema\Definition\Map\OptionMap;
use Cycle\Schema\Exception\RelationException;

final class Relation
{
    /** @var OptionMap */
    private $options;

    /** @var string */
    private $type;

    /** @var string */
    private $target;

    /** @var string|null */
    private $inverse = null;

    /** @var string|null */
    private $inverseType = null;

    /**
     * Relation constructor.
     */
    public function __construct()
    {
        $this->options = new OptionMap();
    }

    /**
     * @return OptionMap
     */
    public function getOptions(): OptionMap
    {
        return $this->options;
    }

    /**
     * @param string $type
     * @return Relation
     */
    public function setType(string $type): Relation
    {
        $this->type = $type;

        return $this;
    }

    /**
     * @return string
     */
    public function getType(): string
    {
        if ($this->type === null) {
            throw new RelationException("Relation type must be set");
        }

        return $this->type;
    }

    /**
     * @param string $target
     * @return Relation
     */
    public function setTarget(string $target): Relation
    {
        $this->target = $target;

        return $this;
    }

    /**
     * @return string
     */
    public function getTarget(): string
    {
        if ($this->target === null) {
            throw new RelationException("Relation target must be set");
        }

        return $this->target;
    }

    /**
     * @param string $into
     * @param string $as
     * @return Relation
     */
    public function setInverse(string $into, string $as): Relation
    {
        $this->inverse = $into;
        $this->inverseType = $as;

        return $this;
    }

    /**
     * @return bool
     */
    public function isInversed(): bool
    {
        return $this->inverse != null;

It seems like you are loosely comparing $this->inverse of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    }

    /**
     * @return string|null
     */
    public function getInverseName(): ?string
    {
        return $this->inverse;
    }

    /**
     * @return string|null
     */
    public function getInverseType(): ?string
    {
        return $this->inverseType;
    }
}