UpdatePromiseMethods::ignoreMethod() - Code Metrics - Inspection of "Change namespaces" - cycle/proxy-factory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d3a94c...76e109 )

by Valentin

created 2019-03-04 13:40 UTC

UpdatePromiseMethods::ignoreMethod() A

↳ Parent: UpdatePromiseMethods

Complexity

Conditions	6
Paths	2

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	9.2222
c	0
b	0
f	0
cc	6
nc	2
nop	1

<?php
declare(strict_types=1);

namespace Cycle\ORM\Promise\Visitor;

use PhpParser\Node;
use PhpParser\NodeVisitorAbstract;

/**
 * Modify all accessible methods
 */
class UpdatePromiseMethods extends NodeVisitorAbstract
{
    /** @var string */
    private $property;

    public function __construct(string $property)
    {
        $this->property = $property;
    }

    /**
     * {@inheritdoc}
     */
    public function leaveNode(Node $node)
    {
        if ($node instanceof Node\Stmt\ClassMethod && !$this->ignoreMethod($node)) {
            $node->stmts = [new Node\Stmt\Return_($this->resolvedParentMethodCall($node))];
        }

        return null;
    }

    private function ignoreMethod(Node\Stmt\ClassMethod $node): bool

    {
        if ($node->isPrivate() || $node->isStatic() || $node->isFinal() || $node->isAbstract() || $node->isMagic()) {
            return true;
        }

        return false;
    }

    private function resolvedParentMethodCall(Node\Stmt\ClassMethod $node): Node\Expr\MethodCall
    {
        return new Node\Expr\MethodCall($this->resolverCall(), $node->name->name);
    }

    private function resolverCall(): Node\Expr\PropertyFetch
    {
        return new Node\Expr\PropertyFetch(new Node\Expr\Variable('this'), $this->property);
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Cycle\ORM\Promise\Visitor;
5
6		use PhpParser\Node;
7		use PhpParser\NodeVisitorAbstract;
8
9		/**
10		* Modify all accessible methods
11		*/
12		class UpdatePromiseMethods extends NodeVisitorAbstract
13		{
14		/** @var string */
15		private $property;
16
17		public function __construct(string $property)
18		{
19		$this->property = $property;
20		}
21
22		/**
23		* {@inheritdoc}
24		*/
25		public function leaveNode(Node $node)
26		{
27		if ($node instanceof Node\Stmt\ClassMethod && !$this->ignoreMethod($node)) {
28		$node->stmts = [new Node\Stmt\Return_($this->resolvedParentMethodCall($node))];
29		}
30
31		return null;
32		}
33
34	View Code Duplication	private function ignoreMethod(Node\Stmt\ClassMethod $node): bool
		0 ignored issues – show Duplication introduced 2019-02-20 08:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		if ($node->isPrivate() \|\| $node->isStatic() \|\| $node->isFinal() \|\| $node->isAbstract() \|\| $node->isMagic()) {
37		return true;
38		}
39
40		return false;
41		}
42
43		private function resolvedParentMethodCall(Node\Stmt\ClassMethod $node): Node\Expr\MethodCall
44		{
45		return new Node\Expr\MethodCall($this->resolverCall(), $node->name->name);
46		}
47
48		private function resolverCall(): Node\Expr\PropertyFetch
49		{
50		return new Node\Expr\PropertyFetch(new Node\Expr\Variable('this'), $this->property);
51		}
52		}

cycle / proxy-factory

Push — master ( d3a94c...76e109 )

UpdatePromiseMethods::ignoreMethod() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like