Traverser::traverseClonedNodes() - Code Metrics - Inspection of "Change namespaces" - cycle/proxy-factory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d3a94c...76e109 )

by Valentin

created 2019-03-04 13:40 UTC

Traverser::traverseClonedNodes() A

↳ Parent: Traverser

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php
declare(strict_types=1);

namespace Cycle\ORM\Promise;

use PhpParser\NodeTraverser;
use PhpParser\NodeVisitor;
use PhpParser\Parser;
use PhpParser\ParserFactory;

class Traverser
{
    /** @var Parser */
    private $parser;

    public function __construct(Parser $parser = null)
    {
        $this->parser = $parser ?? (new ParserFactory())->create(ParserFactory::ONLY_PHP7);
    }

    public function traverseFilename(string $filename, NodeVisitor ...$visitors)
    {
        return $this->makeTraverser(...$visitors)->traverse($this->parseNodes($filename));

    }

    public function traverseClonedNodes(array $nodes, NodeVisitor ...$visitors)
    {
        return $this->makeTraverser(...$visitors)->traverse($this->cloneNodes($nodes));
    }

    private function parseNodes(string $filename)
    {
        return $this->parser->parse(file_get_contents($filename));
    }

    private function cloneNodes(array $nodes)
    {
        return $this->makeTraverser(new NodeVisitor\CloningVisitor())->traverse($nodes);
    }

    private function makeTraverser(NodeVisitor ...$visitors): NodeTraverser
    {
        $traverser = new NodeTraverser();
        foreach ($visitors as $visitor) {
            $traverser->addVisitor($visitor);
        }

        return $traverser;
    }
}

1			<?php
2			declare(strict_types=1);
3
4			namespace Cycle\ORM\Promise;
5
6			use PhpParser\NodeTraverser;
7			use PhpParser\NodeVisitor;
8			use PhpParser\Parser;
9			use PhpParser\ParserFactory;
10
11			class Traverser
12			{
13			/** @var Parser */
14			private $parser;
15
16			public function __construct(Parser $parser = null)
17			{
18			$this->parser = $parser ?? (new ParserFactory())->create(ParserFactory::ONLY_PHP7);
19			}
20
21			public function traverseFilename(string $filename, NodeVisitor ...$visitors)
22			{
23			return $this->makeTraverser(...$visitors)->traverse($this->parseNodes($filename));
			0 ignored issues – show Bug introduced 2019-03-04 13:46 UTC by Report Bug Copy Issue Report It seems like `$this->parseNodes($filename)` targeting `Cycle\ORM\Promise\Traverser::parseNodes()` can also be of type `null`; however, `PhpParser\NodeTraverser::traverse()` does only seem to accept `array<integer,object<PhpParser\Node>>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
24			}
25
26			public function traverseClonedNodes(array $nodes, NodeVisitor ...$visitors)
27			{
28			return $this->makeTraverser(...$visitors)->traverse($this->cloneNodes($nodes));
29			}
30
31			private function parseNodes(string $filename)
32			{
33			return $this->parser->parse(file_get_contents($filename));
34			}
35
36			private function cloneNodes(array $nodes)
37			{
38			return $this->makeTraverser(new NodeVisitor\CloningVisitor())->traverse($nodes);
39			}
40
41			private function makeTraverser(NodeVisitor ...$visitors): NodeTraverser
42			{
43			$traverser = new NodeTraverser();
44			foreach ($visitors as $visitor) {
45			$traverser->addVisitor($visitor);
46			}
47
48			return $traverser;
49			}
50			}

cycle / proxy-factory

Push — master ( d3a94c...76e109 )

Traverser::traverseClonedNodes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like