cycle / orm

src/Parser/EmbeddedNode.php

<?php

declare(strict_types=1);

namespace Cycle\ORM\Parser;

use Cycle\ORM\Exception\ParserException;

/**
 * @internal
 */
final class EmbeddedNode extends AbstractNode
{
    protected function push(array &$data): void
    {
        if ($this->parent === null) {
            throw new ParserException('Unable to register data tree, parent is missing');
        }

        $this->parent->mount(
            $this->container,

It seems like $this->container can also be of type null; however, parameter $container of Cycle\ORM\Parser\AbstractNode::mount() does only seem to accept string, maybe add an additional type check?

            $this->indexName,

It seems like $this->indexName can also be of type null; however, parameter $index of Cycle\ORM\Parser\AbstractNode::mount() does only seem to accept string, maybe add an additional type check?

            self::LAST_REFERENCE,
            $data,
        );
    }
}