cycle / orm

src/Parser/ArrayNode.php

<?php

declare(strict_types=1);

namespace Cycle\ORM\Parser;

use Cycle\ORM\Exception\ParserException;

/**
 * Parses multiple sub children and mount them under parent node.
 *
 * @internal
 */
final class ArrayNode extends AbstractNode
{
    /**
     * @param string[] $columns
     * @param string[] $primaryKeys
     * @param string[] $innerKeys Inner relation key (for example user_id)
     * @param string[]|null $outerKeys Outer (parent) relation key (for example id = parent.id)
     */
    public function __construct(
        array $columns,
        array $primaryKeys,
        protected array $innerKeys,
        ?array $outerKeys,
    ) {
        parent::__construct($columns, $outerKeys);
        $this->setDuplicateCriteria($primaryKeys);
    }

    protected function push(array &$data): void
    {
        if ($this->parent === null) {
            throw new ParserException('Unable to register data tree, parent is missing.');
        }

        foreach ($this->innerKeys as $key) {
            if ($data[$key] === null) {
                // no data was parsed
                return;
            }
        }

        $this->parent->mountArray(
            $this->container,

It seems like $this->container can also be of type null; however, parameter $container of Cycle\ORM\Parser\AbstractNode::mountArray() does only seem to accept string, maybe add an additional type check?

            $this->indexName,

It seems like $this->indexName can also be of type null; however, parameter $index of Cycle\ORM\Parser\AbstractNode::mountArray() does only seem to accept string, maybe add an additional type check?

            $this->intersectData($this->innerKeys, $data),
            $data,
        );
    }
}